Collapse button

[tino]

That is not what I meant, but maybe even better... 

It will only show for logged in users mind. So will need some thinking about for people who aren't logged in. Although you could argue they shouldn't be able to collapse the panels.

[@rjen]

I like the solution. So much that I just coded is into my repository.

So 2.0 remains the way it was, 2.1 can get that location.
The only downside is that the collapse buttons will only be available for logged-in users.

How do the others feel about that? Shall I commit it?
If we do not like it, we can always reverse it again...

[tino]

I like the solution. So much that I just coded is into my repository.

Try this instead...

Code: [Select]

$buffer = preg_replace('~<div class="navigate_section">\s*<ul>~', '<div class="navigate_section"><ul><span class="tp_upshrink" style="float:right; margin-top:6px; padding-left:10px;">'.$context['TPortal']['upshrinkpanel'].'</span>', $buffer);

[@rjen]

Better 

but somehow two buttons go missing for guests... need to check why first.

[tino]

Better 

but somehow two buttons go missing for guests... need to check why first.

Do you have the css and my inline styling? It's ok for me

[tino]

It does need different styling on less than a 720px screen though. Probably align it to the left so it fits with the other items.

[@rjen]

Ok, fixed it. Looks good, I'll submit the PR.


I just noticed that in the console the toggle is throwing some error (not related to this change).

Code: [Select]

index.php:103 Uncaught TypeError: Cannot read property 'style' of null
    at togglepanel (index.php:103)
    at HTMLAnchorElement.onclick (index.php:441)

What's that?

[tino]

I don't get that, I get the can't find the element error

[tino]

Ok its the same error Chrome ( which I guess you use ) reports it differently to Firefox. It means it can't find the elementid img which is correct as it's not called that.

[@rjen]

Yep, I use Chrome