News: September 21st, 2019, The Tinyportal team is pleased to announce the release of ~~ TinyPortal 1.6.4! GET IT NOW!!!

Login  |  Register
HTML5 Icon HTML5 Icon
TP on Social Media
Welcome, Guest. Please login or register.
Did you miss your activation email?

September 22, 2019, 09:38:50 PM

Login with username, password and session length

Recent

Members
Stats
  • Total Posts: 188947
  • Total Topics: 20756
  • Online Today: 113
  • Online Ever: 629
  • (November 08, 2018, 01:36:54 PM)
Users Online
Users: 0
Guests: 69
Total: 69

Author Topic: Link goes no where  (Read 2574 times)

0 Members and 1 Guest are viewing this topic.

Offline @rjen

  • Support Team
  • *
  • Posts: 1831
    • FJR-club Nederland
Re: Link goes no where
« Reply #60 on: December 03, 2018, 12:05:29 PM »
It's definitely an improvement...

see here: https://test2.fjr-club.nl/index.php

Now the other links in the postings are clickable again..

Before you submit the change, would you mind to include class="tp_readmore" ? I added that to the css to force enough margin for the Read More links...

Code: [Select]
$row['body'] .= '... <p class="tp_readmore"><strong>'.$smcFunc['htmlspecialchars']('<a href="'. $scripturl. '?topic='. $row['id']. '">'. $txt['tp-readmore']. '</a>').'</strong></p>';
Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6236
    • Camera Craniums
Re: Link goes no where
« Reply #61 on: December 03, 2018, 12:40:19 PM »
Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

Offline @rjen

  • Support Team
  • *
  • Posts: 1831
    • FJR-club Nederland
Re: Link goes no where
« Reply #62 on: December 03, 2018, 12:43:33 PM »
Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

The css for that is still waiting to be merged...
Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6236
    • Camera Craniums
Re: Link goes no where
« Reply #63 on: December 03, 2018, 12:57:41 PM »
Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

The css for that is still waiting to be merged...

Wasn't sure if anything else was going in, so held off.  I edited the file on my site manually.

I can merge now if you wish.  ;)

@tino. Was wondering if there's anything here that shines some light on the 2.1 bbc problems, https://github.com/SimpleMachines/SMF2.1/search?q=bbc&type=Issues

Offline lurkalot

  • Administrator
  • *
  • Posts: 6236
    • Camera Craniums
Re: Link goes no where
« Reply #64 on: December 03, 2018, 03:52:27 PM »
Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

The css for that is still waiting to be merged...

Those last pull requests, do they contain the fix for the read more links that tino posted, plus some more from yourself?

Just I tried it and they are broken again.

Offline tino

  • Developer
  • *
  • Posts: 1654
Re: Link goes no where
« Reply #65 on: December 03, 2018, 05:24:40 PM »
Just pushed a commit which should sort it for SMF 2.0 and SMF 2.1 it's the more elegant way to do the fix anyway. Shouldn't break anything backwards compatible mind. Also incremented all the version numbers to 1.6.2

Offline @rjen

  • Support Team
  • *
  • Posts: 1831
    • FJR-club Nederland
Re: Link goes no where
« Reply #66 on: December 03, 2018, 10:46:28 PM »
The two PR together should make the fix, but I think the ... should have remained in the body text....

Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6236
    • Camera Craniums
Re: Link goes no where
« Reply #67 on: December 03, 2018, 11:39:23 PM »
Thanks guys. Installed on my live 2.1 test site now, seems good atm. http://cctestsite.info/testsite3/index.php

Also added a beta topic for 1.6.2 and included the zip.  ;)

Offline @rjen

  • Support Team
  • *
  • Posts: 1831
    • FJR-club Nederland
Re: Link goes no where
« Reply #68 on: December 03, 2018, 11:54:35 PM »
Missing the spacing between the body and read more text though...
Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6236
    • Camera Craniums
Re: Link goes no where
« Reply #69 on: December 04, 2018, 12:08:03 AM »
Missing the spacing between the body and read more text though...

Looks ok to me.  ??? Got a screenshot of what it looks like, and what it should look like for comparison?