News: When asking for support, it helps us and you, if you read the Posting Guidelines

Login  |  Register
* *
HTML5 Icon HTML5 Icon
TP on Social Media
Welcome, Guest. Please login or register.
Did you miss your activation email?
December 18, 2018, 03:27:10 AM

Login with username, password and session length

Recent

Members
  • Total Members: 3734
  • Latest: nati9
Stats
  • Total Posts: 186794
  • Total Topics: 20608
  • Online Today: 28
  • Online Ever: 629
  • (November 08, 2018, 01:36:54 PM)
Users Online
Users: 0
Guests: 21
Total: 21

Author Topic: Link goes no where  (Read 885 times)

0 Members and 1 Guest are viewing this topic.

Offline tino

  • Developer
  • *
  • Posts: 1338
Re: Link goes no where
« Reply #70 on: December 04, 2018, 12:12:53 AM »
The two PR together should make the fix, but I think the ... should have remained in the body text....

The only way this will work is if we get SMF to change parse_bbc

Offline lurkalot

  • Administrator
  • *
  • Posts: 5496
    • Camera Craniums
Re: Link goes no where
« Reply #71 on: December 04, 2018, 12:19:42 AM »
The bbc stuff, would this related to the smileys not showing on the front page, I'm assuming in those promoted posts and articles.  I just saw a post on his site saying they were not working. They do on my test site running 1.6.2 though.

Offline @rjen

  • Support Team
  • *
  • Posts: 1170
    • FJR-club Nederland
Re: Link goes no where
« Reply #72 on: December 04, 2018, 12:42:10 AM »
Missing the spacing between the body and read more text though...

Looks ok to me.  ??? Got a screenshot of what it looks like, and what it should look like for comparison?

Never mind, it looks the way it is supposed to. Just realised I was on my mobile this morning, and refreshing the cache had not been done...

And Tino: you where right to split the Read More text into a separate variable. When I saw the code I was afraid that the three dots would be split from the body text like so...

Quote
end of Body text

... Read More
but again, on a pc it shows I was wrong...

What's this about Smileys not showing on promoted posts?
I am seeing at least one...

Running TP1.6.1 on SMF2.0 at: www.fjr-club.nl

Testing TP1.6.2 on SMF2.0
Testing TP1.6.2 on SMF2.1
Want to check what php version I am testing on? See: PHP Info

Offline @rjen

  • Support Team
  • *
  • Posts: 1170
    • FJR-club Nederland
Re: Link goes no where
« Reply #73 on: December 04, 2018, 12:51:11 AM »
Just read your reply on whatsyourbeef Mick: you are right: latest code fixes it: the quick and dirty workaround that they are using now actually will cause this because it is no longer parses the body text...
Running TP1.6.1 on SMF2.0 at: www.fjr-club.nl

Testing TP1.6.2 on SMF2.0
Testing TP1.6.2 on SMF2.1
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 5496
    • Camera Craniums
Re: Link goes no where
« Reply #74 on: December 04, 2018, 10:30:58 AM »
Just read your reply on whatsyourbeef Mick: you are right: latest code fixes it: the quick and dirty workaround that they are using now actually will cause this because it is no longer parses the body text...

Thanks, thought that was the case.  :)

Thinking perhaps we should add bigguy to the beta group, the more testers the merrier imo. As long as he's happy with that of course.  ;)

Offline lurkalot

  • Administrator
  • *
  • Posts: 5496
    • Camera Craniums
Re: Link goes no where
« Reply #75 on: December 04, 2018, 12:38:55 PM »
Just read your reply on whatsyourbeef Mick: you are right: latest code fixes it: the quick and dirty workaround that they are using now actually will cause this because it is no longer parses the body text...

Actually while you were there, did you notice when clicking to a article category from the front page article, Giving Support

https://www.whatsurbeef.net/index.php  Gives this, https://www.whatsurbeef.net/index.php?cat=ga

The text seems shifted to the left and is slightly cut off. But fine when viewing the actual article.  Not sure if this is another bug when running in 2.1.  Doesn't appear to do this on a 2.0.15 based install, or at least I can't replicate it.

Offline @rjen

  • Support Team
  • *
  • Posts: 1170
    • FJR-club Nederland
Re: Link goes no where
« Reply #76 on: December 04, 2018, 12:55:36 PM »
I am not seeing what you mean. But I have no account there and you do. Does it show this as guest too?
Running TP1.6.1 on SMF2.0 at: www.fjr-club.nl

Testing TP1.6.2 on SMF2.0
Testing TP1.6.2 on SMF2.1
Want to check what php version I am testing on? See: PHP Info

Offline tino

  • Developer
  • *
  • Posts: 1338
Re: Link goes no where
« Reply #77 on: December 04, 2018, 12:57:38 PM »
I can see the same as lurkalot on a PC. When viewing on the category listing it's slightly off the page.

It however doesn't do the same on my test one here so I think it's a styling issue with that site.

Offline @rjen

  • Support Team
  • *
  • Posts: 1170
    • FJR-club Nederland
Re: Link goes no where
« Reply #78 on: December 04, 2018, 01:05:15 PM »
I see it now, and it is TP related I am afraid.

Caused by tp_col16, which has a style of: margin-left: -20px;
Line 41 of tp_style.css...

need to check why that is not giving this issue in curve2
Running TP1.6.1 on SMF2.0 at: www.fjr-club.nl

Testing TP1.6.2 on SMF2.0
Testing TP1.6.2 on SMF2.1
Want to check what php version I am testing on? See: PHP Info

Offline @rjen

  • Support Team
  • *
  • Posts: 1170
    • FJR-club Nederland
Re: Link goes no where
« Reply #79 on: December 04, 2018, 01:10:17 PM »
Strange! That line is not in our css ... did someone remove that recently?
Running TP1.6.1 on SMF2.0 at: www.fjr-club.nl

Testing TP1.6.2 on SMF2.0
Testing TP1.6.2 on SMF2.1
Want to check what php version I am testing on? See: PHP Info