New TP version 1.1 and guest comments

[wildenborch]

Yes I am able to delete comments when logged in as Admin.

[wildenborch]

Hi Lurkalot,

I/m not sure if the following is also caused by the new functionality that guest can post but if I click the show latest comments in the USER block in the left menu I get the message Sorry, you are not allowed to comment

When, in the addressbar I type ?action=tpmod;sa=showcomments;showall
I see all comments. Without the ;showall i get te message Sorry, you are not allowed to comment.

BTW, it would be nice if this showall listing would also include a delete comment button (if logged in as admin!)

Best regards,

PS, if I should make a new topic for this, please let me know.

[lurkalot]

Yes I am!

Thanks, at least that bit's working.  Phew was worried there forma minute.

I had to ask that because the login you sent me doesn't seem to work. I did reply to you PM, but the it's not easy to see you have any replies with the theme on here.

[lurkalot]

PS, if I should make a new topic for this, please let me know.

Might be an idea to keep separate, will make it easier to track.

Thanks. 

[wildenborch]

You should now be able to login.

Best regards,
Fred

[wildenborch]

And a new topic has been made!

http://www.tinyportal.net/index.php?topic=35499.msg284476#msg284476

[lurkalot]

You should now be able to login.

Best regards,
Fred

Thanks.  I'm investigating your issues as I type. Might take sometime to come up with something, so please bare with me. Unless someone else on the team has the answer that is. 

[lurkalot]

The code you changed is not correct wildenborch.  I think the code is correct on the TP side. I'm just not sure allowing guests to delete comments is a good idea?

IchBin™ There doesn't seem to be any other way to hide that delete button for guests, other than edit that code, like wildenborch has.  Am I missing something obvious?

[illori]

Hi,

First I would like to thank you for the update to version 1.1!

I just want to know if it is correct that guest users can push the remove comment button (although the comments are not deleted??

In any case I changed line 1731 the TPsubs.template.php into

Code Select Expand

if(allowedTo('tp_articles') || $comment['posterID'] == $context['user']['id']['is_logged'])


Best regards,
Fred
The Netherlands!

if you have debug enabled or check your error log you will find this causes errors.

Warning: Illegal string offset 'is_logged' in D:\wamp\www\clean5\Themes\default\TPsubs.template.php on line 1731

seems like a better fix is...

Code Select Expand

if(allowedTo('tp_articles') || $comment['posterID'] == $context['user']['id'] && !$context['user']['is_guest'])

[wildenborch]

Illori,

This change is indeed working perfectly!

Best regards,
Fred