Undefined index: Global_character_set error

[Skhilled]

After installing 5.2, I am getting the following 2 errors twice each when viewing the frontpage:

Code Select Expand

http://www.skhilled.com/docs/index.php?
8: Undefined index: global_character_set
File: /home/skhilled/public_html/docs/Sources/TPortal.php
Line: 1277

http://www.skhilled.com/docs/index.php?
8: Undefined index: global_character_set
File: /home/skhilled/public_html/docs/Sources/TPortal.php
Line: 1276

Guests are also generating these errors.

[IchBin]

What are your frontpage settings?

[Skhilled]

As shown in the images below:

[IchBin]

Open Sources/TPortal.php and goto line 1269. It should be right before this code:

Code Select Expand

while($row = tpdb_fetch_assoc($request))
            {
                // expand the vislaoptions
                $row['visual_options'] = explode(",", $row['options']);



Add this line before that code:

Code Select Expand

$context['character_set'] = empty($modSettings['global_character_set']) ? (empty($txt['lang_character_set']) ? 'ISO-8859-1' : $txt['lang_character_set']) : $modSettings['global_character_set'];


Then find this code just below that:

Code Select Expand

                $row['body'] = html_entity_decode($row['body'],ENT_QUOTES, $modSettings['global_character_set']);
                $row['intro'] = html_entity_decode($row['intro'],ENT_QUOTES, $modSettings['global_character_set']);


Replace with this:

Code Select Expand

                $row['body'] = html_entity_decode($row['body'],ENT_QUOTES, $context['character_set']);
                $row['intro'] = html_entity_decode($row['intro'],ENT_QUOTES, $context['character_set']);


I think that should fix it. This problem exists in the single page option as well. Bloc will need to add a fix for it. I'm not sure if this would be the proper way to fix it, but I think it does.

[Skhilled]

Thank you, sir. I'll give this a try.

[Ken.]

Thanks for the code IchBin. 
This same error has been showing up in the log for the FamilyForum... applying the code edits seemly makes no difference as the errors still happen, for guests and members as well.

Guest
http://www.ourfamilyforum.org/FamilyForum/index.php?
8: Undefined index: global_character_set
File: /home/kenkayjm/public_html/FamilyForum/Sources/TPortal.php
Line: 1325

Jake
8: Undefined index: global_character_set
File: /home/kenkayjm/public_html/FamilyForum/Sources/TPortal.php
Line: 1326

[IchBin]

What are your frontpage settings Ken? I mentioned this will happen with another setup because I didn't fix them all. I just wanted to test it for Skhilleds setup.

[Ken.]

Sorry, should have posted those.

[IchBin]

If you added the below line from my previous post, please remove it as I've put it in a better place now. On about line 1172 after the global line of the doTPFrontpage() function add this line:

Code Select Expand

$context['character_set'] = empty($modSettings['global_character_set']) ? (empty($txt['lang_character_set']) ? 'ISO-8859-1' : $txt['lang_character_set']) : $modSettings['global_character_set'];

On about line 1323 replace these lines:

Code Select Expand

                $row['body'] = html_entity_decode($row['body'],ENT_QUOTES, $modSettings['global_character_set']);
                $row['intro'] = html_entity_decode($row['intro'],ENT_QUOTES, $modSettings['global_character_set']);


With this:

Code Select Expand

                $row['body'] = html_entity_decode($row['body'],ENT_QUOTES, $context['character_set']);
                $row['intro'] = html_entity_decode($row['intro'],ENT_QUOTES, $context['character_set']);


Hopefully that will fix it. I really don't understand why global_character_set would be undefined, so I'm just taking a line out of SMF's code that seems to work for a few things. Let me know if that does the trick, if so maybe I'll add it to the repository.

[Ken.]

Thanks Brad.

Those changes kill the forum and throw this error page:

Parse error: syntax error, unexpected T_VARIABLE in /home/kenkayjm/public_html/FamilyForum/Sources/TPortal.php on line 1173

BTW... The 'replace' code was found on line 1323.