[bugtracker] Download Area: screenshots bug

[Dark-Wolf]

i see more error in error log (thanks to apache error handler mod) related to screenshots in download area:
-

Code Select Expand

Error 404 - Not Found (http://darkwolf.altervista.org/forum/tpmod/1235006467Theme_royal-noir-remixed.jpg)
File: user
-
Download area template search image in a bad url and not showing properly the screenshot:

-
This problem is caused by this code line in TPdlmanager.template.php:

Code Select Expand

' , !empty($last['screenshot']) ? '<div style="margin-right: 5px; background: url('.$last['screenshot'].') no-repeat; float: right; width: '.$context['TPortal']['dl_screenshotsize'][0].'px; height: '.$context['TPortal']['dl_screenshotsize'][1].'px;" class="windowbg3"></div>' : '' , '
i've applied a momentarily patch with this code bloc:

Code Select Expand

$count=1;
if(!empty($context['TPortal']['dl_last_added']))
{
 foreach($context['TPortal']['dl_last_added'] as $last)
 {
 $screenlink = $last['screenshot'];
 $findlink   = '/tp-images/dlmanager/thumb/';
 $pos = strpos($screenlink, $findlink);
 if ($pos === false) {
 $directoryth = ''.$boardurl.''.$findlink.'';
 } else {
 $directoryth = '';}
  echo '
   <div class="dl_last_added windowbg" style="overflow: hidden;">
    ' , !empty($last['screenshot']) ? '<div style="margin-right: 5px; background: url('.$directoryth.''.$last['screenshot'].') no-repeat; float: right; width: '.$context['TPortal']['dl_screenshotsize'][0].'px; height: '.$context['TPortal']['dl_screenshotsize'][1].'px;" class="windowbg3"></div>' : '' , '
    <div class="body" style="padding-left: 5px; margin-right: '. ($context['TPortal']['dl_screenshotsize'][0] + 15) .'px;">
     <h3><a href="'.$last['href'].'">'.$last['name'].'</a></h3>
     ' , !empty($last['text']) ? '<p class="middletext">'.$last['text'].'</p>' : '' , '
     <p class="smalltext dl_details"><img src="'.$settings['tp_images_url'].'/glyph_author.png" alt="*" /> '.$last['author'].'  <img src="'.$settings['tp_images_url'].'/glyph_down.png" alt="*" /> '.$last['downloads'].'  <img src="'.$settings['tp_images_url'].'/glyph_date.png" alt="*" /> '.$last['date'].'</p>
    </div>
   </div>';
 }
}Result here:
http://darkwolf.altervista.org/forum/tpmod/?dl=temi-windows-xp
Smf 1.1.9 (tested also with a clean installation and default theme) and tp 1beta4 (present also in beta3)
More info here:
http://www.tinyportal.net/index.php/topic,28401.msg237692.html#msg237692

[G6Cad]

Again Darkwolf, i have to ask you NOT to put anything in the bugtracker until we are sure it's bugs we are dealing with.

Also when posting in the bugtracker, we want you to use NOTHING but the DEFAULT smf Core theme as thats the theme TP is built on.

Errors like you posted there can (and are most likly ) theme issues.
So to be sure of things, please dont post bugs until we narrow them down in the support board first.
So when you see and have issues, please post them in the support board first, if we cant solve them there, we know where to send you. If it's a theme issue, the theme creator have to deal with them, if it's a TP bug, them Bloc or any one else here have to deal with that.

So no more bug reports with any thing else but defaults in the bugtracker and not until they have been tested by us in the support forum board.  :up:

[Dark-Wolf]

Sorry G6 but i've posted this bug from 1beta3 without great result and still present in beta4.
Now i've found a fix and i have posted here with all info.
IMHO is a good way to post a bug, if for you is a problem u can delete and in the next time i never report other bug.
In header of this site i see: Contribute; Report a bug.

Smf 1.1.9 (tested also with a clean installation and default theme) and tp 1beta4 (present also in beta3)

This i a bug and i've reported. That's all.
If u don't want maybe is best to remove permission in bugtracker.
Kind regards, DarkWolf.

[G6Cad]

We want our members to be able to post bugs in the bug tracker, but not until we are sure they really are bugs.

Thats why we like to have all issues regarding tp posted in the support forum so we can test and look at it there, IF it then show as a bug, we ask our members to post in the bug tracker.

You do great with your posting, but it would be better if you started in the support board for us to test diffrent things before we send it to the bug tracker.

Also errors and bugs have to be tested with the default Core theme as TP is built for that theme in first hand.
Themes as we all know of generate errors and some times ( quite often even ) they are the cause of errors all over and not tp it'self.

[Dark-Wolf]

Have you see here (February 19, 2009, 01:48):
http://www.tinyportal.net/index.php/topic,28401.msg226228.html#msg226228
Now is 1 June (4 months ago) and only answer from IchBin

No idea how to fix. You need to go through the manual install and make sure all things have been done if your editor is not working. If that doesn't work, check your theme and any other mods you may have installed and make sure there is no conflict by removing any custom code etc.

The thumb image, yes I see that it is not displaying. I'll test that on my install and make sure.

After 4 months i've reported again:
http://www.tinyportal.net/index.php/topic,28401.msg237692.html#msg237692 and now (after a fix) i've reported here.
If i don't report here is probably this bug still remain also for next release.
Report here, after 4 months, and another release IMHO is necessary.
-
And, repeat, first to report a bug i test all in local with wamp
Clean installation, never one mod (except tinyportal), English-Default language, Default theme.

[G6Cad]

Yes, 4months old and because you are the only one with that error.

So thats the very reason I ask you to post in the support board and not in the bugtracker as you still use non defaults for both theme, and language on your forum.
From another older screenshot i saw before i also noticed you have other mods installed to.

So please post your issues in the support and we go from there.
A bug in a script is when several people including us that test this have the same issues as you. When you ALONE have one issue that noone can duplicate for over 10k sites, it's hard to say it's a bug in TP, it's more of an error in your own install, theme, langauge, other mod etc etc.

[Dark-Wolf]

G6: no other people can see this error maybe because it don't use apache error handle mod.
With apache error handle you can see all apache error (like this 404).
I've already test in local without any mod and only tp + smf.
This error don't show in error log (without apache mod) but screenshot isn't visible in download area (in output html code you can see error).
This screenshot is in css for this reason you can't see classic red-X for image.
No many people can see an invisible (but existent) bug.
For me isn't a problem, i can use my fix.
If u want maintain this "hidden bug" in next release for me is ok.
-
I've reported to share with other member and because i want contribute with tp not to discuss like children.

[Dark-Wolf]

Forum and (only) tinyportal reinstalled 5minut ago:
Upload two files with two screenshots:

bugmenot debug:

With my fix:

bugmenot debug after fix:

-
I hope that now you don't have more others doubt :|

[G6Cad]

Yes i have doubts as you seem to be the only one with this error

[Dark-Wolf]

Yes i have doubts as you seem to be the only one with this error

Oh my god 
Fresh installation; no mods; no language (only default english); many unequivocal screenshots; bugmenot debug; code fix; and you continue to have doubts? 
-
Ok G6, is not a bug!  :down:
If only one person found a bug IS NOT A BUG.
U can close this bugreport, my mistake