errors validating XHTML

[snoopy_virtual]

Hi everybody.

It's the first time I'm installing TinyPortal.

For years I've been working with SMF and Joomla together in all the sites I design (got 20 more or less now) but since last July, when Joomla changed to version 1.0.13 the bridge between both of them is not working anymore, so I've been looking around to keep SMF in all my pages and change the CMS instead.

I knew TinyPortal before, but I didn't try it yet until now.

So, for a start, CONGRATULATIONS Bloc (and the rest of the team). Your work is superb.

I think you will see me here a lot of times, because if I don't find a good solution with the bridge between SMF and Joomla I think I'm going to change all my old sites to TinyPortal. And anyway I think from now on that's the program I'm going to use with all my new sites.



The first thing I'm doing is to translate it properly into Spanish, as I've seen that the Spanish packages you have in your download section are not fully translated and they have a lot of misspellings.

I will send you the files when I have them finished and maybe another day we can talk also about opening a Spanish child-board in the languages section, but that's not the reason why I started this post:

Working with the languages files I've found a small error that doesn't validate with the w3c:

In the file TPortalAdmin.english.php, lines 379 to 382 (I'm talking of course of version 0.9.8 the latest) you open 4 paragraphs <p> and don't close them </p>.

Search for:

Code Select Expand


<p><b>TP Interface</b><br />Xarcell.
<p><b>TP Server</b><br />Ray.
<p><b>TP Press</b><br />PhilH, Maya.
<p><b>TP SMF</b><br />eldacar.


Replace with:

Code Select Expand


<p><b>TP Interface</b><br />Xarcell.</p>
<p><b>TP Server</b><br />Ray.</p>
<p><b>TP Press</b><br />PhilH, Maya.</p>
<p><b>TP SMF</b><br />eldacar.</p>


I know there must be a few more mistakes somewhere, as the site I'm doing just now was valid XHTML before I installed TinyPortal and now it's not.

I will send more bugs when I find them.

Cheers (and by the way happy new year!)

[G6Cad]

Welcome to tinyportal
I just wanted to point out before you do a whole lot of work on the validation part, that TP is Beta software, it's in constant development and Bloc have said many times that errors are there, and validation of TP will not be precent before TP V1* so for short, dont spend to much time in finding errors in TP V098 cause a new version will be released pretty soon with pretty much a lot of rewrites of the TP code and language strings.
(No timeframe given on when though) 

[snoopy_virtual]

OK, I will stop then looking for more errors and I will wait for a stable release.

Anyway, before I read your message, I have already started looking for them and I found a few more so, if you don't mind, I will point them out here, just in case somebody have missed them and they are not already corrected in the new version:



In the file TPortal.tmplate.php you open a <div> tag in line 181 and you open another one in line 188.

But when you are supposed to close these 2 tags in line 243, you only close one of them.

So, you should search for:

Code Select Expand


echo '
      </div>
</td>';
$context['TPortal']['bothcols']=false;


And replace it with:

Code Select Expand


echo '
      </div></div>
</td>';
$context['TPortal']['bothcols']=false;




Anyway, in this same file there is something else I don't understand:

In line 181 you write:

Code Select Expand


// render the text
echo '<div style="_height: 1%; overflow: auto;">';


Could somebody tell me why is there an underscore before the height?

Is it a mistake or is it there for a reason that I can't see?



In the file TPortalBlocks.template.php there are 6 <input> tags not closed properly.

I'm not going to give you the exact places because, as you said, maybe they are already corrected in the new version, but anyway you should look for any:

Code Select Expand


<input "whatever_else_is_here">


And replace it with:

Code Select Expand


<input "whatever_else_is_here" />

to close them properly. As I said it happens 6 times in this file.



In the file TPmodules.template.php there are again a few more <input> tags not closed properly, but in this file it happens 62 times.



In this same file TPmodules.template.php there is another error that happens 35 times:

In some of the <input> tags, the ones that are type="radio", you have the word checked in them.

That was ok in HTML transitional, but it's not correct in XHTML. You can't just write a word inside a tag, you must write everything as pairs of Attributes and Values, so you must search for every:

Code Select Expand


<input type="radio" "whatever_else_is_here" checked>


And replace it with:

Code Select Expand


<input type="radio" "whatever_else_is_here" checked="checked" />

As I said it happens 35 times in this file.



I have found another error that has nothing to do with validation. It's about translation, but I don't think I should open a new thread just for that.

As I said before, maybe it's already corrected in the new version, but I'm going to put it here anyway just in case:

In the file TPdladmin.template.php you need to search for:

Code Select Expand


title="delete"


Replace it with:

Code Select Expand


title="'.$txt['tp-delete'].'"


So it can be translated. It happens twice in this file.



That's all I've found so far.

Good thing you told me to stop looking for errors, or I would have continued like that for a few weeks. 

Anyway, if somebody can tell me where can I download the files for the new version as you have them just now (or if somebody can send them to me by email) I wouldn't mind to check them to help with the work, so we may have the new stable version ready as soon as possible.

And I could also start with the translation to Spanish at the same time so it's ready too.

Cheers.