News: When asking for support, it helps us and you, if you read the Posting Guidelines

Login  |  Register
HTML5 Icon HTML5 Icon
TP on Social Media
Welcome, Guest. Please login or register.
Did you miss your activation email?

July 17, 2019, 10:50:18 PM

Login with username, password and session length

Recent

Members
Stats
  • Total Posts: 188520
  • Total Topics: 20737
  • Online Today: 266
  • Online Ever: 629
  • (November 08, 2018, 01:36:54 PM)
Users Online
Users: 0
Guests: 18
Total: 18

Author Topic: Duplicate shouts  (Read 779 times)

0 Members and 1 Guest are viewing this topic.

Offline lurkalot

  • Administrator
  • *
  • Posts: 6074
    • Camera Craniums
Re: Duplicate shouts
« Reply #10 on: June 24, 2019, 02:25:35 PM »
I’m guessing Chrome has changed how it handles enter for submit boxes. Does it occur in other browsers?

Tino, does it in IE, Edge, Firefox, and Chrome for me.

Offline tino

  • Developer
  • *
  • Posts: 1573
Re: Duplicate shouts
« Reply #11 on: June 24, 2019, 03:50:50 PM »
Ok, I’ll look at it later this week if I can.

Offline tino

  • Developer
  • *
  • Posts: 1573
Re: Duplicate shouts
« Reply #12 on: June 30, 2019, 04:52:37 AM »
I can't recreate this bug, is it SMF 2.1 RC2 or the latest GitHub copy?

Offline lurkalot

  • Administrator
  • *
  • Posts: 6074
    • Camera Craniums
Re: Duplicate shouts
« Reply #13 on: June 30, 2019, 05:00:22 AM »
I can't recreate this bug, is it SMF 2.1 RC2 or the latest GitHub copy?

My test site is running 2.1 RC2, don't think I've upgraded since.  It does it there.

It'll only duplicate the shouts if you enable the submit using enter key.  And turning that setting off you don't get the duplicate shouts, but you can still submit by pressing the enter key. It's almost like something's doubled up in the settings somewhere.

Offline tino

  • Developer
  • *
  • Posts: 1573
Re: Duplicate shouts
« Reply #14 on: June 30, 2019, 05:02:13 AM »
I tried that on SMF 2.1 RC2 and TinyPortal 1.6.3 and 1.6.4 with shout on enter key enabled and disabled. No issues.

Quote
Google Chrome is up to date
Version 75.0.3770.100 (Official Build) (64-bit)

Firefox Quantum
67.0.4 (64-bit)


Offline tino

  • Developer
  • *
  • Posts: 1573
Re: Duplicate shouts
« Reply #15 on: June 30, 2019, 06:09:59 AM »
I just upgraded to the latest GitHub version of SMF 2.1 and downloaded 1.6.3 from the SMF website again and installed those and have no issue here with all the settings they work as they should for me.

Offline lurkalot

  • Administrator
  • *
  • Posts: 6074
    • Camera Craniums
Re: Duplicate shouts
« Reply #16 on: June 30, 2019, 06:17:14 AM »
I just upgraded to the latest GitHub version of SMF 2.1 and downloaded 1.6.3 from the SMF website again and installed those and have no issue here with all the settings they work as they should for me.

Thanks.  Must be the official RC2 then.  I was waiting for RC3 before upgrading my live test site again. Not sure what version @rjen is running, but he said he could see the problem, so I'm assuming that's three of us so far that have experienced it.

mmm I see the problem: I have never really tested this setting. Has it even been functional?  If so, do you recall what version of TP it was in?

It seems to be a Javascript function in Tpshout.php.

I do not have experience with Javascript, so not sure why it is not working anymore, but I think we had some javascript related issues some time ago?

Offline @rjen

  • Support Team
  • *
  • Posts: 1695
    • FJR-club Nederland
Re: Duplicate shouts
« Reply #17 on: June 30, 2019, 07:03:14 AM »
I see the issue both in 2.0.15 an 2.1.
Running TP1.6.3 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6074
    • Camera Craniums
Re: Duplicate shouts
« Reply #18 on: June 30, 2019, 08:07:40 AM »
I see the issue both in 2.0.15 an 2.1.

Strange.  So you get the same thing here on this site? It doesn't do it here for me. Or at least it didn't. Let me try it again.

Edit:  Nope works fine for me here.

Offline @rjen

  • Support Team
  • *
  • Posts: 1695
    • FJR-club Nederland
Re: Duplicate shouts
« Reply #19 on: July 02, 2019, 03:02:27 AM »
Yep works fine here, but not on my 2.0.15 sites...

Maybe something to do with other mods...?
Running TP1.6.3 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info