Problem w/ Global Mods not being able to edit articles

[illori]

did anyone look at the file i attached? the perm for "news" is still being used where it was removed from the list of perms to assign so it fails when submitting articles, look at the source and you will see it.

also i have done this test with a clean install of smf 1.1.6 and a NEW install of tp 1.0.6 beta 2, there was not site before this, and i have worked with tinyportal and smf before so i know i did not make this  error up.
[edit]

maybe it might help to show a diff of the change made that fixes this to prove it.

Code Select Expand


--- /Sources/TPortalAdmin.php  2008-10-11 19:48:36.000000000 -0400                                               
+++ /Sources/TPortalAdmin.php      2008-10-23 17:20:35.000000000 -0400                                               
@@ -131,7 +131,7 @@                                                     
        // check permissions                                             
        if($tpsub == 'news')                                             
        {                                                               
-                       isAllowedTo('tp_news');                         
+//                     isAllowedTo('tp_news');                         
        }                                                               
        elseif(in_array($tpsub, array('settings','frontpage','panels','modules','credits','portal','subscriptiongroups')))                       
        {
@@ -2798,8 +2798,7 @@
                        'description' => $txt['tp-adminnews3'],
                        'tabs' => array(),
                        );
-               if (allowedTo('tp_news'))
-               {
+
                        $context['admin_tabs']['tabs'] = array(
                                'news' => array(
                                'title' => $txt['tp-adminnews1'],
@@ -2814,7 +2813,6 @@
                                        'is_selected' => $tpsub == 'credits',
                                ),
                        );
-               }
        }
        elseif(in_array($tpsub, array('settings','frontpage')))
        {



[espressoguy]

did anyone look at the file i attached? the perm for "news" is still being used where it was removed from the list of perms to assign so it fails when submitting articles, look at the source and you will see it.

also i have done this test with a clean install of smf 1.1.6 and a NEW install of tp 1.0.6 beta 2, there was not site before this, and i have worked with tinyportal and smf before so i know i did not make this  error up.
[edit]

Caarie,  are you saying that this is a fix for the bug?  It was not clear to me from either post the original post that you were presenting this as a fix for the bug. 

[espressoguy]

did anyone look at the file i attached? ....
maybe it might help to show a diff of the change made that fixes this to prove it.

Carrie, your post is completely unclear to me.  Ichbin says that the bug existed in 1.0.5 and is fixed in 1.0.6.   The code you are showing in your fix doesn't even exist in TPortalAdmin.php v1.0.5 and your post seems to be talking as if the bug still exists in 1.0.6.     You'll have to make your meaning more clear. 

[illori]

the file/fix is for the new beta 1.06 beta2 and yes the lines are there, and no according to my tests Ichbin is wrong this is not fixed, the perm was removed as something to assign, and yet it was left in the admin file therefor keeping people from using the feature correctly.

this patch is for the new beta 1.06

[espressoguy]

Yes,  I have run many tests and I also am seeing that Caarrie is correct; the bug is still there regardless of whether you install the 1.1.6 fresh on a pristine SMF 1.1.5 or as an upgrade from TP 1.0.5.  Either way when a Global Mod attempts to save the new edits the error comes up and the save does not work.   Also, there is a problem with FCK editor; it doesn't come up when attempting to edit an html page. 

UPDATE: I've just submitted a bug report on this problem of Global Moderator (and everyone except Admin) being unable to edit an article.  Regarding the related problem with FCK editor, see this thread:
http://www.tinyportal.net/index.php/topic,26564.msg213515.html#msg213515

[sturmkatze]

I dunno. I think it was a permission problem as it's gone now. However, I am not about to change to 1.06 or whatever as it doesn't have the block w/ 1 article... I use that a lot.

[IchBin]

You should be able to use a center/upper block with articles, just not a frontpage article.

[sturmkatze]

I use it for stuff like menus. Maybe I'm doing it wrong, but I want more control. BTW, in the blocks, can I control the bg colors and text/link colors for individual links. (Sorry for asking here, doing 6 things at once and have no time)