Beta 3 Shoutbox has gone whacko!

[ZarPrime]

I'll install on a test site today and check it out.  If it doesn't work on mine, then we'll put it in the bugtracker.

ZarPrime

[G6Cad]

Im for one cant duplicate this on any of my sites

I ould suggest to uninstall the module and then reinstall it again, especially if the install are from an upgrade.

[ZarPrime]

G6, we both already did that.  No change.  For me, only IE7 doesn't show the shouts.  FF works fine.

ZarPrime

[Bluto]

So, if unistalling the mod or TP doesn't work. what's next?
My installation was an upgrade.
I could load the large upgrade package and install a fresh version of TP, then reapply my mods.
Other than that, I'm stuck with out a scrolling shoutbox....again.   

[Bluto]

Here's the only clue I have. In IE with the scrolling turned off, I get no little yellow triangle warnings down in the left corner. When I have scrolling on, I get this:

Code Select Expand

Line: 519
Char: 3
Error: Expected indentifier, string or number
Code: 0

The line number will vary between 519, 530 something and line 540, which are:

Code Select Expand

for (var i = 0; i < codeFix.length; i++)
{
if (codeFix[i].className == "code" && (codeFix[i].scrollWidth > codeFix[i].clientWidth || codeFix[i].clientWidth == 0))
codeFix[i].style.overflow = "scroll";
}
}';
else
{
echo '
var window_oldOnload = window.onload;
window.onload = smf_codeFix;

function smf_codeFix()
{
var codeFix = document.getElementsByTagName ? document.getElementsByTagName("div") : document.all.tags("div");

for (var i = codeFix.length - 1; i > 0; i--)
{
if (codeFix[i].currentStyle.overflow == "auto" && (codeFix[i].currentStyle.height == "" || codeFix[i].currentStyle.height == "auto") && (codeFix[i].scrollWidth > codeFix[i].clientWidth || codeFix[i].clientWidth == 0) && (codeFix[i].offsetHeight != 0 || codeFix[i].className == "code"))
codeFix[i].style.height = (codeFix[i].offsetHeight + 36) + "px";
}


Have no idea if that helps, but it seems to point in the right code area.
I also noticed a Java update yesterday, but that didn't change anything either.

[ZarPrime]

Bluto,

OK, I have split out the posts in this topic on Marian's issues to clean up this topic.

I would like you to place this issue into the Bugtracker.  Please be as specific as possible about the behavior, and be prepared to turn scrolling back on in the Shoutbox on your site in case Bloc wants to see the behavior in IE himself.  When you put this in the Bugtracker be sure to mention that this only happens when viewing your site in IE, and be sure to reference this topic when you submit the bug.  When reporting the bug, rather than titling it Shoutbox is Whacko, or something like that, title it something like "Scrolling in Shoutbox not working in IE".

ZarPrime

[Bluto]

Will do. Thanks for the help.   

[bloc]

This is now fixed. its very small error, something IE complains about, but firefox do not.

Open tp-files/tp-modules/TPShout/Sources/TPShout.php and find:

Code Select Expand

transition: Fx.Transitions.' . $context['TPortal']['shoutbox_scrolleasing'] . '.easeInOut,
}
var scroller = new QScroller(\'allshouts\',opt);


Remove the single comma after "easeInOut" and it should work.

[Bluto]

Yep, that works, thanks.