New Help system in RC2 and TP 0.75

[feline]

I'm testing with sms 1.1 rc2 and TP 0.75 ...

Click on HELP ..ok
Click on help subtopic ...

Datenbankfehler
Unbekanntes Tabellenfeld 'loginout' in where clause
Datei: c:\myprogramm\hp\easyphp1-8\www\smforum\Sources\TPortal.php
Zeile: 280

i look at this .. and have added on statement:

edit later:

Code Select Expand


// check if the blocks are hidden in  forum. Setting of hide whole bar overrides.
if(!in_array($context['TPortal']['action'], array('tportal','tpadmin','tpmod',''))){
if($context['TPortal']['hide_leftbar_forum']==1)
   $context['TPortal']['leftbar']=0;
if($context['TPortal']['hide_rightbar_forum']==1)
   $context['TPortal']['rightbar']=0;
if($context['TPortal']['hide_centerbar_forum']==1)
   $context['TPortal']['centerbar']=0;

// No TP on Help
if ($context['TPortal']['action'] == 'help')
{
   $context['TPortal']['leftbar']=0;
   $context['TPortal']['rightbar']=0;
   $context['TPortal']['centerbar']=0;
}
}


Code Select Expand


// skip news if frontblock is chosen and articles or categories are not set

// exit TP on Help
if ($context['TPortal']['action'] == 'help') return;

   if($context['TPortal']['front_type']!='frontblock' || ($context['TPortal']['front_type']=='frontblock' && ($mypage!='' || $mycat!='')))


works fine 

Fel

[borgBOB]

Nice code. 

[feline]

Nice code. 

yeah .. give me a better  :coolsmiley:

Fel

[bloc]

ehem. well, perhaps not better..but I have already corrected the error for 0.8: it was the query "page=xx" used in Help that clashed with "page=xx" used in TP. So I just checked that we are in Help, and then disregarded any "page" for TP there. Blocks and other things works as normal.

TPortal.php..from :

Code Select Expand

// view single article?
$mypage='';
if(isset($_GET['page'])){
$mypage=$_GET['page'];
// cancel out any category - if any


to :

Code Select Expand

// view single article? but not when in Help ;)
$mypage='';
if(isset($_GET['page'])){
$mypage=$_GET['page'];

// not in help screen though
if(isset($_GET['action']) && $_GET['action']=='help')
$mypage='';

// cancel out any category - if any


[feline]

great Bloc .. it's better 

But .. I think, it's a good idea, to hide left/right/center blocks on help ..
I have run the help system inside the forum, not in a new browser.
It's configurable by me ..
I'm add in the theme index template:

Code Select Expand


/* Set the HELP display
for RC2, help can displayed inside the forum theme. Do so, set this to '';
for RC1, help needs a new browser, must set to 'target="_blank"'; */
// $settings['help_display'] = 'target="_blank"'; // use RC1
$settings['help_display'] = ''; // use RC2


and later:

Code Select Expand


        <link rel="help" href="', $scripturl, '?action=help "', $settings['help_display'], '>


and same at the help button ...

same theme for rc1 / rc2 ... works fine 

Fel