TP-Docs
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

Welcome to TinyPortal. Please login or sign up.

May 18, 2024, 02:04:52 AM

Login with username, password and session length
Members
  • Total Members: 3,886
  • Latest: Grendor
Stats
  • Total Posts: 195,189
  • Total Topics: 21,220
  • Online today: 71
  • Online ever: 3,540 (September 03, 2022, 01:38:54 AM)
Users Online
  • Users: 0
  • Guests: 107
  • Total: 107

Recently migrated to TP

Started by MrMike, September 09, 2023, 09:21:49 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

tino

Quote from: MrMike on November 22, 2023, 05:39:36 PM
Quote from: @rjen on November 15, 2023, 02:07:22 PMThe original requester does not seem to need it that much, since he has not replied even though he has been online after I posted...

Sorry, I've been in and out, some minor medical issues and stuff like that. I thought it would be a handy addition, but in retrospect, probably not worth a lot of coding or work.

I was more concerned about the title truncating issue; will there be a fix or update for that at some point?



I'll try and look at the truncating issue, is there an error in the log? It's not properly escaping the string somewhere...

@rjen

I reproduced the issue on my forum: there are no errors, not in the SMF log, nor in the server log...

Just noticed that when quotes are included in the 'short description' the display of the Category is completely broken...
I assume the URL becomes invalid...


So it seems that name as well as short name needs to be sanitized...

You cannot view this attachment.

You cannot view this attachment.
Running Latest TP on SMF2.1 at: www.fjr-club.nl

tino


@rjen

Quote from: tino on December 12, 2023, 01:47:29 PM%27 is ' I think.
I think so too, but as a result the URL does not bring me to the correct downloads category page...
Running Latest TP on SMF2.1 at: www.fjr-club.nl

@rjen

Just tested and found that the same happens with articles: using quotes in the short name also breaks the links to the page...

You cannot view this attachment.
Running Latest TP on SMF2.1 at: www.fjr-club.nl

tino


@rjen

Don't know: can it be SQL or php related?

I am on php 8.0.13
Running Latest TP on SMF2.1 at: www.fjr-club.nl

tino

Quote from: @rjen on December 12, 2023, 08:51:13 PMDon't know: can it be SQL or php related?

I am on php 8.0.13

Should'nt be, there is a issue with the title edit section shortening it.

I can also recreate the shortname issue, so working those through.

@rjen

Yep. I saw we have a rudimentary function stripping spaces from the article short name, but nothin on categories and downloads.

I think the shortname should never allow for special characters
Running Latest TP on SMF2.1 at: www.fjr-club.nl

tino

Quote from: @rjen on December 12, 2023, 09:11:51 PMI think the shortname should never allow for special characters

That's the easier solution, so you want them stripped?