[bugtracker] SMF 1.1.5 & TP 1.05beta1 Quote insertion error !!!

[kocaturk]

Hello, I have use SMF 1.1.5 and TP 1.05 beta 1, TP is the best Portal software for SMF but I think so bugs in this TP version.TP 1.05  has modified QueryString.php in the SMF sources directory. This modification below.

<edit file>
$sourcedir/QueryString.php
</edit file>

<search for>
  // Let's do something special for session ids!
  if (defined('SID') && SID != '')
   $buffer = preg_replace('/"' . preg_quote($scripturl, '/') . '\?(?:' . SID . ';)((?:board|topic)=[^#"]+?)(#[^"]*?)?"/e', "'\"' . \$scripturl . '/' . strtr('\$1', '&;=', '//,') . '.html?' . SID . '\$2\"'", $buffer);
  else
   $buffer = preg_replace('/"' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?"/e', "'\"' . \$scripturl . '/' . strtr('\$1', '&;=', '//,') . '.html\$2\"'", $buffer);
</search for>

<replace>
  // Let's do something special for session ids!
  if (defined('SID') && SID != '')
   $buffer = preg_replace('/"' . preg_quote($scripturl, '/') . '\?(?:' . SID . ';)((?:board|topic|page|cat|action)=[^#"]+?)(#[^"]*?)?"/e', "'\"' . \$scripturl . '/' . strtr('\$1', '&;=', '//,') . '.html?' . SID . '\$2\"'", $buffer);
  else
   $buffer = preg_replace('/"' . preg_quote($scripturl, '/') . '\?((?:board|topic|page|cat|action)=[^#"]+?)(#[^"]*?)?"/e', "'\"' . \$scripturl . '/' . strtr('\$1', '&;=', '//,') . '.html\$2\"'", $buffer);

</replace>


after this modofication, SMF forum  get an error. when users reply any topic and  click insert quote link for inserting for any older replies to new replies, Browser return error and quote not insertion ( IE7, Firefox 3, Opera 9.5)

The retured error is;

Line : 699
Char: 22
Error:Object Needed
Url :http://www.xxxxxxx.net/index.php/action,post/topic,4343.0/num_replies,0.html

the code of page source at the 699 line;

696->    function onDocReceived(XMLDoc)
697->    {
698->     var text = "";
699->     for (var i = 0; i < XMLDoc.getElementsByTagName("quote")[0].childNodes.length; i++)
  &nb

[bloc]

Fixed for 1.0.5 beta 2.

It was the parameter "action" added that led to this error. Until a more satisfactory solution for SEF urls in SMF are added, I removed that keyword, only keeping page|cat words.

[mc]

I've just had this problem with TP1.0.5 beta4, and removing action from the QueryString.php modifications has cured it.
I've had the bug since switching from TP0.9.8, to TP1.0.5 beta3, but just got round to sorting it.

Not sure if this applies to installs via the package manager, as I done a manual install using the instructions in the Docs section?


(editted to correct TP versions)