Possible escape issue in searches

[tino]

Let's just use built in PHP functions... that'll hopefully point where the issue lies.

Code Select Expand

$mysqli = mysqli_init();
$what = mysqli_real_escape_string($mysqli, $what);


[@rjen]

Put it in the second spot: still no change

Code Select Expand

$what = implode(' ',$words);
$mysqli = mysqli_init();
$what = mysqli_real_escape_string($mysqli, $what);
}
Put it in the first spot: HTTP ERROR 500

[tino]

Can you please test this PR https://github.com/Tinyportal/TinyPortal/pull/977/commits

It should fix the issue

[@rjen]

Just did  aquick test, and it works: searching does no longer results in errors, and the ' symbols are included in the search string.

putting 'test' in an article text and 'test' in another

Search for the string test results in hits on the string test without quotes only
Search for the string 'test' results in hits on the string 'test' with quotes only

I assume this is how we want this to work?

Asking this because it reacts slightly differently when putting it in the article TITLE...

putting 'test' in an article title

Search for the string test results in hits on both the strings: test without quotes and the 'test' with quotes
Search for the string 'test' results in hits on the string 'test' with quotes only

[tino]

It should be a wildcard search so test or 'test' will be returned.

That does depend on your character encoding and database. Not much we can do to change those