Login  |  Register
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

Welcome, Guest. Please login or register.
Did you miss your activation email?

December 07, 2021, 06:23:03 PM

Login with username, password and session length
Members
  • Total Members: 3831
  • Latest: pulgoki
Stats
  • Total Posts: 192615
  • Total Topics: 21020
  • Online Today: 113
  • Online Ever: 1035
  • (November 26, 2020, 04:45:12 AM)
Users Online
Users: 0
Guests: 107
Total: 107

Author Topic: Elkarte TinyPortal Testing  (Read 10967 times)

0 Members and 1 Guest are viewing this topic.

Offline tino

  • Developer
  • *
  • Posts: 2396
Elkarte TinyPortal Testing
« on: January 05, 2021, 06:55:34 AM »
Hi All,

The latest copy of TinyPortal for Elkarte is available here;

https://tinoest.co.uk/forum/index.php?page=ElkTinyPortal

I would appreciate it if some of you can test it, obviously if you're using SMF and have no wish to change then it isn't for you.

Can you raise any issues you find in this topic, or on Github and I shall work through them all. 

tino
« Last Edit: January 06, 2021, 05:37:21 PM by tino »

Offline Oldiesmann

  • Jr. Member
  • **
  • Posts: 44
    • Cincy Space
Re: Elkarte TinyPortal Testing
« Reply #1 on: January 24, 2021, 02:29:03 PM »
I've still got an ElkArte test site... I'll put TP on it later and play with it some :)

Offline lurkalot

  • Administrator
  • *
  • Posts: 7334
    • Camera Craniums
Re: Elkarte TinyPortal Testing
« Reply #2 on: January 24, 2021, 04:01:48 PM »
Hi Oldies, not sure what versions of Elkarte it's compatible with, tino did say at some point. I'm sure he'll let us know if that's an issue.

Offline tino

  • Developer
  • *
  • Posts: 2396
Re: Elkarte TinyPortal Testing
« Reply #3 on: January 24, 2021, 05:15:24 PM »
It’s compatible with Elkarte 1.1.x, I’m currently working on a new branch compatible with 2.0.x

Offline @rjen

  • Support Team
  • *
  • Posts: 2972
    • FJR-club Nederland
Re: Elkarte TinyPortal Testing
« Reply #4 on: January 30, 2021, 12:52:47 AM »
Finally got around to installing TinyPortal for Elkarte.

- First thing I noticed are the text formatting issues in de admin area: setting captions are printed in Bold, due to the font-weight: 600; in the css for .settings label. I personally find that a bit invasive...

See that some entries are not in bold, because I did not 'label' all fields...
Hmm, might be something I will pick up in SMF to prevent similar issues with SMF themes. Not a big issues, just does not look good...

- Second thing I noticed is that the tooltips don't work...

- Block styles definately need cleaning up: the block styles that made some sort of sense in SMF now all look the same in the Elkarte theme

- Check the style in tp-style.css

dl.tptitle dt {
    float: left;
    width: 40%;

The 40% should be changed to 39%: the Elkarte theme does not like this. See the "Edit Article" Title and Short name section what I mean...

(I'll update this in SMF too, maybe some SMF themes will do the same...)

- I cannot create a new Article Category from the list page.

Results in error: "The database value you're trying to insert does not exist: item_type"

- Trying to upload an article icon results in error: Call to undefined function fatal_error()

In general I noticed that the Elkarte theme indicates some layout errors in the TinyPortal templates, that SMF 2.0 and 2.1 did not show.  :doh:
« Last Edit: January 30, 2021, 01:48:41 AM by @rjen »
Running TP2.1.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline tino

  • Developer
  • *
  • Posts: 2396
Re: Elkarte TinyPortal Testing
« Reply #5 on: January 30, 2021, 03:16:10 AM »
Thanks for testing, I’ll look at those errors.

The block templates is on my list of things to fix, I made a stab at in the development branch. I think also the category error is fixed in that one.

I don’t mind the bold on the labels, I was going to move them all across to that. I’ll add a subclass so they can be styled though.

Thanks again for testing.

Offline @rjen

  • Support Team
  • *
  • Posts: 2972
    • FJR-club Nederland
Re: Elkarte TinyPortal Testing
« Reply #6 on: January 30, 2021, 04:05:09 AM »
No problem, if you don't mind I can submits some of the layout stuff to your development branch...

It would be nice to keep SMF and Elk branch a little bit in sync, even though with all your changes to the Elk version there is not a lot of synergy left...

Mind you: if youhave fixes / improvements that we can leverage in the SMF version (like for example the block layouts) please let me know ...
Running TP2.1.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline tino

  • Developer
  • *
  • Posts: 2396
Re: Elkarte TinyPortal Testing
« Reply #7 on: January 30, 2021, 05:38:35 AM »
No problem, if you don't mind I can submits some of the layout stuff to your development branch...

It would be nice to keep SMF and Elk branch a little bit in sync, even though with all your changes to the Elk version there is not a lot of synergy left...

Mind you: if youhave fixes / improvements that we can leverage in the SMF version (like for example the block layouts) please let me know ...

You’re more than welcome to contribute against it. Styling isn’t my thing. I’ve only got the article logic to change then, I’ll be adding the downloads, menu and gallery sections.

It’s mostly the same, just moved around a fair bit. If I’m honest it’ll also work ok SMF with minor changes for the styles. It’s I feel cleaner on the ones I have moved across, but that might be as I know the code in more detail now.

Offline @rjen

  • Support Team
  • *
  • Posts: 2972
    • FJR-club Nederland
Re: Elkarte TinyPortal Testing
« Reply #8 on: January 30, 2021, 05:40:36 AM »
Gallery sections?
Running TP2.1.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline tino

  • Developer
  • *
  • Posts: 2396
Re: Elkarte TinyPortal Testing
« Reply #9 on: January 30, 2021, 06:05:21 AM »
Gallery sections?

Yeh, I’ll merge what I did for YAPortal into TinyPortal and tidy up the display side. It’ll also take the download logic from there largely with the front section taking bits from TinyPortal.