Login  |  Register
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

Welcome, Guest. Please login or register.
Did you miss your activation email?

October 24, 2020, 08:06:18 PM

Login with username, password and session length
Members
Stats
  • Total Posts: 191351
  • Total Topics: 20907
  • Online Today: 90
  • Online Ever: 1000
  • (October 07, 2020, 04:15:10 PM)
Users Online
Users: 0
Guests: 76
Total: 76

Author Topic: Examples / tips for improvement of articles + icons layout  (Read 758 times)

0 Members and 1 Guest are viewing this topic.

Offline @rjen

  • Support Team
  • *
  • Posts: 2602
    • FJR-club Nederland
Re: Examples / tips for improvement of articles + icons layout
« Reply #10 on: September 06, 2020, 01:34:53 PM »
I created the commits for the changes, but they are now part of the PR that is awaiting review from tino.

As soon as that is done I will merge them in (I hope)
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline tino

  • Developer
  • *
  • Posts: 2090
Re: Examples / tips for improvement of articles + icons layout
« Reply #11 on: September 06, 2020, 02:34:44 PM »
I put a couple of comments on the pr yesterday. I think what you’ve done is the best way. I would prefer the get attachment to be it’s own function as we can call it elsewhere from other functions, but I can change that later.

Offline @rjen

  • Support Team
  • *
  • Posts: 2602
    • FJR-club Nederland
Re: Examples / tips for improvement of articles + icons layout
« Reply #12 on: September 06, 2020, 02:41:00 PM »
Where did you put those comments? I am not seeing them in github. But if it is ok with you I’ll merge the PR.

Need to do more changes on the layouts : articles and avatars seems funny too...
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline @rjen

  • Support Team
  • *
  • Posts: 2602
    • FJR-club Nederland
Re: Examples / tips for improvement of articles + icons layout
« Reply #13 on: September 08, 2020, 01:27:20 AM »
As for the article icons.

1. I noticed that the upload limit is hard-coded to 180Kb (even though the text says it is 500Kb).
2. When uploading an image it creates a thumbnail of 128 x 128 (a value we are not using anywhere)
3. The original image is stored in the folder too, but not used anywhere

I am thinking to
1. add a setting to the article settings to allow the admin to set it's own file size
2. add a setting for the icon thumbnail
3. See if we can delete the original images since all they do is take up space...
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline jernatety

  • Sr. Member
  • ****
  • Posts: 340
Re: Examples / tips for improvement of articles + icons layout
« Reply #14 on: September 11, 2020, 01:07:57 PM »
For now I have settled for the attached... hopefully some more suggestions come along

I like that you're reconciling the formatting. I always thought the icon was a little weird where it's placement is plus having the avatar. I made a slight modification to rjens 1st layout by rearranging the info, removing the avatar and moving the print page down.


Offline @rjen

  • Support Team
  • *
  • Posts: 2602
    • FJR-club Nederland
Re: Examples / tips for improvement of articles + icons layout
« Reply #15 on: September 11, 2020, 02:29:09 PM »
Yeah, I also find that showing both the image AND icon is a bit too much for the Articles + Icons layout. I think I will remove the avatar completely there.

The Print page function seems a bit out of place on the category page and frontpage. I think I will only show that on the single article pages...
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 7042
    • Camera Craniums
Re: Examples / tips for improvement of articles + icons layout
« Reply #16 on: September 11, 2020, 03:25:42 PM »
Yeah, I also find that showing both the image AND icon is a bit too much for the Articles + Icons layout. I think I will remove the avatar completely there.


You can just turn them off in front page settings. "Show avatars in forum-topics"

Offline @rjen

  • Support Team
  • *
  • Posts: 2602
    • FJR-club Nederland
Re: Examples / tips for improvement of articles + icons layout
« Reply #17 on: September 11, 2020, 03:33:17 PM »
I know, but I think many admins may not remember that and may complain about it. So  I am considering to remove the from the articles + icons layouts only.

Or maybe we can put the author  and avatar in a more suitable place in those 2 layouts?
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline @rjen

  • Support Team
  • *
  • Posts: 2602
    • FJR-club Nederland
Re: Examples / tips for improvement of articles + icons layout
« Reply #18 on: September 11, 2020, 04:08:41 PM »

I like that you're reconciling the formatting. I always thought the icon was a little weird where it's placement is plus having the avatar. I made a slight modification to rjens 1st layout by rearranging the info, removing the avatar and moving the print page down.

Having problems putting the article info on separate lines: the code is setup in such a way that it affects all layouts. Need to think about that...

Just throwing some ideas in the mix...

What about something like this?
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline jernatety

  • Sr. Member
  • ****
  • Posts: 340
Re: Examples / tips for improvement of articles + icons layout
« Reply #19 on: September 12, 2020, 01:37:57 PM »
That looks really good.