Login  |  Register
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

Welcome, Guest. Please login or register.
Did you miss your activation email?

September 26, 2020, 03:54:35 PM

Login with username, password and session length
Members
Stats
  • Total Posts: 191020
  • Total Topics: 20891
  • Online Today: 107
  • Online Ever: 917
  • (January 21, 2020, 09:02:26 AM)
Users Online
Users: 3
Guests: 60
Total: 63

Author Topic: Question after upgrading to TP 2.0.0 RC1  (Read 802 times)

0 Members and 1 Guest are viewing this topic.

Online @rjen

  • Support Team
  • *
  • Posts: 2482
    • FJR-club Nederland
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #40 on: September 01, 2020, 05:51:41 AM »
Yep, it is caused by the content of the topic...

So now I have an example to play with...
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline jernatety

  • Sr. Member
  • ****
  • Posts: 340
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #41 on: September 01, 2020, 05:54:18 AM »
Thanks,

I understand that it is no longer an issue for you, but it is something that is not right. And I cannot find the same example in my test sites. Maybe it is something in this topic that causes it...

Interesting, that's all of the text in that topic, as you can see it's pretty basic formatting.

Online @rjen

  • Support Team
  • *
  • Posts: 2482
    • FJR-club Nederland
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #42 on: September 01, 2020, 06:21:49 AM »
ok, it is caused by the ending slash in the link at the end of the topic.

[ url=http://www.faithinthefuture.com/]Home | Faith in the Future[/u rl].

Due to that slash the shortenString routine seems to choke...

Tportal.php, line 1617:
if(TPUtil::shortenString($row['body'], $context['TPortal']['frontpage_limit_len']))

This ends up in a preg_match statement that still blows my mind, but I assume tino will know what to do...
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Online tino

  • Developer
  • *
  • Posts: 1995
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #43 on: September 01, 2020, 06:55:22 AM »
Code: [Select]
[img]http://archphila.org/wp-content/themes/archdioceseofphiladelphia/images/archdioceselogo.png[/img]

[size=18pt][b]ANNOUNCEMENT FROM THE OFFICE OF CATHOLIC EDUCATION AND FAITH IN THE FUTURE REGARDING FALL INTERSCHOLASTIC SPORTS IN THE 17 ARCHDIOCESAN HIGH SCHOOLS[/b][/size]

If you remove that section does it still break? I think it’s finding the wrong closing tag.

Online @rjen

  • Support Team
  • *
  • Posts: 2482
    • FJR-club Nederland
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #44 on: September 01, 2020, 07:04:15 AM »
That section is at the start: removing that while leaving the end part as-is fixes it too...

So two ways to 'repair'

And I agree: it is not shortening the post due to a mix-up in tags...
Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Online lurkalot

  • Administrator
  • *
  • Posts: 6953
    • Camera Craniums
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #45 on: September 01, 2020, 11:05:19 AM »
Nice work guys, great to see these issues sorted so promptly. O0

Online tino

  • Developer
  • *
  • Posts: 1995
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #46 on: September 01, 2020, 11:28:17 AM »
If you change following https://github.com/Tinyportal/TinyPortal/blob/dbb2d5fd52fe7fdb87f14a9e2cd7aa99845d874b/TinyPortal/Util.php#L178

To
Code: [Select]
if(strstr($matches[0], $matches[1]) === false) {
It will work ok, I am trying to work out why I did the line before it to get rid of the tag. I think it was for short tags which end in /]

Online @rjen

  • Support Team
  • *
  • Posts: 2482
    • FJR-club Nederland
Re: Question after upgrading to TP 2.0.0 RC1
« Reply #47 on: September 01, 2020, 01:22:01 PM »
That is indeed the fix... I'll submit it..

Running TP2.0.0 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info