News: TinyPortal Release Schedule. Please read this update for More Info.

Login  |  Register
HTML5 Icon HTML5 Icon
TP on Social Media
Welcome, Guest. Please login or register.
Did you miss your activation email?

August 24, 2019, 06:35:17 PM

Login with username, password and session length

Recent

Members
  • Total Members: 3751
  • Latest: tom888
Stats
  • Total Posts: 188700
  • Total Topics: 20746
  • Online Today: 86
  • Online Ever: 629
  • (November 08, 2018, 01:36:54 PM)
Users Online
Users: 0
Guests: 55
Total: 55

Author Topic: Duplicate shouts  (Read 1265 times)

0 Members and 1 Guest are viewing this topic.

Offline Oldiesmann

  • Jr. Member
  • **
  • Posts: 27
    • Cincy Space
Duplicate shouts
« on: June 22, 2019, 06:07:31 PM »
Link to my forum: https://www.christianphotographers.com/community
SMF version: 2.1 RC2
TP version: 1.6.3
Default Forum Language: English
Theme name and version: Curve 2
Browser Name and Version: Chrome 75
Mods installed: TP, Optimus, Pretty URLs, SMF Gallery Pro
Related Error messages: None


I just added a shoutbox to the forum. I have it set up so it will submit shouts when you press enter. However, I discovered tonight that pressing enter results in the shout being submitted twice. If I don't hit enter and just click "Shout" instead, it only goes through once. I'd like to leave it as is for convenience but don't want duplicate shouts.

Offline lurkalot

  • Administrator
  • *
  • Posts: 6149
    • Camera Craniums
Re: Duplicate shouts
« Reply #1 on: June 22, 2019, 06:55:36 PM »
Just tested this in TP 1.6.4 beta and it doesn't do it.  Haven't tried it in TP 1.6.3 but will asap.

Offline lurkalot

  • Administrator
  • *
  • Posts: 6149
    • Camera Craniums
Re: Duplicate shouts
« Reply #2 on: June 22, 2019, 06:59:05 PM »
Just tested this in TP 1.6.4 beta and it doesn't do it.  Haven't tried it in TP 1.6.3 but will asap.

Wonder if it's something do with the news fader you have running below it.

Offline lurkalot

  • Administrator
  • *
  • Posts: 6149
    • Camera Craniums
Re: Duplicate shouts
« Reply #3 on: June 22, 2019, 07:05:53 PM »
 :hmm: Interesting, I have mine set Submit Shout on enter key? No

But it still shouts when hitting the enter or return key. Looks like it's a bug.  You might try setting it to No, and see if it'll only shout once, until we can fix it.

Offline lurkalot

  • Administrator
  • *
  • Posts: 6149
    • Camera Craniums
Re: Duplicate shouts
« Reply #4 on: June 23, 2019, 08:01:48 AM »
Confirmed, still shouts pressing the enter or return key even when set to "No"

Setting to "Yes" results in the duplicate shout problem mentioned above.  Setting it back to "No" cures the duplicate shout problem, but it doesn't disable the Submit Shout on enter key as it should.

Thanks for the report.  ;)

Offline @rjen

  • Support Team
  • *
  • Posts: 1753
    • FJR-club Nederland
Re: Duplicate shouts
« Reply #5 on: June 23, 2019, 01:47:24 PM »
mmm I see the problem: I have never really tested this setting. Has it even been functional?  If so, do you recall what version of TP it was in?
Running TP1.6.3 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6149
    • Camera Craniums
Re: Duplicate shouts
« Reply #6 on: June 23, 2019, 01:59:32 PM »
mmm I see the problem: I have never really tested this setting. Has it even been functional?  If so, do you recall what version of TP it was in?

Glad you can see the cause.  Yes it did work, when tino first added it, but I haven't tested it either in last couple of releases, so not sure when it broke. 

Offline @rjen

  • Support Team
  • *
  • Posts: 1753
    • FJR-club Nederland
Re: Duplicate shouts
« Reply #7 on: June 23, 2019, 02:02:09 PM »
It seems to be a Javascript function in Tpshout.php.

I do not have experience with Javascript, so not sure why it is not working anymore, but I think we had some javascript related issues some time ago?
Running TP1.6.3 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6149
    • Camera Craniums
Re: Duplicate shouts
« Reply #8 on: June 23, 2019, 02:05:22 PM »
It seems to be a Javascript function in Tpshout.php.

I do not have experience with Javascript, so not sure why it is not working anymore, but I think we had some javascript related issues some time ago?

Thanks.  I did create an issue for this on GitHub, hopefully tino can take a look when he has a moment. 
« Last Edit: June 24, 2019, 01:44:29 PM by lurkalot »

Offline tino

  • Developer
  • *
  • Posts: 1588
Re: Duplicate shouts
« Reply #9 on: June 24, 2019, 02:02:25 PM »
I’m guessing Chrome has changed how it handles enter for submit boxes. Does it occur in other browsers?