News: TinyPortal Release Schedule. Please read this update for More Info.

Login  |  Register
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media
Welcome, Guest. Please login or register.
Did you miss your activation email?

April 02, 2020, 09:23:07 AM

Login with username, password and session length

Recent

Members
Stats
  • Total Posts: 189572
  • Total Topics: 20808
  • Online Today: 625
  • Online Ever: 917
  • (January 21, 2020, 09:02:26 AM)
Users Online
Users: 0
Guests: 398
Total: 398

Author Topic: Intro text bbc articles getting line feeds  (Read 6812 times)

0 Members and 1 Guest are viewing this topic.

Offline @rjen

  • Support Team
  • *
  • Posts: 2013
    • FJR-club Nederland
Intro text bbc articles getting line feeds
« on: August 02, 2018, 03:18:58 PM »
Noticed something funny with the short text for bbc articles. It seems to be setting line feeds based on the size of the entry screen...

Example: https://test.fjr-club.nl/index.php?cat=Nieuws

I created the article on my iPhone : the short text is line feeded by the screen size : this is not intentional!
When I create the text in landscape format it does the same but with longer lines...

This does not seem to occur with html articles..,
« Last Edit: September 19, 2018, 02:42:37 PM by @rjen »
Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline tino

  • Developer
  • *
  • Posts: 1737
Re: Intro text bbc articles getting line feeds
« Reply #1 on: August 02, 2018, 04:01:19 PM »
The bbc editor is the one from SMF? Does the standard forum post exhibit the same issue?

Offline @rjen

  • Support Team
  • *
  • Posts: 2013
    • FJR-club Nederland
Re: Intro text bbc articles getting line feeds
« Reply #2 on: August 02, 2018, 04:08:27 PM »
The bbc editor is the one from SMF? Does the standard forum post exhibit the same issue?

No it does not. Btw the ‘ intro text field’. Does not really have a editor I believe...
It’s the one in attached screenshot...

Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6468
    • Camera Craniums
Re: Intro text bbc articles getting line feeds
« Reply #3 on: August 03, 2018, 01:13:56 AM »
The bbc editor is the one from SMF? Does the standard forum post exhibit the same issue?

No it does not. Btw the ‘ intro text field’. Does not really have a editor I believe...
It’s the one in attached screenshot...

Ooh, nasty.  @rjen, was the text in the intro copied and pasted from the text in the bbc editor above? or was it typed?  What happens if you save the article, preview it, and then grab that text from the main article and paste it into the intro?

EDIT: Ignore that last question, I can see it doesn't make a difference.  I can replicate the problem on my Laptop using Chrome Window Resizer. Here's a screenshot  of an older intro done on my laptop at full screen, and a new one using he window resizer.

And another screenshot, when I go back and visit the edit page via my laptop at normal rez.

Offline tino

  • Developer
  • *
  • Posts: 1737
Re: Intro text bbc articles getting line feeds
« Reply #4 on: August 03, 2018, 07:17:41 AM »

Offline @rjen

  • Support Team
  • *
  • Posts: 2013
    • FJR-club Nederland
Re: Intro text bbc articles getting line feeds
« Reply #5 on: August 03, 2018, 07:21:10 AM »
Ok only occurs in Chrome it seems.

https://github.com/tinoest/TinyPortal/commit/bad785e5e1566be72b30a4c8c75e77f8734c8235

Fixes the issue.

In my case it happened in Safari as well.
Mick, I found it in working on the docs site. Any chance to put the fix there ?
Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6468
    • Camera Craniums
Re: Intro text bbc articles getting line feeds
« Reply #6 on: August 03, 2018, 10:57:02 AM »
Ok only occurs in Chrome it seems.

https://github.com/tinoest/TinyPortal/commit/bad785e5e1566be72b30a4c8c75e77f8734c8235

Fixes the issue.

In my case it happened in Safari as well.
Mick, I found it in working on the docs site. Any chance to put the fix there ?

Added the fix over there now.  Though it was different line numbers from the ones shown in the repo.

It was on lines,

2253 and 2265

Offline tino

  • Developer
  • *
  • Posts: 1737
Re: Intro text bbc articles getting line feeds
« Reply #7 on: August 03, 2018, 11:01:21 AM »
Probably would be as that repo includes the other changes I made to the menu manager.

Offline @rjen

  • Support Team
  • *
  • Posts: 2013
    • FJR-club Nederland
Re: Intro text bbc articles getting line feeds
« Reply #8 on: August 03, 2018, 11:05:31 AM »
Just checked it on the shoutbox document and the problem is solved!
Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info

Offline lurkalot

  • Administrator
  • *
  • Posts: 6468
    • Camera Craniums
Re: Intro text bbc articles getting line feeds
« Reply #9 on: August 03, 2018, 11:16:54 AM »
Probably would be as that repo includes the other changes I made to the menu manager.

Thanks, I thought that might be the case.  ;)

Just checked it on the shoutbox document and the problem is solved!

Cool.  Thanks for letting us know.  :tick:

Offline @rjen

  • Support Team
  • *
  • Posts: 2013
    • FJR-club Nederland
Re: Intro text bbc articles getting line feeds
« Reply #10 on: September 19, 2018, 02:43:01 PM »
Fixed in the newest version of TP
Running TP1.6.4 on SMF2.0 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 RC2
Want to check what php version I am testing on? See: PHP Info