TinyPortal

Development => Feedback => Topic started by: Skb on March 25, 2019, 04:59:01 PM

Title: The NEW Button
Post by: Skb on March 25, 2019, 04:59:01 PM
I'm using SMF 2.1 RC1 / TP 1.6.2.
I have a Right Panel with the Recent Posts Block.
In this Block clicking the NEW button does not have the anticipated response.
It goes to the first post of the last page of the topic.
Whereas, clicking the NEW button in the SMF Board view takes you to your first unread post.

Anyone else experienced that ?
Title: Re: The NEW Button
Post by: lurkalot on March 26, 2019, 12:46:05 AM
Thanks for the report.  We'll have to check that out and see what's going on.

I think 2.1 has had some issues where this stuff is pointing to the wrong place, including the alerts.  Not sure if they have sorted all this yet.
Title: Re: The NEW Button
Post by: @rjen on March 26, 2019, 01:37:02 AM
It seems that you have a point...

The new link from the unread view uses another message id then the link from the recent block...

Recent block uses the message ID of the new message, SMF uses that of the last message read... not sure what is causing this and why it did not pop-up before..

Unread link SMF:
https://test2.fjr-club.nl/index.php?topic=23259.msg327172;topicseen#new

Unread link Recent block:
https://test2.fjr-club.nl/index.php?topic=23259.msg327173;topicseen#new

Will have to check it out later...

Just did some checks on 2.0 and even though the same links are used there in 2.0.15 both links bring you to the first new post. In 2.1 the recent block drops you on the first message on the page that holds the new post...
Title: Re: The NEW Button
Post by: Skb on March 27, 2019, 12:34:04 AM
On this site if I click the NEW button in the Recent Posts block to the left, it takes me to the first unread post, which is how it should be.
Title: Re: The NEW Button
Post by: @rjen on March 27, 2019, 12:39:31 AM
True, it is only not working correctly on 2.1.

This site is on 2.0.15
Title: Re: The NEW Button
Post by: @rjen on March 27, 2019, 03:55:55 AM
Caused by changes in SMF's SSI.php

function ssi_recentTopics

The field id_msg is populated differently in 2.1 then in 2.0...
No idea if this is something that is a bug or intentional...
Title: Re: The NEW Button
Post by: tino on March 27, 2019, 01:01:25 PM
If it’s in SSI.php please raise it with SMF. It’s not a issue with TinyPortal.
Title: Re: The NEW Button
Post by: @rjen on March 27, 2019, 01:07:41 PM
It must be: we are using the href link generated by the SSI function.

It seems to be different with 2.1 from 2.0.
Can’t put my finger on the exact cause though ..,
Title: Re: The NEW Button
Post by: @rjen on March 27, 2019, 03:34:52 PM
Logged...

https://github.com/SimpleMachines/SMF2.1/issues/5548
Title: Re: The NEW Button
Post by: lurkalot on March 29, 2019, 01:17:50 AM
I assume this is related to this problem? https://github.com/SimpleMachines/SMF2.1/pull/5478/files

Though it's scheduled for RC3
Title: Re: The NEW Button
Post by: @rjen on March 29, 2019, 01:34:04 AM
Good catch, did not see that one...

Just checked the fix, but even though it is very similar, the fix proposed there does NOT fix this issue from SSI...
Title: Re: The NEW Button
Post by: lurkalot on March 29, 2019, 01:47:02 AM
Good catch, did not see that one...

Just checked the fix, but even though it is very similar, the fix proposed there does NOT fix this issue from SSI...

I did wonder, but I know 2.1 has the same problem with going to the wrong place, usually the top of page on a page containing a new post, instead of the actual new post.  Think this is what that commit fixes, thought it might have been related.
Title: Re: The NEW Button
Post by: Skb on March 30, 2019, 11:37:09 PM
The issue seems to be sorted in RC2.
Title: Re: The NEW Button
Post by: @rjen on March 31, 2019, 01:28:58 AM
The issue seems to be sorted in RC2.

Not on my RC2 test site... :-\
Title: Re: The NEW Button
Post by: Skb on April 01, 2019, 12:50:23 AM
Yes, you are right. It has not been sorted.
I checked a post, and it happened to be the first one on a new page. I was misled into thinking that it was done.
Title: Re: The NEW Button
Post by: VladTepes on April 07, 2019, 09:46:41 PM
Well there you go... a reason to look forward to RC3  :2funny: