TinyPortal

Development => Feedback => Topic started by: @rjen on January 01, 2016, 08:39:54 AM

Title: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 01, 2016, 08:39:54 AM
Hi Guys,
still very happy with Tinyportal, and glad you guys have update to the latest version. I still find Tinyportal the best Portal Mod for SMF.

I was wondering is there are plans to update Tinyportal for use with SMF 2.1 sometine in the future? I checked the forum, but could not find information on this.

No hurry, but sometine in the future SMF 2.1 should be stable and having Tinyportal will be a go/no-go criterium for upgrading my forum...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 01, 2016, 09:33:21 AM
@rjen.  Happy new year to you.

Actually we're already testing a version in SMF 2.1 You can see it here, http://cctestsite.info/testsite3/ It's working pretty nicely so far.  ;)
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 01, 2016, 09:42:11 AM
Looks excellent. Can't tell what needs work on the backend, the front-end seems quite OK.

Of course, Happy new year to you too!

I will be keeping my eyes open for the official announcement of the next version of TP!
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 01, 2016, 09:46:32 AM
Looks excellent. Can't tell what needs work on the backend, the front-end seems quite OK.

Of course, Happy new year to you too!

I will be keeping my eyes open for the official announcement of the next version of TP!

Thanks, that's Illori's handy work, she's done a great job on this conversion.  O0
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 01, 2016, 10:35:39 AM
@rjen, I forgot to ask. Do you have a test site?

if yes then you could grab a copy of TP2 from our GitHub repo which can be found here https://github.com/Tinyportal/TinyPortal-SMF2.1

Remember this must only be used for testing, and not on a production site. 

You must download and install the latest GitHub version of SMF2.1 beta 2 from their GitHub repo found here. https://github.com/SimpleMachines/SMF2.1

Any feedback would be appreciated.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 01, 2016, 12:00:59 PM
Will do some time soon. I can setup a local copy of our forum and run an upgrade to 2.1. Will Let you know what I find....
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 02:29:51 AM
So, I upgrade my test forum to 2.1 Beta this mornign and installed the new TP.

Forum can be found here: test.fjr-club.nl

How I went about it:
Step 1. Upgraded the forum 2.0.11 to 2.1 Beta:

- I dit not uninstall any of the existing MODs, SMF 2.1 updrage should give me a clean set of files (I believe)
- I uploaded the Dutch language pack from SMF
- I corrected three errors in the Dutch language pack for SMF   >:(

Result: Forum up and running on 2.1 beta, dutch language ..

Step 2. Installed TP2.0 using the package manager

- I did not bother updating my old SMF 2.0 them: that is another topic, using default from her on
- Installation works OK and redirects me to the TP admin page

So far no problems.

Then the findings start:

The Homepage does not build correctly: you can check the site for an example
And give errors:

Number 1:
Fatal error: Call to undefined function set_avatar_data() in /home/deb77453/domains/fjr-club.nl/public_html/test/Sources/TPSubs.php on line 2240

May be in one of the block codes (recent posts, see http://www.fjr-club.nl/)
It seems this is now completely ruining the page, so I may have to dactivate this block for now...

Number 2:
The admin log is filling up rapidly wtih errors:

8: Undefined index: 5
File: /home/deb77453/domains/fjr-club.nl/public_html/test/Themes/default/TPsubs.template.php
Line: 999

I am going to see what I can fix...


[update]

Deactivating the Recent topics Block made the page build a little further, alas, now the error apperas at the first article the tries to build...


Fatal error: Call to undefined function set_avatar_data() in /home/deb77453/domains/fjr-club.nl/public_html/test/Themes/default/TPsubs.template.php on line 102

There is definiately a problem with the retrieval of the avatars...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 03:24:19 AM
@rjen, just to clarify, the test site is here http://test.fjr-club.nl/index.php

I think you're the only one who's gone down the upgrade route so far, so I'm sure we're going to run into some problems like this.  I've only tested on clean installs atm, not sure about the rest of the team.

Anyway, could you start by turning off page=1 in your articles. 

Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 03:30:11 AM
@rjen, just to clarify, the test site is here http://test.fjr-club.nl/index.php

I think you're the only one who's gone down the upgrade route so far, so I'm sure we're going to run into some problems like this.  I've only tested on clean installs atm, not sure about the rest of the team.

Anyway, could you start by turning off page=1 in your articles.

Yes, that is the test site.

And no problems being the first to upgrade: someone has to do it and I rather have a nice upgrade than having to recreate alle the content manually...

I am not sure what you mean by switching of page=1 in articles? Do you mean not showing them om the home page?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 03:32:37 AM
Done that, and the homepage now shows...

but going to an article: http://test.fjr-club.nl/index.php?page=9

Still the same problem:
Fatal error: Call to undefined function set_avatar_data() in /home/deb77453/domains/fjr-club.nl/public_html/test/Sources/TPortal.php on line 619
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 03:36:34 AM
@rjen, just to clarify, the test site is here http://test.fjr-club.nl/index.php

I think you're the only one who's gone down the upgrade route so far, so I'm sure we're going to run into some problems like this.  I've only tested on clean installs atm, not sure about the rest of the team.

Anyway, could you start by turning off page=1 in your articles.


I am not sure what you mean by switching of page=1 in articles? Do you mean not showing them om the home page?

Turn it off or stop it showing on front page will do I guess.

Edit: I see you have done this now. And the rest of the page is showing up. So it looks (to me) there's something in that article it doesn't like.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 03:38:58 AM
Done that, and the homepage now shows...

but going to an article: http://test.fjr-club.nl/index.php?page=9

Still the same problem:
Fatal error: Call to undefined function set_avatar_data() in /home/deb77453/domains/fjr-club.nl/public_html/test/Sources/TPortal.php on line 619

Ok so that article also causing problems. Do any of your articles display without problems?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 03:46:13 AM
I activated a menu block to access the articles but they all have the same problem.

Articles are pretty straight forward, so I do think it may be a code issue..  what is this function set_avatar_data() doing?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 03:53:01 AM
I activated a menu block to access the articles but they all have the same problem.

Articles are pretty straight forward, so I do think it may be a code issue..  what is this function set_avatar_data() doing?

No t sure to be honest, though this problem did pop up once before in testing when one off the team downloaded a older version of SMF 2.1 and tried running TP2 on it.

Where did you get the download of SMF 2.1 beta 2 from?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 03:54:44 AM
I got the bea 2.1 beta 2 from the SMF download, not Github. I was not sure the Github version is stable?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 03:57:17 AM
I got the bea 2.1 beta 2 from the SMF download, not Github. I was not sure the Github version is stable?

OK, if you read my first post where I said, you need to download and install the latest gihub version. Pretty sure if you do that it'll work.  The one from the downloads page is usually behind in development.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 04:02:24 AM
I did read it, but to be honest I am not that familiar with Github versions and was not sure if that version would install just like that.

As you already noticed I wanted to do an upgrade, not a fresh install, and the github repository does not hold upgrade scripts

Any tips on how to upgrade using Github files? Juste use the latest files and the older upgrade script?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 04:09:47 AM
I did read it, but to be honest I am not that familiar with Github versions and was not sure if that version would install just like that.

As you already noticed I wanted to do an upgrade, not a fresh install, and the github repository does not hold upgrade scripts

Any tips on how to upgrade using Github files? Juste use the latest files and the older upgrade script?

https://github.com/SimpleMachines/SMF2.1 Download zip on the r/h side.

All the files are in the zip, but they've hidden the upgrade files in a folder called "other" you'd need to extract all the files and zip them up again properly.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 04:13:00 AM
Ok, will do, though not today, thanks for the help sofar.

I will get you more feedback as soon as I have re installed the test forum...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 04:14:49 AM
Thanks. I'm sure it will work out.

I hope you made a backup of your database before doing any of this, should something go wrong. ;)
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 04:18:31 AM
Thanks. I'm sure it will work out.

I hope you made a backup of your database before doing any of this, should something go wrong. ;)

as my kids would say... duh!  ;)
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 04:19:20 AM
As you've already upgraded your database for 2.1 you might just get away with uploading the latest files from that zip  Not sure if there's any new database changes. Worth a try first.  Illori could advise you better on this.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 02, 2016, 04:21:53 AM
As you've already upgraded your database for 2.1 you might just get away with uploading the latest files from that zip  Not sure if there's any new database changes. Worth a try first.  Illori could advise you better on this.

you should always run upgrade.php to be on the safe side. they are trying to do some changes in the upgrade process so you have to run it.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 04:23:45 AM
Can I just overwrite the files, leave the database as-is and run upgrade after that? Or should I really reset the database to the 2.0.11 version?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 02, 2016, 04:40:42 AM
that will work fine.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 07:28:11 AM
Ok, so I took the latest sources from Github and did another upgrade.

Unfortunately the upgrade script for SMF got stuck at the step: Executing: "Updating legacy attachments..." (2 of 41)

I did not manage to get that upgrade script to finish, so I took the working upgarde script from the published update and ran that. This finished without problems.
The resulting forum works ok (although the board index does not look ' clean' but I assume that is work in progress)

I have installed Tinyportal 2.0 without problems It is now up and running. Will have to redo some css tricks I used in the articles for it to look OK, but that is my problem.

The error we idscussed earlier seems to be gone, but I do have some other observations for you guys:

1. Errros still showup in log:    8: Undefined index: 5
File: /Themes/default/TPsubs.template.php
Lines: 970, 982, 999, 1021

These errors are thrown in every time I klik on Edit in an article. It has something to do with a block typ? ( echo $types[$block['var4']]['code_bottom']; )
 
2. I am missing the 'read more' link in the articles that use the introtext
see: http://test.fjr-club.nl/index.php?cat=6

Will be setting up the rest of TP and let you knwo what else I find...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 08:26:06 AM
Ok, so I took the latest sources from Github and did another upgrade.

Unfortunately the upgrade script for SMF got stuck at the step: Executing: "Updating legacy attachments..." (2 of 41)

I did not manage to get that upgrade script to finish, so I took the working upgarde script from the published update and ran that. This finished without problems.
The resulting forum works ok (although the board index does not look ' clean' but I assume that is work in progress)

I have installed Tinyportal 2.0 without problems It is now up and running. Will have to redo some css tricks I used in the articles for it to look OK, but that is my problem.

The error we idscussed earlier seems to be gone, but I do have some other observations for you guys:

1. Errros still showup in log:    8: Undefined index: 5
File: /Themes/default/TPsubs.template.php
Lines: 970, 982, 999, 1021

These errors are thrown in every time I klik on Edit in an article. It has something to do with a block typ? ( echo $types[$block['var4']]['code_bottom']; )
 
2. I am missing the 'read more' link in the articles that use the introtext
see: http://test.fjr-club.nl/index.php?cat=6

Will be setting up the rest of TP and let you knwo what else I find...

Nice, slowly getting there then.  O0 I'm not sure why the read more link has gone awol.  Will have to look into this. Sure it worked for a article block when I tried it. You're scrolling news has taken a hit, and no longer scrolls.  Haven't tried using the move tags in SMF2.1 myself.

Your Downloads button on the main menu's missing a image.  Apart from those problems and the other's you mentioned it's looking pretty good from the outside. Adding the link again so we don't have to keep looking for it. http://test.fjr-club.nl/index.php

Edit: forgot to mention. remember the theme used on your testsite http://test.fjr-club.nl/index.php is much narrower than the one on your main live site. http://www.fjr-club.nl/index.php so hat's also pushing the content downwards.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 02, 2016, 08:42:51 AM
As for the Board Index: I am aware of width limitations, I was referring to the alignment issues pointed out with the arrows in attached screenshot.

The error messages are gone now: in the upgrade all existing blocks lost their ' style' assiignment. Once I had assigned them all a style again (catbg+windowbg) errors stopped...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 08:54:42 AM
As for the Board Index: I am aware of width limitations, I was referring to the alignment issues pointed out with the arrows in attached screenshot.

The error messages are gone now: in the upgrade all existing blocks lost their ' style' assiignment. Once I had assigned them all a style again (catbg+windowbg) errors stopped...

Strange, I'm not seeing this on my test forum, but mines probably out of date, it's a few weeks old now. Glad you sorted the errors though.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 09:02:01 AM
As for the Board Index: I am aware of width limitations, I was referring to the alignment issues pointed out with the arrows in attached screenshot.


Actually, it's not like that when I view it, everything's lined up neatly.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 02, 2016, 05:08:17 PM
@rjen, just a quick question regarding the "Read More" link.

Are you using intro's for those articles on your front page? Have you tried creating a new article to see if it shows up? 
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 03, 2016, 01:30:49 AM
Ceated a new article: test Article, put it on the Homepage. The Read More link is still missing..
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 03, 2016, 02:53:52 AM
Ceated a new article: test Article, put it on the Homepage. The Read More link is still missing..

OK, so can you try downloading TinyPortal-SMF2.1 (https://github.com/Tinyportal/TinyPortal-SMF2.1) again, Illori has applied some fixes for the Read More link.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 03, 2016, 04:03:40 AM
Done that just now:
- I uninstalled the previous version
- Deleted the package
- Uploaded the new one
- Reinstalled


No change...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 03, 2016, 04:37:50 AM
@rjen, just a quick question regarding the "Read More" link.

Are you using intro's for those articles on your front page?

Can you confirm please.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 03, 2016, 04:45:35 AM
what type of article are you creating? i just did one more fix, i dont know if applies to your issue or not without knowing what type or article you are using.

@rjen, just a quick question regarding the "Read More" link.

Are you using intro's for those articles on your front page?

Can you confirm please.

looking at the code, it does not look like you can have the read more link visible without using the intro for an article.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 03, 2016, 05:02:04 AM
Sorry, I thought I alread answered that.

I am mostly using html articles, and some php articles. Some of these are shown on the frontpage.

I For those articles where I use the Intro, I have maintained the intro text as well. Intro text is showing, not the read more link.

On smf 2.0.11 I ahve the read more link in the home page, and on the category page.
On 2.1 I do not have them anywhere...

Example categroy page:
http://test.fjr-club.nl/index.php?cat=6

Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 03, 2016, 05:03:39 AM
try the latest files from today. i think the fix i put in will fix those types of article types with the intro.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 03, 2016, 05:35:13 AM
try the latest files from today. i think the fix i put in will fix those types of article types with the intro.

I will check the files later today.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 03, 2016, 06:10:25 AM
I updated TPSubs.php, that seems to have fixed the issue...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 03, 2016, 06:23:20 AM
great.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on January 03, 2016, 06:24:52 AM
I updated TPSubs.php, that seems to have fixed the issue...

Excellent.  Please keep an eye on the error log and report any findings.  Thanks.

@Illori, thanks for sorting this so quickly.  O0
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 04, 2016, 07:51:18 AM
I am noticing some errors in the logs that you may find interesting:

Number 1
8: Undefined index: forum_name

Bestand: /home/deb77453/domains/fjr-club.nl/public_html/test/Themes/default/languages/TPortal.english.php
Regel: 306

It seems to appear when an incorect link is used:
The link used: http://test.fjr-club.nl/index.php?action=dlattach;topic=8120.0;attach=2913;image

Number 2
8: Undefined index: is_logged

Bestand: /home/deb77453/domains/fjr-club.nl/public_html/test/Sources/TPSubs.php
Regel: 205 and 176

The link used: http://test.fjr-club.nl/index.php?action=dlattach;topic=8120.0;attach=2907;image

Any ideas?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 04, 2016, 07:56:10 AM
the first error has been reported a few times but no idea why it is happening. it seems to happen randomly. my SMF 2.1 test forum has never had that error, where my test forum for SMF 2.0 has seen that one.

the second error has not been reported.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 04, 2016, 09:13:54 AM
This one is strange.

If I go to my profile and try to access the Tinyportal options there (Portal Summary, Articles, etc..) it does not let me in: instead I get message: An Error Has Occurred, You are not allowed to access this section.

This is not right (I am admin). Tried with a regular accoutn as well, same problem?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 04, 2016, 05:50:42 PM
got part of that solved, a bit more needed before i commit the fix.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 05, 2016, 02:34:56 AM
got part of that solved, a bit more needed before i commit the fix.

Thanks for that.

Another question: responsiveness.

With the standard responsive theme in 2.1., the sidebars for Tinyportal are interfering with the layout in small screens (see attached screenshots).

In my 2.0.11. forum I am using the Responsive Curve MOD and have had to make a few source code edits to suppress the left and right panel automatically on small screens. Any change you can modify TP to be able to control this behaviour from the settings?

I take it a complete redesign to make it fully responsive may be asking too much  ;) 
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 06, 2016, 01:26:49 AM
One more obeservation: every time someone tries to access a non-existing topic or board below error message is logged:

   8: Undefined index: tp-tphelp
http://test.fjr-club.nl/index.php?topic=7537.0
/home/deb77453/domains/fjr-club.nl/public_html/test/Themes/default/index.template.php
Regel: 354

Code: [Select]
351: // There is now a global "Go to top" link at the right.
352: echo '
353: <ul>
==>354: <li class="floatright"><a href="', $scripturl, '?action=tpmod;sa=help">', $txt['tp-tphelp'], '</a> | <a href="', $scripturl, '?action=help">', $txt['help'], '</a> ', (!empty($modSettings['requireAgreement'])) ? '| <a href="'. $scripturl. '?action=help;sa=rules">'. $txt['terms_and_rules']. '</a>' : '', ' | <a href="#top_section">', $txt['go_up'], ' &#9650;</a></li>
355: <li class="copyright">', theme_copyright(), '</li>
356: </ul>';
357:
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 06, 2016, 03:22:39 AM
interesting. it seems on that error page it does not load TP, so the TPortal.<language>.php file is not loaded.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 12, 2016, 05:53:30 AM
Any luck on finding a solution for the Undefined index errors?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 12, 2016, 07:09:28 AM
not yet. some of them may not be able to fixed and others have not been duplicate to be able to fix.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 15, 2016, 02:39:18 PM
This one is strange.

If I go to my profile and try to access the Tinyportal options there (Portal Summary, Articles, etc..) it does not let me in: instead I get message: An Error Has Occurred, You are not allowed to access this section.

This is not right (I am admin). Tried with a regular accoutn as well, same problem?

One more obeservation: every time someone tries to access a non-existing topic or board below error message is logged:

   8: Undefined index: tp-tphelp
http://test.fjr-club.nl/index.php?topic=7537.0
/home/deb77453/domains/fjr-club.nl/public_html/test/Themes/default/index.template.php
Regel: 354

Code: [Select]
351: // There is now a global "Go to top" link at the right.
352: echo '
353: <ul>
==>354: <li class="floatright"><a href="', $scripturl, '?action=tpmod;sa=help">', $txt['tp-tphelp'], '</a> | <a href="', $scripturl, '?action=help">', $txt['help'], '</a> ', (!empty($modSettings['requireAgreement'])) ? '| <a href="'. $scripturl. '?action=help;sa=rules">'. $txt['terms_and_rules']. '</a>' : '', ' | <a href="#top_section">', $txt['go_up'], ' ▲</a></li>
355: <li class="copyright">', theme_copyright(), '</li>
356: </ul>';
357:

both of those issues should be resolved. committed to github. i still need to add the utf-8 language edit but should be good enough for now.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 02:32:32 AM
Great,

I reinstalled the GitHub package and now the tphelp issue is gone. Also the tinyportal section in the profile is accessible.
(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Ftest.fjr-club.nl%2FSmileys%2Ffjrclub%2Fyellow_21.gif&hash=522db0630f16cf6cf54332144ba4bfdb)

I now only have one recurring error on TP:    8: Undefined index: forum_name

Another note:
I have deactivated the TP Shouts and Download module, however this still shows in the User profile settings. (http://test.fjr-club.nl/index.php?action=profile;area=tpdownload;)

Due the fact that the download module is not switched on this function always throws in an error message.
Would it not be more logical to NOT show the option in the user menu (Portal Summary > Tiny Portal > Uploaded Files) ?
The same would apply to the "View Shouts" option...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 03:26:47 AM
I resolved the forum name message based on the not on the SMF forum: http://www.simplemachines.org/community/index.php?topic=27642.msg3856486#msg3856486

For now I just removed the forum_name variable from the TPortal.english.php file

Code: [Select]
//$txt['whoall_forum'] = 'Viewing the board index of <a href="' . $scripturl . '">' . $context['forum_name'] . '</a>.';
$txt['whoall_forum'] = 'Viewing the board index of the forum';
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 16, 2016, 05:15:42 AM

Another note:
I have deactivated the TP Shouts and Download module, however this still shows in the User profile settings. (http://test.fjr-club.nl/index.php?action=profile;area=tpdownload;)

Due the fact that the download module is not switched on this function always throws in an error message.
Would it not be more logical to NOT show the option in the user menu (Portal Summary > Tiny Portal > Uploaded Files) ?
The same would apply to the "View Shouts" option...

i might be able to fix the dl stuff but i dont think i can fix the shoutbox as there is no real enable/disable setting to show or not show settings related to it.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 05:32:14 AM
DL stuff would be great. That causes messages in the log. Shoutbox does not do that.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 16, 2016, 07:25:49 AM
in TPortal.english.php add
Code: [Select]
$txt['tp-dlmanageroff'] = 'The DL Manager module is not active.'; somewhere that will stop the errors.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 08:14:49 AM
Actually, it does not: I made that change in my forum already a year ago: now it drops these messages in the error log with a description, but they are still errors.

And since 2.1 shows all errors in the menu for admins I will still see all these in the log...

Users tend to click on options in their profile if they find them: and this option is useless since the download manager is not in use.

I have had to explain this already a number of times to the users in my forum, therefor it would be an improvement if the option is not shown when the download manager is not active...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 08:42:37 AM
Now I can switch the Editor on and off I have been testing some layout questions I had: in the new TP articles I noticed that the style elements I use to in my articles do not show the same layout as before.

I cannot seem to resolve the issue.

What I see is that the style elements I was used to from the standard SMF css do not seem to work in Articles anymore.

Mostly the layouts for paragraphs < p> < /p> and lists < ol> ( ul> are not shown in the usual styles anymore.

For comparison, check this article:

In SMF 2.0.11 with TP 1.2
http://www.fjr-club.nl/index.php?page=8

In SMF 2.1 with TP 2
http://test.fjr-club.nl/index.php?page=8
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 16, 2016, 09:56:30 AM
Actually, it does not: I made that change in my forum already a year ago: now it drops these messages in the error log with a description, but they are still errors.

And since 2.1 shows all errors in the menu for admins I will still see all these in the log...

Users tend to click on options in their profile if they find them: and this option is useless since the download manager is not in use.

I have had to explain this already a number of times to the users in my forum, therefor it would be an improvement if the option is not shown when the download manager is not active...

i might be able to get the button to go away for the downloads. still looking into it.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 16, 2016, 09:59:06 AM
Now I can switch the Editor on and off I have been testing some layout questions I had: in the new TP articles I noticed that the style elements I use to in my articles do not show the same layout as before.

I cannot seem to resolve the issue.

What I see is that the style elements I was used to from the standard SMF css do not seem to work in Articles anymore.

Mostly the layouts for paragraphs < p> < /p> and lists < ol> ( ul> are not shown in the usual styles anymore.

For comparison, check this article:

In SMF 2.0.11 with TP 1.2
http://www.fjr-club.nl/index.php?page=8

In SMF 2.1 with TP 2
http://test.fjr-club.nl/index.php?page=8

seems the css in SMF 2.1 is giving you issues. not really a TP issue.

Code: [Select]
ul, ol {
list-style: none outside none;
}
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 10:08:21 AM
I am not sure.  The style in forum topics is unchanged and the list item are showing as they were in 2.0.11. only in the TP articles it seems changed...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 11:13:17 AM
You are right that the css for 2.1 causes this.

I commented out this section:

Code: [Select]
/* <p> is a possible exception for margins. Must test that one a bit.
p, ul, ol, li, dl, dd ,dt, fieldset, form {
box-sizing: border-box;
padding: 0;
margin: 0;
}

/*ul, ol {
list-style: none;
}
*/

and now the articles in TP display as they did before...

You may just pay some attention to this change and what it means for TP users: it 'breaks' the layout in articles for anyone who will upgrade to the new TP version and SMF 2.1.

As a result I will have to 're-write' alle my articles, and to be honest: re-creating the bullited lists that I used cannot be done in TP articles unless I manually change the TP CSS file. Is that the desired setup?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 16, 2016, 11:23:49 AM
that is in the index.css file right? that is not in the tp css file at all.

the SMF devs decided that code was needed nothing to do with TP.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 16, 2016, 11:29:00 AM
Correct it is in index.css.

And you are right. It is not caused by any change in TP. Unfortunately it does affect the way TP content will be displayed in the future.

So how do future TP users recreate a bulleted list in TP 2.0?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 16, 2016, 12:09:09 PM
maybe if the list is in a div that css would not apply?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 17, 2016, 05:06:23 AM
as per http://www.simplemachines.org/community/index.php?topic=412286.0

i have changed most of the errors to fatal_lang_error and not logging to the error log. please test and report any issues. this also fixes the download area error and having it visible in the profile drop down.

Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 17, 2016, 06:24:37 AM
as per http://www.simplemachines.org/community/index.php?topic=412286.0

i have changed most of the errors to fatal_lang_error and not logging to the error log. please test and report any issues. this also fixes the download area error and having it visible in the profile drop down.

Thanks for the quick reply Illori!

I just reinstalled TP with the latest code base and did some tests. No problems with languages, but I am afraid the on/off in the member profile does not work yet (or maybe I am missing something)

Based on the module settings in de TP admin section I was expecting the menu option to be there or not to be there (see attachments) is my assumption correct that there is no change regardless of these settings?

Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 17, 2016, 09:55:06 AM
are you sure you have the updated files for all in place? this seems to work correctly for me.

https://github.com/Tinyportal/TinyPortal-SMF2.1/blob/TP2.1/Sources/TPassimilate.php#L154 and the line following control showing it in the menu.

(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fi.imgur.com%2Fe0TgDef.png&hash=77b46e81952b05d24e3ef09d173d8fc1)
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 17, 2016, 10:26:24 AM
That's the same I have. So the download manager option is gone. That's good.

However, when I switch the download manager back on, I was expecting the old menu option to come back... and that it does not...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on January 17, 2016, 11:11:56 AM
in TPassimilate.php

find

Code: [Select]
function tpAddProfileMenu(&$profile_areas)
{
global $txt;

change to

Code: [Select]
function tpAddProfileMenu(&$profile_areas)
{
global $txt, $context;
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on January 17, 2016, 12:58:59 PM
Problem solved  O0
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: VladTepes on April 05, 2017, 05:43:14 PM
Old thread yes, but probably the right one.

Looking here it appears that TP development to prepare for SMF2.1 are continuing?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: illori on April 06, 2017, 03:09:54 AM
it is at a stand still right now, but it works as far as i know with the current SMF 2.1 beta
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: VladTepes on April 06, 2017, 10:18:48 PM
Where can I grab the TP2.0 beta from, to try running on my SMF2.1 test forum ?

Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on April 06, 2017, 11:38:37 PM
Grom github. Checkout the start of this topic: it has all instructions there already
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: VladTepes on April 07, 2017, 07:40:17 AM
Thanks
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: @rjen on June 12, 2017, 06:04:15 AM
Maybe not the best place to mention this, but I will leave the message here as well: the fix applied to make TP1.2R3 working with PHP version 7.1 also needs to be applied to the code for TP 2.0. I applied the same fixes here and now my 2.1 beta 3 forum also works on PHP 7.1
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: Mc Fly on July 22, 2017, 01:09:40 AM
Just installed the last github-repos of SMF 2.1 (beta 4!) and TP.  :)

Got a general error "8192: Methods with the same name as their class will not be constructors in a future version of PHP; chain has a deprecated constructor" in TPSubs.php line 539.

And the Database-Error on "Home":
Quote
Expression #9 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'smf21.a.id_attach' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
File: /var/www/testserver/Projekte/smf2.1/Sources/TPortal.php
Line: 1624

Server is running PHP7/FPM... I think I have to read all threads about PHP7...  ;D

EDIT:
Fixed the database error and an error on adding articels by changing sql_mode(s).
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on July 22, 2017, 05:47:32 AM
Just installed the last github-repos of SMF 2.1 (beta 4!) and TP.  :)

Got a general error "8192: Methods with the same name as their class will not be constructors in a future version of PHP; chain has a deprecated constructor" in TPSubs.php line 539.

And the Database-Error on "Home":
Quote
Expression #9 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'smf21.a.id_attach' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
File: /var/www/testserver/Projekte/smf2.1/Sources/TPortal.php
Line: 1624

Server is running PHP7/FPM... I think I have to read all threads about PHP7...  ;D

EDIT:
Fixed the database error and an error on adding articels by changing sql_mode(s).

There's a few php 7 compatibility fixes here, https://www.tinyportal.net/index.php?topic=35895.0 although they are for TP 1.3 they should work for TP2 which is what you're trying out.  Hope this helps.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: Mc Fly on July 22, 2017, 10:06:41 AM
...

There's a few php 7 compatibility fixes here, https://www.tinyportal.net/index.php?topic=35895.0 although they are for TP 1.3 they should work for TP2 which is what you're trying out.  Hope this helps.

I think I found all of the fixes, even for pre-2.0, and tried them. Nothing.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: Mc Fly on July 22, 2017, 10:34:18 AM
 :2funny: :2funny: :2funny:

Damn it! I have also running  another version (SMF 2.0.14 with TP 1.3) on the same server and looked there ...

Find in TPSubs,php (about line 550)
Code: [Select]
   function chain($primary_field, $parent_field, $sort_field, $rows, $root_id, $maxlevel)
and replace it
Code: [Select]
   function __construct($primary_field, $parent_field, $sort_field, $rows, $root_id, $maxlevel)
That's it.  ;D
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: fussilet on September 13, 2017, 12:24:17 PM
Hi all, I get this error when I log out or login

Quote
Not Found

The requested URL /action=forum was not found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

page: www.fussilet.com

Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on September 14, 2017, 01:08:34 AM
Hi all, I get this error when I log out or login

Quote
Not Found

The requested URL /action=forum was not found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

page: www.fussilet.com

Hi fussilet, how's things with you

I haven't come across that particular error on my testbed, but asap I will do a fresh install of 2.1 beta 3 and TP and see if it behaves.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: fussilet on September 14, 2017, 11:10:14 AM
Hi fussilet, how's things with you

I haven't come across that particular error on my testbed, but asap I will do a fresh install of 2.1 beta 3 and TP and see if it behaves.

Hi lurkalot, I am a little uncomfortable but still good , if you need I can send my account information

regards.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on September 16, 2017, 08:39:45 AM
Hi fussilet, how's things with you

I haven't come across that particular error on my testbed, but asap I will do a fresh install of 2.1 beta 3 and TP and see if it behaves.

Hi lurkalot, I am a little uncomfortable but still good , if you need I can send my account information

regards.

Sorry for delay coming back to this.  I have tried a fresh local install with the official 2.1 beta 3 and Tinyportal 2, and can't reproduce this problem.

Does it do this with default theme as well?  I'm just assuming you're using one of your own themes?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: fussilet on September 16, 2017, 10:58:29 AM
no problem Lurkalot, the bug do with themes all
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on September 16, 2017, 11:31:27 AM
no problem Lurkalot, the bug do with themes all

OK, tried your login and see what you mean, it throws the error but clicking back you are logged in. Strange.  Did it only start doing this after installing Tinyportal 2?  Have you tried uninstalling Tinyportal to see if it still gives you the error?
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: fussilet on September 16, 2017, 12:24:36 PM
yes, it did only start doing this after installing Tinyportal 2, I do not see the problem when I uninstalled TinyPortal, you can try out...

Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on September 16, 2017, 02:32:20 PM
OK fussilet, try logging in and out again please and see if it behaves normally.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: fussilet on September 17, 2017, 12:38:11 AM
thank you so much lurkalot, everything seems to be alright, can i learn what the problem
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on September 17, 2017, 02:41:38 AM
thank you so much lurkalot, everything seems to be alright, can i learn what the problem

Excellent, glad it's working. 

There appears to be a problem with the TP setting 

"How to redirect after login:  Redirect to forum  Redirect to frontpage"

Yours was set to Redirect to forum, so I changed it to Redirect to frontpage and it started working for me.  Something we'll need to investigate.  ;) 
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on September 17, 2017, 02:46:59 AM
Oh, and if it's still possible for me to login on your site, I would like to take a screenshot of your TP Settings and TP Frontpage Settings please, so I can compare and test.
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: fussilet on September 17, 2017, 03:22:34 AM
okey, Dear lurkalot, you can test on mysite everything...

regards...
Title: Re: Any plans on making TinyPortal ready for SMF 2.1?
Post by: lurkalot on September 17, 2017, 03:51:36 AM
Thanks for the screenshots, that saves me a job. Cheers.

I will test the "Redirect to forum" setting (1st screenshot)on my test site combined with settings from your second screenshot, and see what happens.