Hello,
A few items with new install.
Old 1.6.7 uninstalled and deleted, 2.0 installed.
After install checked TP Front page options and still have 5 front page forums allowed
Front page layout is ignoring image tags in posts
Tinyportal front page is no longer handheld wireless friendly, ie, not responsive.
Thank you for any help in advance
Quote from: jernatety on August 31, 2020, 07:06:21 PM
Hello,
A few items with new install.
Old 1.6.7 uninstalled and deleted, 2.0 installed.
After install checked TP Front page options and still have 5 front page forums allowed
Front page layout is ignoring image tags in posts
Tinyportal front page is no longer handheld wireless friendly, ie, not responsive.
Thank you for any help in advance
The last one will be in your settings.
The front page options is not a multi select so allows as many as you like.
Ignoring image tags how?
Quote from: tino on August 31, 2020, 07:16:24 PM
Quote from: jernatety on August 31, 2020, 07:06:21 PM
Hello,
A few items with new install.
Old 1.6.7 uninstalled and deleted, 2.0 installed.
After install checked TP Front page options and still have 5 front page forums allowed
Front page layout is ignoring image tags in posts
Tinyportal front page is no longer handheld wireless friendly, ie, not responsive.
Thank you for any help in advance
The last one will be in your settings.
The front page options is not a multi select so allows as many as you like.
Ignoring image tags how?
Hi Tino, if you want to take a look, all topics on the front page with images in them are not showing the images, they're actually showing the image tags.
youth-hockey-info-.comno hyphens
It appears it's ignoring the bbc completely.
Are those forum topics?
Quote from: tino on August 31, 2020, 07:33:22 PM
It appears it's ignoring the bbc completely.
Are those forum topics?
Yes, the option "Forum Topics Only" from front page settings is what I've always used and is selected now.
Quote from: tino on August 31, 2020, 07:33:22 PM
It appears it's ignoring the bbc completely.
Are those forum topics?
Yep, just tested this and it's happening when front page setting "Only forum-topics" or "Promoted topics only" are selected.
But the images work if you select "Forum-topics and articles - sorted on date" or "Promoted topics + articles - sorted on date"
Hi Mick, if I change to that the image tags for forum posts work. But I don't allow my articles to be posted.
What do you mean "I don't allow my articles to be posted."?
Quote from: jernatety on August 31, 2020, 07:54:02 PM
Hi Mick, if I change to that the image tags for forum posts work. But I don't allow my articles to be posted.
Yep Ross, sorry was just feeding my findings to tino, I'm not suggesting you use that setting. The two forum posts settings mentioned above are broken it seems.
Quote from: @rjen on August 31, 2020, 07:56:13 PM
What do you mean "I don't allow my articles to be posted."?
I never promote any articles to the front page, only forum posts.
Quote from: lurkalot on August 31, 2020, 07:58:16 PM
Quote from: jernatety on August 31, 2020, 07:54:02 PM
Hi Mick, if I change to that the image tags for forum posts work. But I don't allow my articles to be posted.
Yep Ross, sorry was just feeding my findings to tino, I'm not suggesting you use that setting. The two forum posts settings mentioned above are broken it seems.
Ok, thought so, I cannot revert back so is this something I can edit manually to get the BBC to work on front page?
Also, I don't have any of my themes selected for general settings > Select non-responsive themes. I use default curve and responsiveness is broken.
Quote from: jernatety on August 31, 2020, 08:04:01 PM
Also, I don't have any of my themes selected for general settings > Select non-responsive themes. I use default curve and responsiveness is broken.
You have the responsive curve mod installed though, yes?
Quote from: jernatety on August 31, 2020, 08:00:46 PM
Quote from: @rjen on August 31, 2020, 07:56:13 PM
What do you mean "I don't allow my articles to be posted."?
I never promote any articles to the front page, only forum posts.
Aa a temporary fix, switch to "Forum-topics and articles - sorted on date" and simply do not select any articles to show on the frontpage: that will give you the same as "Only forum-topics"
Tried clearing your cache (Ctrl+F5)?
Quote from: lurkalot on August 31, 2020, 08:07:20 PM
Quote from: jernatety on August 31, 2020, 08:04:01 PM
Also, I don't have any of my themes selected for general settings > Select non-responsive themes. I use default curve and responsiveness is broken.
You have the responsive curve mod installed though, yes?
Yep 4 years. The only changes I made were Uninstalling TP 1.6.7 and deleted. Then installed 2.0 RC1
Quote from: @rjen on August 31, 2020, 08:11:39 PM
Tried clearing your cache (Ctrl+F5)?
How do I deselect articles? When I turn it on it's showing test articles from 3 years ago.
I always do the same cache dump whenever I make changes
1. Maintenance > Routine > Clear files cache
2. ctrl f5
3. Manual browser cache through settings
Look at the screenshot I added: there are two icons behind each article that must be unchecked: "Featured" and "Show on Frontpage", or go into the article that is showing on the frontpage and in the settings for the article make sure that "show on frontpage' is unchecked
By the way: I think the responsiveness is broken to the very long unparsed image strings that are now showing...
Yep, that looks better...
Quote from: @rjen on August 31, 2020, 08:21:07 PM
Look at the screenshot I added: there are two icons behind each article that must be unchecked: "Featured" and "Show on Frontpage", or go into the article that is showing on the frontpage and in the settings for the article make sure that "show on frontpage' is unchecked
By the way: I think the responsiveness is broken to the very long unparsed image strings that are now showing...
Ok, got it and that fixed the responsive issue. There were two topics with long URLS which were breaking the resposiveness.
One other issue. This topic is on the front page https://www.youthhockeyinfo.com/index.php?topic=1857 I have show 300 characters selected in the front page settings. The entire body of the topic is showing, it's about 1 thousand words.
Quote from: jernatety on August 31, 2020, 08:30:42 PM
One other issue. This topic is on the front page https://www.youthhockeyinfo.com/index.php?topic=1857 I have show 300 characters selected in the front page settings. The entire body of the topic is showing, it's about 1 thousand words.
I didn't notice when I looked at your site with your original setting "Only forum-topics" was it limiting to 300 characters with that setting?
Quote from: lurkalot on August 31, 2020, 08:39:11 PM
Quote from: jernatety on August 31, 2020, 08:30:42 PM
One other issue. This topic is on the front page https://www.youthhockeyinfo.com/index.php?topic=1857 I have show 300 characters selected in the front page settings. The entire body of the topic is showing, it's about 1 thousand words.
I didn't notice when I looked at your site with your original setting "Only forum-topics" was it limiting to 300 characters with that setting?
I switched back to forum topics only and it limits to 300. I turned back to forum topics and articles and the entire contents of words shows again
Quote from: jernatety on August 31, 2020, 08:44:09 PM
Quote from: lurkalot on August 31, 2020, 08:39:11 PM
Quote from: jernatety on August 31, 2020, 08:30:42 PM
One other issue. This topic is on the front page https://www.youthhockeyinfo.com/index.php?topic=1857 I have show 300 characters selected in the front page settings. The entire body of the topic is showing, it's about 1 thousand words.
I didn't notice when I looked at your site with your original setting "Only forum-topics" was it limiting to 300 characters with that setting?
I switched back to forum topics only and it limits to 300. I turned back to forum topics and articles and the entire contents of words shows again
Thanks for checking that. Looks like another bug then.
One more I just found.
On the front page forum topic blocks it used to show the number of comments in the bottom left corner of all topics showing.
Comments: 0 or the number of comments. That's gone.
Comments? For forum topics?
Not sure that was supposed to show in the first place...
Quote from: @rjen on August 31, 2020, 08:59:00 PM
Comments? For forum topics?
Not sure that was supposed to show in the first place...
That comment count is something else that shows when selecting "Only forum-topics"
It does count the number of replies to the topic.
Ah, makes sense. Perhaps an improvement opportunity for articles and topics view then
Quote from: lurkalot on August 31, 2020, 09:03:44 PM
Quote from: @rjen on August 31, 2020, 08:59:00 PM
Comments? For forum topics?
Not sure that was supposed to show in the first place...
That's something else that shows when selecting "Only forum-topics"
Yes when I turn it back on it shows "# Comments | write comment"
So not really a bug, difference in both layout options. But I agree: may be an improvement for the layout...
Do you happen to have html and bbc mixed in your forum posts?
Quote from: @rjen on August 31, 2020, 09:15:01 PM
So not really a bug, difference in both layout options. But I agree: may be an improvement for the layout...
Hi Tino, no I don't. Forum posts, if any special formatting is exclusively BBC.
I managed to add the missing comments line to the articles and forum topics layouts. That will be in the next release.
I think I also fixed the forum topics images not being parsed. I submitted the fix for that and request a review from tino...
https://github.com/Tinyportal/TinyPortal/pull/704
Thanks @rjen. Was just about to say, those image tags were working on the 1st August, using "Only forum-topics" I was just checking on a test site I had one of the first RC1's on, http://lts4.byethost7.com/testsite7/index.php
It's merged now. That was a quick review O0
jernatety,
two fixes are both tagged for the next TP release. If you are confident to upload attached file to your forum 'Sources/' folder that should fix it for you...
> Promoted topics only and Only forum-topics on frontpage not showing images
> Promoted topics + articles - sorted on date and Forum-topics and articles - sorted on date not showing the comments links on the frontpage
Perfect, you guys are the best! And as always I love Tiny Portal!
Please report anything else you find that appears to be 'off'...
The change from 1.6.7 to 2.0.0 RC1 has been a big one...
Quote from: @rjen on September 01, 2020, 11:54:11 AM
Please report anything else you find that appears to be 'off'...
The change from 1.6.7 to 2.0.0 RC1 has been a big one...
No problem and I very much appreciate the fantastic updates, it's even more powerful now, the best CMS around as far as I'm concerned.
Quote from: jernatety on September 01, 2020, 11:52:53 AM
Perfect, you guys are the best! And as always I love Tiny Portal!
Jernatety, this issue with some forum topics showing more then the limt.
Could you provide us with the full content of this topic: https://www.youthhockeyinfo.com/index.php?topic=1857
I need the full raw message content...
Quote from: @rjen on September 01, 2020, 12:33:37 PM
Quote from: jernatety on September 01, 2020, 11:52:53 AM
Perfect, you guys are the best! And as always I love Tiny Portal!
Jernatety, this issue with some forum topics showing more then the limt.
Could you provide us with the full content of this topic: https://www.youthhockeyinfo.com/index.php?topic=1857
I need the full raw message content...
Sure, no problem. That's no longer an issue after switching back to forum topics only option. It's only an issue in Forum topics and articles option.
[img]http://archphila.org/wp-content/themes/archdioceseofphiladelphia/images/archdioceselogo.png[/img]
[size=18pt][b]ANNOUNCEMENT FROM THE OFFICE OF CATHOLIC EDUCATION AND FAITH IN THE FUTURE REGARDING FALL INTERSCHOLASTIC SPORTS IN THE 17 ARCHDIOCESAN HIGH SCHOOLS[/b][/size]
Today, all school families, administrators, faculty, and staff in the 17 Archdiocesan high schools located throughout the five-county regions received a joint letter from Sister Maureen Lawrence McDermott, I.H.M. Ph.D., Superintendent for Secondary Schools for the Archdiocese of Philadelphia, and Irene Horstmann Hannan, Chief Executive Officer of Faith in the Future.
The letter was in regard to the status of interscholastic athletic competition for the fall season. The full text of that letter is below.
Since the emergence of the coronavirus as a national health emergency last spring, we have worked diligently to maintain the health and safety of each member of every school community while continuing to provide an educational product of unparalleled excellence.
As the landscape of the pandemic has shifted over time, we have taken steps to meet continued challenges and communicated with you regularly regarding essential decisions. Our commitment to school safety and clear communication is steadfast.
As you are likely aware, the PIAA shared a public announcement last Friday afternoon that its board voted to permit fall sporting competitions to take place in high schools around the Commonwealth of Pennsylvania at the discretion of the local school entity.
In the case of the Archdiocese of Philadelphia, the local entity consists of all 17 high schools in the five-county region as a unified body. In reality, we are a system of secondary schools and the Department of Education in Harrisburg views us a school district spanning multiple counties.
Our system operates under the jurisdiction of the Office of Catholic Education and Faith in the Future. As such, senior leadership from both FIF and OCE have carefully deliberated PIAA's announcement through the lens of the principles that have always shaped our response to the pandemic—preserving health and safety, following guidelines established by the governor, Department of Health and Department of Education, and maintaining a consistent system-wide approach to decision making.
After much careful thought, consultation, and prayer a decision has been reached that all of our high schools will opt out of participation in interscholastic competition for the fall 2020 season. We recognize that this news is disappointing to many of our students, families and coaches, particularly our seniors. It saddens us greatly as well. We recognize the value of athletics as part of our educational philosophy that seeks to provide for the holistic formation of young men and women of character. This is not the scenario any of us desired.
We are confident that PIAA will seek to provide alternative solutions for those entities opting out of fall programs in the coming semester. The pandemic has made every aspect of life unpredictable for all of us over the past several months. As we continue to live in a time of uncertainty, it would be imprudent to speculate regarding an exact time when competitions will resume or regarding the status of spring semester athletics. In keeping with our commitment, we will share timely information with you about developments and decisions affecting our schools.
Schools that have individual fees for athletics will delay them until later in the year. In some schools, there is one combined fee instead of separate athletics, so in those cases the fees remained unchanged. However, in the event, we are forced to cancel any athletic programs; we will prorate all applicable fees.
Please know that we share your disappointment regarding the current status of fall sports programs. It is our hope that your disappointment will be tempered by an understanding that we have an obligation to protect all those entrusted to our care. Athletics could not be treated separately and it fell to us to make this decision in a manner consistent with everything else done to this time. Given the nature of athletic competition and the manner in which COVID-19 is transmitted, there is currently no way for us to reasonably provide for the health and safety of student-athletes as well as those with whom they come into contact.
We are grateful to Governor Wolf and the Departments of Health and Education for their sound guidance to school districts throughout the Commonwealth and look forward to working with PIAA regarding possible solutions as we move forward. Our greatest degree of gratitude goes to our students, parents, coaches, teachers, staff, and administrators for their continued trust and dedication to the gift of Catholic education.
# # #
Editor's Note: For information about Catholic schools in the Archdiocese of Philadelphia, please visit aopcatholicschools.org/. For information about Faith in the Future Foundation, please visit [url=http://www.faithinthefuture.com/]Home | Faith in the Future[/url].
Thanks,
I understand that it is no longer an issue for you, but it is something that is not right. And I cannot find the same example in my test sites. Maybe it is something in this topic that causes it...
Yep, it is caused by the content of the topic...
So now I have an example to play with...
Quote from: @rjen on September 01, 2020, 12:49:49 PM
Thanks,
I understand that it is no longer an issue for you, but it is something that is not right. And I cannot find the same example in my test sites. Maybe it is something in this topic that causes it...
Interesting, that's all of the text in that topic, as you can see it's pretty basic formatting.
ok, it is caused by the ending slash in the link at the end of the topic.
[ url=http://www.faithinthefuture.com/]Home | Faith in the Future[/u rl].
Due to that slash the shortenString routine seems to choke...
Tportal.php, line 1617:
if(TPUtil::shortenString($row['body'], $context['TPortal']['frontpage_limit_len']))
This ends up in a preg_match statement that still blows my mind, but I assume tino will know what to do...
[img]http://archphila.org/wp-content/themes/archdioceseofphiladelphia/images/archdioceselogo.png[/img]
[size=18pt][b]ANNOUNCEMENT FROM THE OFFICE OF CATHOLIC EDUCATION AND FAITH IN THE FUTURE REGARDING FALL INTERSCHOLASTIC SPORTS IN THE 17 ARCHDIOCESAN HIGH SCHOOLS[/b][/size]
If you remove that section does it still break? I think it's finding the wrong closing tag.
That section is at the start: removing that while leaving the end part as-is fixes it too...
So two ways to 'repair'
And I agree: it is not shortening the post due to a mix-up in tags...
Nice work guys, great to see these issues sorted so promptly. O0
If you change following https://github.com/Tinyportal/TinyPortal/blob/dbb2d5fd52fe7fdb87f14a9e2cd7aa99845d874b/TinyPortal/Util.php#L178
To if(strstr($matches[0], $matches[1]) === false) {
It will work ok, I am trying to work out why I did the line before it to get rid of the tag. I think it was for short tags which end in /]
That is indeed the fix... I'll submit it..