TinyPortal

Development => Support => Topic started by: Phasotron Zhuk on November 19, 2015, 03:39:29 AM

Title: Image Quicklist not working
Post by: Phasotron Zhuk on November 19, 2015, 03:39:29 AM
TP 1.1
SMF 2.0.11
gollies net au
Core Theme

Upload a new image into the quick-list does not work. I click the [Browse] button, select an image (tried many different types and sizes) and the image file name appears but nothing else happens.

Saving the article and returning to it resets the image quick-list back to "No file selected."
Title: Re: Image Quicklist not working
Post by: illori on November 19, 2015, 10:23:20 AM
i believe this was tested and found to be a bug. a javascript bug. i am not a javascript expert so this was put on the back burner to be fixed by someone else.
Title: Re: Image Quicklist not working
Post by: Phasotron Zhuk on November 20, 2015, 04:23:26 AM
Thanks for the reply. Will keep an eye out here for any progress. My frontpage articles look bare since updating to SMF2 and TP1.1
Title: Re: Image Quicklist not working
Post by: Phasotron Zhuk on December 21, 2015, 07:37:59 PM
TP 1.2
SMF 2.0.11
gollies.net.au (http://gollies.net.au)
Core Theme

I've updated to TP1.2 and the Image Quick-list still isn't working. Is there anyway I can insert images into TP articles?
Title: Re: Image Quicklist not working
Post by: illori on December 21, 2015, 07:55:15 PM
since i am not a javascript expert the same that was earlier still applies.
Title: Re: Image Quicklist not working
Post by: wildenborch on December 22, 2015, 07:07:50 AM
Hi Boomslang,

Did it work with a previous version of TP?
Are you sure your tp-images folder and subfoilders have the right permissions? Mine have 755
And which browser are you using. In the past I had problems with IE.

Best regards,
Fred

Title: Re: Image Quicklist not working
Post by: illori on December 22, 2015, 10:24:52 AM
it is a javascript error, if you open your browsers dev tools to inspect the page and try to add or use an image it will throw some js errors. does not seem to matter which browser etc. i think it has been a while since it has worked correctly looking at when the code has changed last.

if you do get them uploaded they dont always end up in the body box when you click on them.

Quote from: illori
in IE
QuoteUnable to get property 'nodeName' of undefined or null reference

in firefox/firebug..

QuoteTypeError: sel is null
   

sel=oW.getSelection(),sn=sel.anchorNode;

it is erroring on line 533 of whizzwig.js

i am not a javascript person so i cant solve this issue.

i bet this is also happening in 1.111

it does seem to work if you use the WYSIWYG editor, the normal editor does not work and gives those errors.
Title: Re: Image Quicklist not working
Post by: wildenborch on December 22, 2015, 12:27:03 PM
I have never noticed any errors. Not in the past and not now.
But that's probably I always use the Wysiwyg editor.

Fred

Title: Re: Image Quicklist not working
Post by: illori on December 22, 2015, 01:45:25 PM
they are errors in your developers tools console, otherwise you will not see them.
Title: Re: Image Quicklist not working
Post by: Phasotron Zhuk on December 23, 2015, 06:35:52 AM
Thanks for attention. For info it also didn't work for TP 1.1. and I use the WYSIWYG and Firefox, now 43. Also tried IE.

tp-images folder is 755.

Will see what I can play around with.
Title: Re: Image Quicklist not working
Post by: Phasotron Zhuk on December 26, 2015, 05:17:13 AM
Not ideal but I managed a workaround by inserting URL's to the images I want to put into the TP articles.

As to the Quicklist, I can see place markers for the images in My Images Quicklist and they are in the tp-images folder but they aren't appearing in the list or in the article when you insert them, the code sometimes appears when you view HTML.

I hope someone fixes this issue soon, it really is a bummer not having it working.
Title: Re: Image Quicklist not working
Post by: lurkalot on December 26, 2015, 12:21:11 PM
Quote from: boomslang on December 26, 2015, 05:17:13 AM
Not ideal but I managed a workaround by inserting URL's to the images I want to put into the TP articles.

As to the Quicklist, I can see place markers for the images in My Images Quicklist and they are in the tp-images folder but they aren't appearing in the list or in the article when you insert them, the code sometimes appears when you view HTML.

I hope someone fixes this issue soon, it really is a bummer not having it working.

Sorry for the delay in sorting this one, we don't have anyone able to fix it atm, which is something I'm trying to work on.  I tend to manually add url's myself tbh. and just upload the images to a folder on my server via ftp. But yes this does need fixing to make life easier.

The image quicklist works fine for me, the images upload and display no problem. Makes me wonder if there's something in your tp-images/thumbs folder stopping them from displaying. An htaccess file or something.

Inserting the images into the article is the bit that doesn't work properly for me, I don't think it has since version 1.0 RC1 from my testing this morning. I think that was when the editor was replaced.

Also the quicklist creates a thumbnail image in(tp-images/thumbs), and a full size image in(tp-images), but with a lot of messing around I can insert the thumb which looks like it should be clickable, but the full size image does nothing but take up space.
Title: Re: Image Quicklist not working
Post by: illori on December 26, 2015, 01:54:17 PM
it is not an issue with their install, or their browser as i said on the last page. if you are using the standard non-WYSIWYG editor it does not embed the images into the editor. we have gone over this in the team boards before.

Quote from: illori on December 22, 2015, 10:24:52 AM
it is a javascript error, if you open your browsers dev tools to inspect the page and try to add or use an image it will throw some js errors. does not seem to matter which browser etc. i think it has been a while since it has worked correctly looking at when the code has changed last.

if you do get them uploaded they dont always end up in the body box when you click on them.

Quote from: illori
in IE
QuoteUnable to get property 'nodeName' of undefined or null reference

in firefox/firebug..

QuoteTypeError: sel is null
   

sel=oW.getSelection(),sn=sel.anchorNode;

it is erroring on line 533 of whizzwig.js

i am not a javascript person so i cant solve this issue.

i bet this is also happening in 1.111

it does seem to work if you use the WYSIWYG editor, the normal editor does not work and gives those errors.
Title: Re: Image Quicklist not working
Post by: wildenborch on December 26, 2015, 02:30:05 PM
Illori,

Boomslang is using the wysriwyg editor!
At least that what he writes....
QuoteThanks for attention. For info it also didn't work for TP 1.1. and I use the WYSIWYG and Firefox, now 43. Also tried IE.

tp-images folder is 755.

Will see what I can play around with.

Fred
Title: Re: Image Quicklist not working
Post by: illori on December 26, 2015, 03:42:14 PM
Quote from: boomslang on December 26, 2015, 05:17:13 AM
As to the Quicklist, I can see place markers for the images in My Images Quicklist and they are in the tp-images folder but they aren't appearing in the list or in the article when you insert them, the code sometimes appears when you view HTML.

that is confusing, it seems like they get insert them in WYSIWYG view and then changing to to html view they disappear. that is what i have seen happen.
Title: Re: Image Quicklist not working
Post by: Phasotron Zhuk on December 26, 2015, 08:32:04 PM
 :) Thanks for acknowledging the problem lurkalot, and I'm also uploading images to the server into a sub-folder that I link to in the article. Works well, just a bit fiddly.

:) Illori and wildenborch also thanks. I'll keep an eye out here for the fix, but it's not urgent as I can use links to images in the meantime.