Hello all!
First let me thank you for maintaining TP, could not make my website what it is without it, much appreciate all the support here. Now on to my issue:
Link to my forum: http://those-guys.eu/forum/
SMF version:Current SMF version: SMF 2.0.9
TP version: TinyPortal 1.107
Default Forum Language: English ISO-8859-1 8 en_US
Theme name and version: Vaux by Mick. G
Browser Name and Version: Google Chrome Version 40.0.2214.93 m
Mods installed:
1. Embed BBCode 2.0
2. Remove Message Icon 1.1.1
3. Removes the User Stars from the default template 1.0
4. Default_Membergroup 2.0
5. cbi 1.0 1.8.0
6. Add Favicon.ico Support 1.101
7. ResizeImagesToFitScreen 0.1.6
8. Pretty URLs 1.1.2
9. Default Avatar 2.3
10. View Only Boards 1.2c
11. Add Social Media Icons To Profiles 1.2.0
12. Custom Action Mod 3.2
13. TinyPortal 1.107
14. SMF Gallery Lite 5.0.1
15. Remove XHTML, RSS & WAP2 Links in Footer v1.1
16. Hide ip stuff for users 1.04
17. Menu Editor Lite 1.0.5
18. Rank Image Drop Down 1.0
19. Remove Index.Php Completely From URL 1.2
20. Misc Anti Spam 1.0
21. Embed Tweet BBCode 1.0.0
22. RIAST: Remove Index & Add Smart Title 1.3.0
23. Anti-Spam Links 1.0.1
24. URL Popup 1.0.2
25. Ultimate Profile 0.9.1
26. Expanding & Collapsing Spoiler Tag
Issue:
(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FH6jSbpd.png&hash=5de6654c7ac95b098c7b4d24365ec27fc5643e7b)
I am trying to fix the last bits on the website and I cannot figure out how to fix TP Shoutbox to utilize guests properly. The issue is the annoying missing avatar image and repeating shouts (each guest shout is displayed a couple times, while in TP admin I can only see one). I would like to disable avatars for guests completely and I have no idea how to prevent guest shout spam.
Thanks for any help, tried what I could think of, but can't figure it out.
If you allow guests to shout you are going to have spam. My suggestion would be to turn of guest shouts, and only allow members to shout.
The broken avatar and multiple shouts look like bugs and should be fixed if they are confirmed as bugs. I'll try reproducing it on my own forum to confirm.
As far as the spam goes though I don't think there's anything reasonable to do about it, as the spammers aren't stopped by captcha, and anything more elaborate, and hence more intrusive to legitimate users, would kinda defeat the spirit of the shoutbox.
Tested and confirmed multi-posting and broken image avatar shown when posting a guest shout.
Tested on Firefox, which does not show the broken image symbol, but the space where the avatar should be is a link to member profile, which of course is not found for a guest. Switching to Chrome the broken image image is shown.
Tested on Firefox, when a guest makes a shout, the shout is shown in the shout-box multiple times. My Shout box is set to show 10 shouts, and the guest is shown 10 time. When viewing the latest 50, the guest shout is shown 50 times. When viewing shouts in the admin area, the guest shout is shown only once, and removing it removes all instances of the guest shout from the shout-box and latest 50.
Edit: added to bugtracker
Happens in the latest build where I changed the shoutbox? Or only in TP 1.0 Willy?
Alright guys, thanks a lot for looking into it. :) Will disable guest shouts for now, not such a big loss.
I did a quick test on this with the TP 1.1 that has all the new shoutbox features I added some time ago. It's not behaving the same way for me. So if someone else can verify these things, I think it's pretty safe to say that it's fixed in the beta version.
Brad, just tested it on my test site, and GG site both running 1.1 They both have the problem exactly as WillyP described.
Haven't been able to reproduce it on my test site. You only have to turn on guest shout, and post a guest shout right? Or am I missing something?
Quote from: IchBin™ on January 30, 2015, 02:59:33 PM
You only have to turn on guest shout, and post a guest shout right? Or am I missing something?
Yes Brad, that all I did. Permissions > Can Post Shouts
I'd never seen this while testing, but then I never ever let guests post anything.
Well if you can figure anything else out, that would be helpful. I can't reproduce it yet. And I've posted a couple of guest posts on mine. Does the guest post need to be in a certain position in the list of shouts or anything? You have the default setting to show 10 shouts?
I've tried both FF and Chrome with no results... Mind sending me the link to your site so I can take a look at it?
Just tried it on my live site and got the repeated shouts from one posting.
(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fi58.tinypic.com%2F24oytrr.png&hash=0449d1418029a595a24e4e52b84e5f2588f3bfbf)
What version of TP 1.1 do you use, Ken?
I can't reproduce it either, on 1.108. I saw that OP is using 1.107 so Brad is right, it appears to be fixed in 1.108.
Unless you guys also use 1.108 :P
I tested on 1.104 :-[
Uh-oh :D
Quote from: WillyP on February 01, 2015, 08:27:11 PM
I tested on 1.104 :-[
Quote from: bloc on February 01, 2015, 08:42:05 PM
Uh-oh :D
lol :D Just shows how much that setting got used. I don't think anyone would be crazy enough to allow guest shouts tbh. Probably why I never tested it. ;)
EdIT:. Not that I'm calling the OP crazy, just something I'd never even consider someone wanting to do myself.
Its indeed a slight risk with it, not to mention a lot of moderating. But I am confident most admins are aware of this when they set it up.
Quote from: bloc on February 01, 2015, 08:20:17 PM
What version of TP 1.1 do you use, Ken?
I can't reproduce it either, on 1.108. I saw that OP is using 1.107 so Brad is right, it appears to be fixed in 1.108.
Unless you guys also use 1.108 :P
Bloc, my site is using 1.108.
EDIT: and... there is no way I would allow guest shouts either! ;D
The version on the SMF mod site is 1.107. I installed that, and had the same issue with the shout-box.
Hm..so why do some with 1.108 have it, while others don't...
Ken, could you try uploading latest TP files again? Just to make sure we are all on same files now.
I uninstalled TP before uploading 1.107, so maybe that's it.
Quote from: bloc on February 02, 2015, 04:30:00 PM
Hm..so why do some with 1.108 have it, while others don't...
Bloc, some of us are using the beta, for example I'm using 1.108 = TP 1.1 here, http://guitaristguild.com and here, http://cctestsite.info
And I'm running TP 1.107 = TP 1.0 here, http://cameracraniums.com
The problem exists in all three sites. ;)
Quote from: bloc on February 02, 2015, 04:30:00 PM
Hm..so why do some with 1.108 have it, while others don't...
Ken, could you try uploading latest TP files again? Just to make sure we are all on same files now.
OK Bloc... done. :)
1/ Uninstalled and deleted previous 1.108
2/ dl & installed a fresh copy from github
3/ made no other changes or adjustments, except for turning guest shout permissions back on
4/ got the same multiple shouts from one entry.
What settings do you have for the shoutbox? I have the attached below and no double postings.
This is a display issue... the post only shows once in shout-box admin.
Quote from: bloc on February 02, 2015, 06:27:12 PM
What settings do you have for the shoutbox? I have the attached below and no double postings.
Setting in TP 1.108 are in the SMF permissions. "Can Post Shouts"
Admin > Members > Permissions > guests > modify > Tinyportal > Can Post Shouts
Yes..but what settings on the shoutbox itself? I want to see if we are using anything different, to find the error.
Here's mine Bloc:
Quote from: WillyP on February 02, 2015, 06:34:36 PM
This is a display issue... the post only shows once in shout-box admin.
Ok, so maybe the error is in the template. You are using default templates? No theme-specific TP templates?
Quote from: bloc on February 02, 2015, 06:41:43 PM
Yes..but what settings on the shoutbox itself? I want to see if we are using anything different, to find the error.
Sorry bloc. ;)
Mine are attached.
Ok,so tried all settings you guys have, still nothing.But this is my local test-site, I need to try it online too.
Would any changing of the settings make it work for you?
Tried removing/adding each function of the settings and the result was the same for each one.
Same here. Thing is, some of these settings don't even exist in TP 1.0 and it's doing it on both TP 1.0 and TP 1.1 ;)
If you replace the below file in "tp-files/tp-modules/TPShout/Sources" - does it make any difference?
Quote from: bloc on February 02, 2015, 10:42:46 PM
If you replace the below file in "tp-files/tp-modules/TPShout/Sources" - does it make any difference?
That seems to have fixed it on my test site. No more duplicate shouts. O0
Quote from: bloc on February 02, 2015, 10:42:46 PM
If you replace the below file in "tp-files/tp-modules/TPShout/Sources" - does it make any difference?
Replacing that file causes it to stop returning multiples, but it blocks the previous shouts from displaying.
Could this issue have anything to do with using the enter key to post? Both Ken and Mick seem to be using that setting. However, I guess that really doesn't make much sense if it's happening in 1.0 since that version didn't even have that setting. I don't think it did anyway.
Quote from: Ken. on February 03, 2015, 02:31:36 AM
Replacing that file causes it to stop returning multiples, but it blocks the previous shouts from displaying.
Good catch Ken. ;) Your right, although I didn't notice this when I first tried it. Also found I couldn't delete the shout from within the shoutbox. It would let me delete one,, but not the rest of them. Turned of the auto refresh, then went back to shoutbox and it would let me delete them. Once those guest shouts were deleted all my other shout came back to normal.
Strange.
Well, the auto-refresh caches things in your browser, so I reckon thats why you had to turn it off.
As for why it has been this way for so long, I am sure its because very few use it, most want only members to shout to avoid spamming. Because its a MAJOR spamming risk lol. Technically the error comes from, I suspect, the left join against the member table for each shout.
For that reason I wonder if it should be restricted to members only in TP 1.1. It will not be passed on to TP2, the shoutbox there I want to recode.
Quote from: bloc on February 03, 2015, 04:10:16 PM
For that reason I wonder if it should be restricted to members only in TP 1.1. It will not be passed on to TP2, the shoutbox there I want to recode.
I'd be more than happy to see that option disappear. I'd never use it. But that's just me. ;)
I am attaching another fix for it, try it and see if that works better for the new errors as well.
Quote from: bloc on February 03, 2015, 06:29:37 PM
I am attaching another fix for it, try it and see if that works better for the new errors as well.
bloc, Still sort of the same here. Only this time, Post a guest shout and all the other shouts disappear. Refresh the page and they all come back. Post another and they disappear again.
Still can't delete a shout directly from the shoutbox either. Click delete and the shoutbox just refreshes. Have to delete from shoutbox admin. Or if I turn guest shout off in the permissions it will let me delete them in the shoutbox.
Yup, I tested it here on fresh files, seems like errors still. I'll see if this can be fixed(and duplicated, its strange I cannot provoke it on my local server :P )
Quote from: lurkalot on February 03, 2015, 06:50:39 PM
Quote from: bloc on February 03, 2015, 06:29:37 PM
I am attaching another fix for it, try it and see if that works better for the new errors as well.
bloc, Still sort of the same here. Only this time, Post a guest shout and all the other shouts disappear. Refresh the page and they all come back. Post another and they disappear again.
Still can't delete a shout directly from the shoutbox either. Click delete and the shoutbox just refreshes. Have to delete from shoutbox admin. Or if I turn guest shout off in the permissions it will let me delete them in the shoutbox.
The behavior on mine is basically the same, except that previous shouts still do not show on refresh.
EDIT:
Ps; imo this should be a low priority because none should be allowing guest shouts... just saying. ^-^
I second the idea of removing the option all together.
Quote from: Ken. on February 03, 2015, 10:29:41 PM^-^
I second the idea of removing the option all together.
That's what I would do. If enough people ask for it afterward, then maybe work on it again. I very much doubt they will though. ;)
Quote from: lurkalot on February 03, 2015, 10:38:19 PM
Quote from: Ken. on February 03, 2015, 10:29:41 PM^-^
I second the idea of removing the option all together.
That's what I would do. If enough people ask for it afterward, then maybe work on it again. I very much doubt they will though. ;)
In the past couple of years my memory keeps slip-sliding away... but that being said, I don't recall this issue ever coming up before.
I bet someone requested it at some point or Brad would never have added it. I don't think any of us on the team would use it but I can tell you right now that as soon as we make the decision to remove it, someone will ask for it. It's the nature of the beast, so to speak. So, IMHO, we should make the effort to fix it, if we can. I know that I'm the odd man out on this one but I think I might be right, as hard as that is to believe. >:D
I think I just moved shoutbox permissions to the SMF permission system. I can't remember all the details. lol Going into SMF permissions allowed guests to get the permission.
Yeah, that would explain it. :) That said..when did it happen? In TP 1.0 or 1.1?
Quote from: ZarPrime on February 04, 2015, 12:56:46 AM
I bet someone requested it at some point or Brad would never have added it. I don't think any of us on the team would use it but I can tell you right now that as soon as we make the decision to remove it, someone will ask for it. It's the nature of the beast, so to speak. So, IMHO, we should make the effort to fix it, if we can. I know that I'm the odd man out on this one but I think I might be right, as hard as that is to believe. >:D
Someone might..but is it worth adding a feature probably 1 or 2 members have been using or aksing for? It looks like Brad added quite late too so I can't imagine that many actually using it since then.
And theres of course the spam issue. Its not a spam-safe option, not the slightest.
I think he moved those permissions in 1.0 but I can't be certain right now. I don't even know how it works so I know I never tested it. I guess we should probably go ahead and remove the ability for guests to shout, or at least remove the permission from the SMF permission screen.
I'll see how it is easiest done..but I really think guests should not make shouts, same way they should not write articles or even post in forums. I mean..does anyone dare letting guests write topics? Unless they don't mind sitting and moderating all day long :P
And besides..what good is a community when you cannot reach its contributors again..guests cannot be tracked or notified or even be-friended. :P
But this is my opinion of course..whats everyone's stand on this?
I agree with you Bloc. I split the other issue posts to a new topic.
Great :)
I got a new version for you guys to test out. This file have been changed more elaborate so guest posts should not display multiple times. Not sure if it works though lol, since I only got time to look at it now, and its soon bedtime for me(busy day)
That worked! O0
It appears to be working correctly and is not throwing any errors to the error log.
Quote from: bloc on February 05, 2015, 09:43:07 PM
Great :)
I got a new version for you guys to test out. This file have been changed more elaborate so guest posts should not display multiple times. Not sure if it works though lol, since I only got time to look at it now, and its soon bedtime for me(busy day)
bloc, thanks. Seems to work fine. All existing shouts are there too. Did you get rid of the avatars though? they seem to have disappeared.
Quote from: lurkalot on February 05, 2015, 10:32:46 PM
Did you get rid of the avatars though? they seem to have disappeared.
:-[ Please ignore that last report, I had it on the alternative layout.
Hehe :) The avvy's should be there still. Great that it works, we can rule out this error then.
Now, I also changed the ability for guests to actually post, even if they are permitted :P but I did it in the template, meaning its easier to "change" back for those that want it.So if someone DOES want guest to shout, they can by changing the TPshout.template. Since the code now also show guest shouts correctly its having your cake and eat it too lol.
Incidentally it also means that shouts made by members that have deleted themselves after the shout was made, will show up correctly - but without being link to their profile(which doesn't exist of course). I don't think this particular issue was ever adressed.
Added the modified TPshout.template too. (Note that by uploading it, you should save the old one(rename for example) to make it possible to do guest shouting further.)