TinyPortal

Development => Support => Topic started by: cavedeamon on April 02, 2010, 06:51:33 PM

Title: SMF 1.1.11 TP 1.0 b5 profile broken
Post by: cavedeamon on April 02, 2010, 06:51:33 PM
When trying to visit one of tiny portals profile page I get the following error

URL: /index.php?action=profile;u=11;sa=tp_articles

error:
Fatal error: Call to undefined function tp_articles() in /mounted-storage/home103b/sub009/sc71196-UJCJ/www/forum/Sources/Profile.php on line 364

mods installed:
Another URL Popup          1.0
Forum Epoch                      1.0
Aeva Media                         1.1b
Foxy! for Aeva Media        1.23
Akismet Spam Blocking    1.2 Beta 2
Spoiler Tag                          0.7.2
reCAPTCHA for SMF         0.9.6
Super Admin                        1.5
TinyPortal                             1.098
BBC [you]                              1.2
Anonymize Links                 2.5
The Rules                            1.3
Attachments Positioning    1.2
New Style Message Icon    1.1
SMF Arcade                            2.0.18
Tar Game Uploader            1.0
PopUp Champs                   1.0
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: NeoMorph on April 02, 2010, 07:27:51 PM
I get the same error... I only have TinyPortal 1.05 installed and when I go to Profile and select "Portal Summary" I get...

QuoteFatal error: Call to undefined function tp_summary() in /home/ethicalg/public_html/f/Sources/Profile.php on line 342

When I click "Articles" in the TP section of the profile I get...

QuoteFatal error: Call to undefined function tp_articles() in /home/ethicalg/public_html/f/Sources/Profile.php on line 342

When I click "From TPShout" in the TP section of the profile I get...

QuoteFatal error: Call to undefined function tpshout_profile() in /home/ethicalg/public_html/f/Sources/Profile.php on line 339

Seems like it isn't calling the "TPmodules.php" include.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: IchBin on April 02, 2010, 07:55:48 PM
Make sure that the edits done to your Sources/Profile.php file have been done.
// TinyPortal
require_once($sourcedir. '/TPmodules.php');
tp_getprofileareas($profile_areas);


If they have not, then I would check all the files for the edits to make sure they are done. You can get the edits from clicking the parse button on the mod page at SMF for now.
http://custom.simplemachines.org/mods/index.php?mod=97
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: cavedeamon on April 02, 2010, 08:51:51 PM
The installation was verified by hand. All changes were made properly during initial installation. Though the code you have in above post is not mentioned anywhere in the tinyportal 1.0 b5 installation for SMF 1.1.11
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: NeoMorph on April 02, 2010, 09:16:02 PM
Quote from: IchBinâ„¢ on April 02, 2010, 07:55:48 PM
Make sure that the edits done to your Sources/Profile.php file have been done.
// TinyPortal
require_once($sourcedir. '/TPmodules.php');
tp_getprofileareas($profile_areas);


If they have not, then I would check all the files for the edits to make sure they are done. You can get the edits from clicking the parse button on the mod page at SMF for now.
http://custom.simplemachines.org/mods/index.php?mod=97

Well it looks like you installation package is at fault because the above code isn't anywhere in the parse for SMF 1.1.11 if you look at that link above.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: IchBin on April 02, 2010, 09:22:40 PM
Oops. Sorry, I was looking at the wrong version. I'm not sure about your problem. Let me look a little closer.

--edit--

Can you verify that the files were all uploaded properly? For SMF1.x the TPortal.php file should have a line that includes the TPmodules.php file.
require_once($sourcedir.'/TPmodules.php');
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: cavedeamon on April 02, 2010, 09:33:39 PM
on a fresh install of SMF and TP the file sourcedir/tportal.php does Not include the line require_once($sourcedir.'/TPmodules.php');
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: IchBin on April 02, 2010, 09:43:01 PM
Man.... there's too many versions!!! lmao Sorry, I looked at my SMF1.x beta 4. I need to leave here in a bit. I'll try to check back on this later when I have time to actually trouble shoot and install.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: NeoMorph on April 02, 2010, 11:46:07 PM
Dude... don't panic... Stuff like this happens. The number of times I tested and tested an update to a software package and just KNEW it was 99.9% bug free and then when I deployed it I ended up with loads of users tearing their hair out.

Often I ended up feeling a bit  :uglystupid2: when I realised it was just a missing semicolon ruining an install... often it was the installer itself that was the culprit... I have confidence you will find the problem.

It's one reason why I'm testing on a clean install of SMF 1.1.11 with only TP installed (ie no other packages to worry about).
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: Xarcell on April 03, 2010, 12:46:47 AM
Quote from: NeoMorph on April 02, 2010, 11:46:07 PM
Dude... don't panic... Stuff like this happens. The number of times I tested and tested an update to a software package and just KNEW it was 99.9% bug free and then when I deployed it I ended up with loads of users tearing their hair out.

Often I ended up feeling a bit  :uglystupid2: when I realised it was just a missing semicolon ruining an install... often it was the installer itself that was the culprit... I have confidence you will find the problem.

It's one reason why I'm testing on a clean install of SMF 1.1.11 with only TP installed (ie no other packages to worry about).

let me know how your fresh install goes, if it's error free, or the bug still appears.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: cavedeamon on April 03, 2010, 01:44:13 AM
Quote from: NeoMorph on April 02, 2010, 11:46:07 PM
Dude... don't panic... Stuff like this happens. The number of times I tested and tested an update to a software package and just KNEW it was 99.9% bug free and then when I deployed it I ended up with loads of users tearing their hair out.

Often I ended up feeling a bit  :uglystupid2: when I realised it was just a missing semicolon ruining an install... often it was the installer itself that was the culprit... I have confidence you will find the problem.

It's one reason why I'm testing on a clean install of SMF 1.1.11 with only TP installed (ie no other packages to worry about).
Same feelings here. You can't test every little detail no matter how much you try.

On a fresh install of SMF 1.1.11 and TP 1.0 b5  the error still occurs.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: bloc on April 03, 2010, 10:41:36 AM
Actually, the bulk of testing TP have been on SMF 2.0 versions, since that whats "everyone" is using lol, so it might be that the SMF 1.1 version needs more fixes. I will address this and issue an update asap.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: NeoMorph on April 03, 2010, 03:30:00 PM
Sorry to say that you misunderstood me... this was tested on SMF1.1.11 with TP 1.0 beta 4 and nothing else, then beta 4 removed and beta 5 installed.

I'll do a complete fresh install I think... see how that goes.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: cavedeamon on April 15, 2010, 06:42:46 PM
Any news on this problem?
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: IchBin on April 15, 2010, 07:36:23 PM
It looks like the TPmodules.php file is not getting included. I'm not sure how/where it is supposed to be used. But as a temporary fix you can do this to fix your problem. Open Sources/Profile.php and search for this line:
// Allow the change or view of profiles...

Add before that line this code:
require_once('Sources/TPmodules.php');

I'll file a bug report.

--edit--
Added to the BugTracker (http://www.tinyportal.net/index.php?action=bugtracker;sa=bug569)
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: bloc on April 15, 2010, 08:32:53 PM
Thanks Brad, for adding it to bugtracker. I'll add the fix for it asap.
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: Crip on April 15, 2010, 08:47:57 PM
what is SMS??
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: IchBin on April 15, 2010, 09:39:35 PM
It's meant to say SMF Jeff. :)
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: Crip on April 15, 2010, 10:15:00 PM
LMAO!

Ok B0ss ..ask cuz ..
A guy email me about SMF+SMP+SMS? custom Gaming Dark Theme .. so just curious?

he site used phpbb ... go  figure
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: NeoMorph on April 15, 2010, 10:59:32 PM
Quote from: Crip on April 15, 2010, 08:47:57 PM
what is SMS??

Damn... so I wasn't supposed to be installing TinyPortal on my mobile phone then? :D Perhaps that version will be called TeenyTinyPortal. heh.

I haven't tested the lasted patch from Bloc yet... but seeing as he only added this to the bugtracker today I guess that it's not included in the patch. Darn!

Keep on stomping those bugs Bloc... TinyPortal is freakin amazing!
Title: Re: SMS 1.1.11 TP 1.0 b5 profile broken
Post by: bloc on April 16, 2010, 01:27:09 PM
Yep. All new fixes will soon be collected in a new update just called 1.0 beta 5.2.
Title: Re: SMF 1.1.11 TP 1.0 b5 profile broken
Post by: cavedeamon on April 18, 2010, 08:04:22 AM
Quote from: Crip on April 15, 2010, 08:47:57 PM
what is SMS??
Was doing some online search about sms emails so I guess it got stuck in my head.

I found another error. In TPmodules.php the line 1201 that causes it to go back to profile summery when trying to view more shouts on the tpshout profile page
$context['TPortal']['pageindex']=TPageIndex($scripturl.'?action=profile;sa=tpshoutbox;u='.$memID.';tpsort='.$sorting, $start, $max, '10', true);

needs to be changed to:
$context['TPortal']['pageindex']=TPageIndex($scripturl.'?action=profile;sa=tpshout_profile;tpmodule;u='.$memID.';tpsort='.$sorting, $start, $max, '10', true);
Title: Re: SMF 1.1.11 TP 1.0 b5 profile broken
Post by: Teasar on April 19, 2010, 11:57:00 PM
Are you guys advising to enter the fixes manually or should we wait for the update/patch?

ie. will manually entering the fixes cause problems when it comes to updating?
Title: Re: SMF 1.1.11 TP 1.0 b5 profile broken
Post by: ZarPrime on April 20, 2010, 12:54:31 AM
I'd wait if you can.  The answer to the last question is "It could".  However, if Bloc does it like he did for beta 5-1, you should be able to just upload the new files replacing the old ones.  I can't guarantee that though.

ZarPrime