TinyPortal

Development => Support => Topic started by: Bjørn on May 11, 2005, 02:35:23 PM

Poll
Question: Should the un-install option be removed?
Title: Remove un-install from package manager?
Post by: Bjørn on May 11, 2005, 02:35:23 PM
I am thinking of just removing the un-install option in TP for the next beta(or sooner)...of course it will be un-install routines for the databse tables and such included in the archive, but not to be used in package manager.

I would like to hear your opinions on this. I know most of you probably won't have a problem with it, so its more ALL users, newbies and the likes , I am thinking of here.
Title: Re: Remove un-install from package manager?
Post by: IchBin on May 12, 2005, 01:13:53 AM
Cuz there's so many problems with it?
I don't care either way. Feel free to do what you want it's your mod. :)
Title: Re: Remove un-install from package manager?
Post by: borgBOB on May 13, 2005, 06:28:30 AM
The only problem I see for you Bloc, is if the original files are up-dated by say SMF v1.0.4. I know you work with them, so you know the timelines involved.

But I really like the 'un-install' option and would like to keep it.
I will also respect your decision either way. But there are alot of newbies who would benefit from having the safety net of an automated un-install routine.

p.s. I see you up-dated some smileys for posting, or at least got a new set ;)
Title: Re: Remove un-install from package manager?
Post by: Bjørn on May 13, 2005, 09:12:08 AM
Yes, the automated un-install is neat..but it also breaks a lot because of the small changes other mods make, making the forum inaccesible afterwards.

But I may have a few ideas on how to come around it anyway..

Yes, those smilies are my own. Created a while back...
Title: Re: Remove un-install from package manager?
Post by: resurgence on May 24, 2005, 01:25:17 PM
i would have voted yes, but make copies of the files.

hopefully it'll save them into a separate folder or something. i'm currently reinstalling my test board due to an error on my part.

i was upgrading from 0.5b to 0.65b and then uninstalling 0.65

tsk. oh well. it was extrememly easy to install anyway. :)

*happy to have a test board*  ;)

Title: Re: Remove un-install from package manager?
Post by: warstoke on May 27, 2005, 05:14:24 PM
what about creating a tpuninstall.php or something that would be coded a bit more specificly to remove every thing between the //tinyportal XXXXX tags since thats basicly what i had to do to uninstall now (i flubed my forum lol)
Title: Re: Remove un-install from package manager?
Post by: Bjørn on May 27, 2005, 05:48:10 PM
Thats an idea. Most places I have added comments, so that could work.
Title: Re: Remove un-install from package manager?
Post by: warstoke on June 01, 2005, 02:44:16 PM
as my old c++ teacher would have put it "just be nice and make sure you comment all your work, cause other wise it just looks like chicken scratch to me"
Title: Re: Remove un-install from package manager?
Post by: snowcrash on June 04, 2005, 10:00:10 PM
I remember having uninstall problems on earlier beta of TP via the package manager - crashed the forum

So being sensible, only been using TP on a test forum.

Do you think this issue will be resolved in the next beta?

regards
rhizome
Title: Re: Remove un-install from package manager?
Post by: Bjørn on June 05, 2005, 08:50:13 PM
I hope so. I am re-writing the index.temaplte modifications to be more general , putting ssi call to Load.php instead and so on.

AND making backups just in case, telling admins about it during installing, and during initially un-installing.

So I hope to eliminate the need to remove un-install feature.
Title: Re: Remove un-install from package manager?
Post by: Ciinien on July 18, 2005, 04:29:21 PM
Of course in an ideal world, an uninstaller would be able to de-install anything the installer added. But, as we all know and can appreciate, coding, no matter the language, is rarely performed using the 'ideal paradigm'.

I would say it's not a major thing whether it's there or not. Having said that, if it is left in, warstroke's idea about deleting any code surrounded by //TinyPortal... and // End TinyPortal... comments is a good one. However, there's a down side here: if a tester doesn't surround their code with such comments (some just don't take time to do this), that code will be missed by the uninstaller and bring about spurious, hard to isolate errors.

Another alternative might be (and possible the easiest to implement) is to have the uninstaller create an uninstall folder, backup any files that were changed via a *.mod file (or other supplied user_make_these_changes.file), try to dump the db to an export file, and then send the rest out with the trash man... ;)

As the others agree, however, it's your decision and I'll support you whichever way you decide.

Cheers!
Ci
Title: Re: Remove un-install from package manager?
Post by: Bjørn on July 18, 2005, 08:56:10 PM
Yes, I think I maybe will do that..so the files can be located later on.There are only 3 files that are modified anyway.