TinyPortal

Development => Feedback => Bugs/Errors => Topic started by: sibling chris on May 26, 2009, 03:16:03 PM

Title: [bugtracker] Article & Category icons cannot be selected
Post by: sibling chris on May 26, 2009, 03:16:03 PM

Hi

this problem first appears in beta 3 but is still present in beta 4

article and category icons appear all appear together as one item in the drop-down list box and therefore cannot be changed.

It apperas there is just little bit of malfromed HTML, possibly even just a typo

see here for more detasil and fix
http://www.tinyportal.net/index.php/topic,25578.0.html

thanks
sc
Title: Re: [bugtracker] Article & Category icons cannot be selected
Post by: Nine on June 12, 2009, 03:06:36 PM
There are a few instances of these, and unfortunately I did not keep track of my changes, as I was frantically trying to fix it, but basically it is due to a trailing angular bracket, ">" missing in the closing options statement.

The way to find it is with "</options'" (Note the trailing single quote.)

Ok, so I used my tired mind, and did a diff, and the following was returned:

File:  Themes/default/TPortalAdmin.template.php

1083c1083
<                               echo '<option value="'.$ill['file'].'"' , $ill['file']==$mg['icon'] ? ' selected="selected"' : '' , '>'.$ill['file'].'</option';
---
>                               echo '<option value="'.$ill['file'].'"' , $ill['file']==$mg['icon'] ? ' selected="selected"' : '' , '>'.$ill['file'].'</option>';
1139c1139
<                               echo '<option value="'.$ill['file'].'"' , $ill['file']==$mg['icon'] ? ' selected="selected"' : '' , '>'.$ill['file'].'</option';
---
>                               echo '<option value="'.$ill['file'].'"' , $ill['file']==$mg['icon'] ? ' selected="selected"' : '' , '>'.$ill['file'].'</option>';
1668c1668
<                               echo '<option value="'.$ill['file'].'"' , $ill['file']==$mg['illustration'] ? ' selected="selected"' : '' , '>'.$ill['file'].'</option';
---
>                               echo '<option value="'.$ill['file'].'"' , $ill['file']==$mg['illustration'] ? ' selected="selected"' : '' , '>'.$ill['file'].'</option>';
Title: Re: [bugtracker] Article & Category icons cannot be selected
Post by: bloc on June 16, 2009, 11:03:20 AM
- Missing some closing brackets on forms. Fixed for v1.0 beta 5