TinyPortal

Development => Feedback => Bugs/Errors => Topic started by: Akyhne on May 13, 2009, 01:00:43 PM

Title: [bugtracker] css error for links - missing space before target=
Post by: Akyhne on May 13, 2009, 01:00:43 PM
This is ok. There's a space in '" ' to separate target="_blank":

<a href="'. $scripturl. '?cat='.$cn['IDtype'].'" ' .( $cn['newlink']=='1' ? 'target="_blank"' : ''). '>'.$cn['name'].'</a>';


This is not ok. A space is missing in '"' to separate target="_blank":
<a href="'. $scripturl. '?page='.$cn['IDtype'].'"' .($cn['newlink']=='1' ? 'target="_blank"' : '') . '>'.$cn['name'].'</a>';
There are 5 or 6 of these errors in TPBlocks.template.php
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: G6Cad on May 13, 2009, 01:38:51 PM
cat and page arent the same
What you show as correct are for "cat" and what you show as wrong are for "page"
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: IchBin on May 13, 2009, 02:28:59 PM
cat and page don't need to be the same G6. This person is showing an error in the code. They have given an example of code that is right, and then an example of the code that is wrong. Thanks for pointing that out akyhne, I'll try to jump in and make those changes so they get released in the next beta.
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: bloc on May 13, 2009, 04:22:51 PM
- Missing spaces in the Menu manager block code. Fixed for v1.0 beta4
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: IchBin on May 13, 2009, 05:12:40 PM
Apparently Bloc's $foo is far faster than I could have imagined.... I haven't even opened my editor yet... lol
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: Ken. on May 13, 2009, 05:38:33 PM
Ah... so...

Then...
If Bloc is the $foo Master... do this mean that IchBinâ„¢ is the Grasshopper?  ???
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: bloc on May 13, 2009, 05:41:21 PM
lol, saw it earlier and as it was easy corrected: quickly added. :)
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: IchBin on May 13, 2009, 06:58:12 PM
Quote from: Ken. on May 13, 2009, 05:38:33 PM
Ah... so...

Then...
If Bloc is the $foo Master... do this mean that IchBinâ„¢ is the Grasshopper?  ???
That would indeed be the case. lol
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: Renegd98 on May 13, 2009, 11:53:46 PM
Quote from: IchBinâ„¢ on May 13, 2009, 06:58:12 PM
Quote from: Ken. on May 13, 2009, 05:38:33 PM
Ah... so...

Then...
If Bloc is the $foo Master... do this mean that IchBinâ„¢ is the Grasshopper?  ???
That would indeed be the case. lol

LOL... How you doing grasshopper...   :2funny:
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: Ianedres on May 13, 2009, 11:55:09 PM
but :

$foo != $mightyFoo
Title: Re: [bugtracker] css error for links - missing space before target=
Post by: G6Cad on May 14, 2009, 06:36:32 AM
Ah, sorry, i thought the code were diffrent for diffrent calls. Live and learn  :P