TinyPortal

Development => Support => Topic started by: Bryan on March 07, 2009, 05:06:10 PM

Title: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: Bryan on March 07, 2009, 05:06:10 PM
I searched and believe this earlier topic described the same problem without resolution: http://www.tinyportal.net/index.php/topic,27272.msg217204.html#msg217204
In my case this occurs only in IE, AFAIK.  Using this RSS link: http://www.ajc.com/services/content/feeds/metro/fayette.xml, I get a broken image icon with no properties.  This does not occur in Firefox or Chrome.  I emptied my error log and reloaded the page a couple of times and got the following which seems to be unrelated to this issue:
http://fayettenet.com/forum/index.php?action=tpadmin;sa=blocks
2: Invalid argument supplied for foreach()
File: /home/username/public_html/forum/Themes/default/languages/TPShout.english.php (main sub template - eval?)
Line: 2773

I'm using: SMF 1.1.8, TP 1.0 beta3
My site: http://fayettenet.com

My mod list:
Mod Name     Version     
1.    SMF 1.1.1 Update Package    1.1.1    [ Uninstall ]
2.    SMF 1.1.2 Update Package    1.1.2    [ Uninstall ]
3.    SMF 1.0.11 / 1.1.3 Update    1.1    [ Uninstall ]
4.    SMF 1.0.12 / 1.1.4 / 2.0 b1.1 Update    1.0    [ Uninstall ]
5.    Default Membergroup on Registration    1.1    [ Uninstall ]
6.    Users Online Today Mod    1.4.0    [ Uninstall ]
7.    Prevent Adding Signature Images And Links    1.2    [ Uninstall ]
8.    SMF Sitemap    1.2.1    [ Uninstall ]
9.    FlashChat Integration    1.0    [ Uninstall ]
10.    YouTube BBCode    2.1    [ Uninstall ]
11.    URL Popup    1.0    [ Uninstall ]
12.    Trim Url    1.0.2    [ Uninstall ]
13.    Custom Profile Field Mod    3.17    [ Uninstall ]
14.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ Uninstall ]
15.    Auto Embed Video/Audio Clips    3.1.1    [ Uninstall ]
16.    SMF 1.0.14 / 1.1.6 Update    1.0    [ Uninstall ]
17.    SMF 1.0.15 / 1.1.7 Update    1.0    [ Uninstall ]
18.    SMF 1.0.16 / 1.1.8 Update    1.0    [ Uninstall ]
19.    TinyPortal    1.075    [ Uninstall ]
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: ZarPrime on March 07, 2009, 09:23:17 PM
It's really hard to tell where that is coming from.  I put it into a block on my test site and got the same behavior in IE7, but no other browser.  It looks like something from the feed site is being interpreted incorrectly by the IE browser.  Could just be another of the many quirks that IE exhibits.

I also tried viewing it in the SMF default theme with the same results.  Because of this, it's not a TP issue.  You might try asking this question over on SMF's site to see if anybody else has seen this problem.  Finally, if you know the people who generate this feed, you might ask them about it as well.  I looked at just the feed on an IE page, and I couldn't spot an image that would cause this.

I'm sorry but I can't help you on this one.

ZarPrime
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: Bryan on March 09, 2009, 05:20:28 AM
Thanks, ZarPrime.  There is an image associated with the feed that can be seen if you view just the feed xml in something other than IE (ajc.com in a blue box).  Viewed in IE the image only shows if you subscribe to the feed, but this has no effect on the way the feed is rendered in the block.   I'm pretty sure the image was displayed in TP 0.983 blocks correctly.  I know it displayed in Firefox with TP 0.983 whereas it is missing in TP 1.0 beta3.  I no longer have TP 0.983 running to confirm this in IE though.
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: ZarPrime on March 09, 2009, 12:01:42 PM
Bryan,

Well, I saw that blue icon on the actual feed when I looked at it but it was a different size than what is showing up in IE.  That's why I didn't know for sure that this was the image.

FWIW, I no longer have a TP 0.98 test site so I can't check it in that.  However, I did just stick an RSS block with the feed into a block on TP 1.0.5 beta1 and it still shows the broken image in IE, so this behavior has been around for awhile.

If you think this is a bug in the way an RSS Feed is rendered in a TP RSS block, then, by all means, put this in the bugtracker, but again, it's been like that since at least beta 1.  This I can confirm.  If you do put this in the bugtracker make sure you be as specific as you can about the behavior and reference this topic when you submit the bug.

The other thing you could do is this ...
Put the feed into an iframe inside an article and save it.  The code to do this in a php article would look like this ...

echo '<iframe src="http://www.ajc.com/services/content/feeds/metro/fayette.xml"
height="800" width="100%" Scrolling="yes"></iframe>';


After you have it in the article, change your RSS block to a single article block, save it, and make sure the block is showing the new article.  This will render the feed as it actually looks when viewing it with FF or IE, though it will probably have scroll bars.  At least you wouldn't have the broken image.

If you want to see what this looks like sometime when we're both online, send me a PM and I will enable the block on my site so that you can see what it looks like, but for now, I am turning it off in my site.

ZarPrime
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: Bryan on March 11, 2009, 03:22:25 AM
Thanks ZarPrime.  I tried the article idea but the way IE displays it is with the "subscribe to this feed" box which I'd rather not have.

The issue appears to indeed be associated with the image that some feeds have, which is only visible directly in IE after you "subscribe" to the feed.  BTW, subscribing has no effect on the problem of how the feed is displayed in an RSS block in IE.  In addition to the one I'm using, I found a couple more feeds with the same issue, both with an image/icon at the top:
http://news.cnet.com/2547-1_3-0-20.xml?tag=txt
http://news.bbc.co.uk/rss/newsonline_world_edition/front_page/rss.xml

Feeds that don't have the image display correctly in the block, like these:
http://feeds2.feedburner.com/current_world_news?format=xml
http://www.mortgagefit.com/rss/most-popular.xml

So I guess the problem lies with IE (imagine that).  Unless there is an IE workaround in CSS, I'm at a dead end on this.  I'm sure if I complain to MS they'll get right on fixing it.  ::)
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: ZarPrime on March 11, 2009, 12:59:52 PM
Bryan,

If you're certain that this same feed showed correctly in a TP 0.98 block without the broken image, I'd still consider placing this in the BugTracker so that Bloc can look at it, if you haven't done so already.  There have been a lot of changes to TP since then, and the RSS Block could have been changed.  If it's not a bug in TP, then Bloc will be able to figure that out pretty quick.

ZarPrime
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: Bryan on March 11, 2009, 03:03:05 PM
I went ahead and created a fresh install of SMF 1.1.8 with TP 0.9.8 and then created my feed in a center block, and it does render correctly in both IE and Firefox, with the "ajc.com" logo showing.  So I guess this is a bug in TP 1.0 beta3, and I'll go ahead and enter it in the bug tracker.  You can view the test site at: http://fayettenet.com/test, and I'll leave this site up for a few days.
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: bloc on March 12, 2009, 01:28:00 PM
This was due to a bug in TP RSS block actually..it assumed the image to be just a direct url to the image. Not so, and fixed for beta 4. Although you can apply the fix already:

http://www.tinyportal.net/index.php/topic,28808.msg229832.html#msg229832
Title: Re: TP 1.0 Beta3 RSS Block Broken Image Icon
Post by: Bryan on March 12, 2009, 02:42:01 PM
Thanks Bloc, that fixed it!