TinyPortal

Development => Support => Topic started by: tragidy on February 20, 2009, 09:21:34 PM

Title: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: tragidy on February 20, 2009, 09:21:34 PM
Hi,

I was just testing out the latest revision of TP 1.0.3 Beta and it seems to work great and im happy to see the old FCKeditor replaced/moved :)

However for the first time ever I'm having display issues with blocks that are slightly oversized.

For example in all previous versions the php-resized or allowed and overlay of the block.

Now in 1.0.3B instead of ( adjusting / frambreaking / overlaying ) TP renders the output with a scrollbox on the block.

Sometimes an image is worth thousands of words so here is a small screen shot.

(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fi39.tinypic.com%2F35n8uqe.jpg&hash=e2150b1a15e8bc6ce4ca2674e3fe2bacc2e90029)

(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fi40.tinypic.com%2Futpoy.jpg&hash=9127bf8028888507c2ca892325b5bb0321189824)
Note the scroll bar

I don't know if this would be considered a bug or not, but is there anyway to revert the output back to the old type from previous versions?

Also I miss the plain old " Script Block "

Thanks for any tips on this one!

Edit:
Added image of default theme
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: G6Cad on February 20, 2009, 09:23:59 PM
How does it look in Default Core theme ?  Same issue there ?
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: tragidy on February 20, 2009, 09:25:10 PM
Hi G6,

I'll test it out, however the current theme was written for TP 1.0.X
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: Paranoimia on February 20, 2009, 09:26:16 PM
What browser are you using?

I have noticed this too, but for me it only happens in Opera. I thought it was something to do with that particular browser!
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: G6Cad on February 20, 2009, 09:28:18 PM
Well, we can only give so much support we know of, there for we have to ask how it looks in default theme as thats the theme TP is made for and installes to.

Any custon theme thats not made by Bloc or Crip that have issues, we usually have to send you to the ones that made the themes to sort out the issues if it's only in the custom theme.

As it's a custom theme, we cant say whats wrong or why as we dont have the code for it to look at.
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: tragidy on February 20, 2009, 09:29:46 PM
The issue persist in the default theme.

I use Firefox 3.0.6
Same issue occurs in Internet Explorer 7 & 8

Image below
(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fi40.tinypic.com%2Futpoy.jpg&hash=9127bf8028888507c2ca892325b5bb0321189824)
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: tragidy on February 20, 2009, 09:47:07 PM
Just to add, this is a phpblock
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: bloc on February 20, 2009, 10:07:37 PM
The problem lies in the actual code. you need to be sure the content doesn't overflow. If the content doesn't fit, increase the panel width.

All blocks now have overflow: auto; - to not break out of the panel, this was an error on earlier versions of TP.
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: tragidy on February 20, 2009, 10:11:15 PM
Quote from: Bloc on February 20, 2009, 10:07:37 PM
The problem lies in the actual code. you need to be sure the content doesn't overflow. If the content doesn't fit, increase the panel width.

All blocks now have overflow: auto; - to not break out of the panel, this was an error on earlier versions of TP.

Thanks.

Where in the TPortal may the overflow be reverted to the old type?
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: bloc on February 20, 2009, 10:16:20 PM
Look in TPBlockLayout.template.php and find this code:

if (function_exists($func))
{
if($double)
{
// figure out the height
$h=$context['TPortal']['blockheight_'.$side];
if(substr($context['TPortal']['blockheight_'.$side],strlen($context['TPortal']['blockheight_'.$side])-2,2)=='px')
$nh = ((substr($context['TPortal']['blockheight_'.$side],0,strlen($context['TPortal']['blockheight_'.$side])-2)*2) + 43).'px';
elseif(substr($context['TPortal']['blockheight_'.$side],strlen($context['TPortal']['blockheight_'.$side])-1,1)=='%')
$nh= (substr($context['TPortal']['blockheight_'.$side],0,strlen($context['TPortal']['blockheight_'.$side])-1)*2).'%';
}
echo '<div style="overflow: auto;' , !empty($context['TPortal']['blockheight_'.$side]) ? 'height: '. ($double ? $nh : $context['TPortal']['blockheight_'.$side]) .';' : '' , '">';
$func($block['id']);
echo '</div>';
}
else
echo '<div style="overflow: auto;' , !empty($context['TPortal']['blockheight_'.$side]) ? 'height: '.$context['TPortal']['blockheight_'.$side].';' : '' , '">' , doUBBC($block['body']) , '</div>';


Change the 2 spots where overflow: auto is set, to your preferred state.
Title: Re: TP 1.0.3 - Blocks / Scroll Bar Horizontal
Post by: Xarcell on February 20, 2009, 11:58:42 PM
It's good to leave the TP code as it is though. Like Bloc says, it helps keep from breaking your layout of the site.

The code within the block allows it to be too wide, find a way to shorten it, or increase the panel/block width. This will fix the problem.