TinyPortal

Development => Feedback => Bugs/Errors => Topic started by: espressoguy on October 26, 2008, 06:38:41 PM

Title: [bugtracker] Global Moderator cannot edit Articles
Post by: espressoguy on October 26, 2008, 06:38:41 PM
When a global moderator (or anyone but the Admin User) attempts to save an article, they get an error "Sorry, you aren't allowed to fetch news".  Best way to see this bug is with a fresh pristine install of TP 1.0.6 on top of pristine SMF 1.1.5.  Go through all the steps of creating category and test article (I made the article a front page article).  Then create a user and make the user a Global Moderator.  Log out, log in as the new Global Moderator user and try to edit the article.  When you click "save" to save your edits you get the error and are unable to save the edits.
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: G6Cad on October 26, 2008, 06:49:29 PM
How are the settings set in the membergrup permissions area for the global moderator ? You need to set the permissions for that group in there to handle tinyportal features.
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: espressoguy on October 26, 2008, 11:03:59 PM
Permissions for Global Moderator are all at default except that "TinyPortal>Manage_Articles" is checked.  All other permissions were left at default.
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: espressoguy on October 28, 2008, 03:59:29 AM
Tentative Bugfix for this bug for TP 1.0.5 and 1.0.6.  I have tested and verified that it seems to be working for both versions (5 and 6) and I am posting it here since the bug is such a serious one that disables a very important feature of the software. 

Bugfix for non-Admin users being unable to edit 'Articles':

TP 1.0.5  - in Sources/TPortalAdmin.php:

ORIGINAL CODE:
137     // check permissions
138     if(in_array($tpsub, array('news')))
139         isAllowedTo('tp_news');
140     elseif(in_array($tpsub, array('settings','frontpage','panels','modules','credits','portal','subscriptiongroups')))
141     {
142         isAllowedTo('tp_settings');
143     }

CHANGE TO:
137     // check permissions
138     if(in_array($tpsub, array('news'))) {
139         // isAllowedTo('tp_news');
140    } elseif(in_array($tpsub, array('settings','frontpage','panels','modules','credits','portal','subscriptiongroups')))
141     {
142         isAllowedTo('tp_settings');
143     }


For TP 1.0.6, simply comment-out line 134 of Sources/TPortalAdmin.php:

  131        //isAllowedTo('tp_news');



Thanks to Caarrie for originally posting the fix (http://www.tinyportal.net/index.php/topic,26299.msg213469.html#msg213469) to this bug.

Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: vanityq on March 06, 2009, 02:07:47 AM
is this also applicable with
TP 1.0 beta 3.)?

i still encounter the problem and set my permission setting of TP to enable all
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: espressoguy on March 06, 2009, 02:27:27 AM
Note that the bugtracker log says it is fixed in Beta 3.  But I personally haven't tested it since I first saw it last October.
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: vanityq on March 06, 2009, 02:39:46 AM
im experiencing it now with TP3
i cannot save blocks or even move it

it says an error


++++++++++++++++++++++++++++
An Error Has Occurred!
Sorry, you aren't allowed to fetch news.
++++++++++++++++++++++++++++

is my problem related to this?


Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: IchBin on March 06, 2009, 04:22:39 AM
That is another bug, which is fixed in beta4. :)
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: Buzzrek on March 28, 2009, 07:40:42 PM
Quote from: IchBinâ„¢ on March 06, 2009, 04:22:39 AM
That is another bug, which is fixed in beta4. :)

Is there a work around for the time being? I don't see beta 4 on the downloads page and I'm experiencing the same problem on my site.

edit: I should have included that I am running SMF 1.1.8 and TP v1.0 beta 3

Thanks,
Buzzrek
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: G6Cad on March 28, 2009, 07:42:59 PM
Nope, if the fix is easy, Bloc would have added what and how to fix it, but as he didnt, i assume it's a multiple files change, so no fix
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: Buzzrek on March 28, 2009, 07:44:32 PM
Gotcha. Thanks G6
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: insanemustang on April 08, 2009, 06:18:50 PM
I've got the same issue, running SMF 1.1.8 and TP 1.0 Beta 3.  Should this have been fixed by now?
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: Renegd98 on April 08, 2009, 06:49:37 PM
insanemustang, if you had read thru the post in this thread you would see that it is fixed for beta 4.
Title: Re: [bugtracker] Global Moderator cannot edit Articles
Post by: insanemustang on April 08, 2009, 08:17:50 PM
Renegd98, I read through the post but wanted to be sure.