TinyPortal

Development => Support => Topic started by: Bl4ck on October 14, 2008, 08:39:08 PM

Title: 1.0.6 Beta 2 bug on panels and blocks
Post by: Bl4ck on October 14, 2008, 08:39:08 PM
this is the bug:

http://i33.tinypic.com/wakkuo.png

the bug is in "panels and blocks" section. as you can see the footer image is under the forum and not in the bottom

here is the correct position:

http://i35.tinypic.com/23vkiuv.png

as you can see the bug is only in panels and blocks section.

i try with other themes, but the bug remains.

can anyone confirm??
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: IchBin on October 14, 2008, 08:41:25 PM
You need to bring the problem up with the Author of the theme.
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: Bl4ck on October 14, 2008, 08:53:32 PM
but this is not a theme bug, i try it with other themes but the bug remains
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: IchBin on October 14, 2008, 09:00:58 PM
Then you have something else wrong. That doesn't happen for me at all.
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: Bl4ck on October 14, 2008, 09:39:02 PM
ok thanks  ;D
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: whoesa on October 14, 2008, 11:13:18 PM
Bl4ck is right. I checked all my themes and got this problem in all of them.

Found out that there's a missing </table> in TPortalAdmin.template file at the end of template_main() function (around line 2445):

echo '
</table>
</form>';

}


Should be:

echo '
</table>
</form>';
echo'
</table>';

}
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: IchBin on October 15, 2008, 01:57:33 AM
Weird, I don't see it on any themes....

Would appreciate it if you put that in the bug tracker.
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: whoesa on October 15, 2008, 02:12:20 AM
Ok will do.

You can even see it using Babylon theme or Classic YaBB theme. Just look at the footer when you're on "Panels and Blocks" and check again on any other link in cp panel.
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: Bl4ck on October 15, 2008, 09:40:32 AM
thank you very much Bikken. perfectly working now  ;D ;D :up: :up:
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: Crip on October 15, 2008, 12:43:36 PM
Yep,
I saw this too, applied that </table> fix & it's better now ..... def. a buggy
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: IchBin on October 15, 2008, 02:59:16 PM
Shouldn't there be a </td> and </tr> in there as well since it appears the tables are nested?
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: Crip on October 15, 2008, 03:24:04 PM
..it would seem so yes B0ss.
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: Crip on October 15, 2008, 03:27:35 PM
Quote from: IchBinâ,,¢ on October 15, 2008, 02:59:16 PM
Shouldn't there be a </td> and </tr> in there as well since it appears the tables are nested?

There are a </tr>  <t/d> just above, but it made need those last two as well ?
Title: Re: 1.0.6 Beta 2 bug on panels and blocks
Post by: whoesa on October 15, 2008, 04:00:15 PM
Quote from: IchBinâ,,¢ on October 15, 2008, 02:59:16 PM
Shouldn't there be a </td> and </tr> in there as well since it appears the tables are nested?

Yes, after having another decent look at it, it should indeed be:

echo '
</table>
</form>';
echo '
</td>
</tr>
</table>';
}


Also while i was looking in this file, i also noted two other smaller errors (around line 2249) :

<td class="smalltext" align="center"2">'.$txt['tp-delete'].'</td>
<tr>';


should probably be:

<td class="smalltext" align="center">'.$txt['tp-delete'].'</td>
</tr>';