Hello all you users of TP and Pretty URLs (if there are any of you that is...)
What TP URLs would you like to be prettified? I notice that articles now use ?page=articletitle, which could easily be converted to http://domain.com/page/articletitle/, would you like that? Is there anything else that could be changed? All suggestions are welcome!
It looks as though the current Pretty URLs mod intereferes with the functioning of TinyPortal. Someone the other day was unable to use one of the textareas to edit a block and it was the direct result of the mod. I wrote something for someone a while back which required the passing of a variable to an article through a link. Since he used the mod, the variable didn't pass and the code didn't work.
Unless these things can be worked out, I would suggest that people using TP not use the Pretty URLs.
Yeah I'm currently looking into that now. I'm pretty sure the problem is on TP's end, and if I can track it down I'll let you all know so it can be fixed.
What about the passing of variables? As a coder, I hate the idea of going to all the work to write custom code and then find out that a mod has made it impossible for the code to work.
Passing variables should be fine. Can you show me an example of what doesn't work?
Well, I had some code for a "Hall of Fame" to go with the awards mod. I wrote a block that listed 5 random recipients of a random award. Then the user wanted a "More" link to an article that listed all of the recipients of that award. I needed to pass the award number to the article. I used index.php?page=#;award=# and then used $_GET['award'] to determine which award to search for.
The only reason that we could figure out that it didn't work was because of the SEO mod.
How would I pass a variable in a URL with your Pretty URLs?
I think your bbcode got corrupted there...
Yep. :) I fixed it.
Nope... it's still inserting a list...
Should be this yes?
I used index.php?page=[#];award=[#] and then used $_GET['award'] to determine which award to search for.
Can you provide a full example rather than one with placeholders?
Did you try using $_REQUEST['award']?
That URL shouldn't even have been touched by Pretty URLs...
Sorry.
index.php?page=4;award=5
QuoteDid you try using $_REQUEST['award']?
No. I tried using $_GET['award'] which is what I always use for variables passed in a URL.
QuoteThat URL shouldn't even have been touched by Pretty URLs...
Well, it didn't work. Although it could have been a different mod. I stay away from that kind of mod myself.
Anyway, until the problem with the editor is worked out, I definitely would not suggest that people use both TP and your mod.
QuoteNo. I tried using $_GET['award'] which is what I always use for variables passed in a URL.
Well you should try $_REQUEST too. There's usually little reason to specify how the variable is coming.
QuoteAnyway, until the problem with the editor is worked out, I definitely would not suggest that people use both TP and your mod.
Yeah... working on that.
I've installed TinyPortal but I can't reproduce the editors problem. I can use the rich text editors fine. Is it only a problem in custom themes?
It may be. Do a search for SEO and you might find the topics where someone had a problem. There was one quite recently -- within the past week IIRC.
I found some extra problems. For anyone who's interested, I've made a new snapshot on the download page that fixes them.
Quote from: Dannii on May 09, 2008, 05:09:08 PM
Hello all you users of TP and Pretty URLs (if there are any of you that is...)
What TP URLs would you like to be prettified? I notice that articles now use ?page=articletitle, which could easily be converted to http://domain.com/page/articletitle/, would you like that? Is there anything else that could be changed? All suggestions are welcome!
Maybe you can use:
http://www.domain.com/article-title
That would only be possible if both actions, boards and topics used the query string (ie, TinyPortal is the only pretty thing.) Currently domain.com/text/ is already overloaded and used for both actions and boards, trying to distinguish between three types of pages would be chaotic.
If that's what you want it's definitely not hard.
I'm not sure what post you're referring to -- what "That" means at the start of your post -- but from context it seems that you might be referring to my comment from last May where I said
Quote
I wrote something for someone a while back which required the passing of a variable to an article through a link. Since he used the mod, the variable didn't pass and the code didn't work.
I'm a programmer. To me, whether URLs look nice or not is incredibly unimportant. They are a tool I can use in my programming. If I were to build a bookcase, I wouldn't care what color the handle of my hammer was. If people want to have pretty URLs, that's fine, but I will require that they tell me off the bat when they ask for complicated custom programming so that I'll know whether what they want is possible or not.
If I am following this correctly, it would seem that if you wanted to 'pretty' up the URLs, you would 1) have to include a function call to the SEO code to generate each and every URL in your custom script with your variables to comply with its expectations, or 2) have the SEO script read any and all variables that are passed, and automatically append to the generated URL.
I use many articles on my site that require the passing of variables through the URL, and though I would like to have higher rankings in the search results, the functionality of the article script is priority.
But, I think if the SEO used method 2, it would help with future compatibility with other mods/scripts- if I comprehend all this correctly.
QuoteI'm not sure what post you're referring to -- what "That" means at the start of your post -- but from context it seems that you might be referring to my comment from last May where I said
Sorry, the "that" was referring to using pretty URLs for TP articles and nothing else.
And did you ever get that working? I suggested using $_REQUEST rather than $_GET.
Quote from: Ianedres on August 10, 2008, 03:28:24 AM
If I am following this correctly, it would seem that if you wanted to 'pretty' up the URLs, you would 1) have to include a function call to the SEO code to generate each and every URL in your custom script with your variables to comply with its expectations, or 2) have the SEO script read any and all variables that are passed, and automatically append to the generated URL.
I use many articles on my site that require the passing of variables through the URL, and though I would like to have higher rankings in the search results, the functionality of the article script is priority.
But, I think if the SEO used method 2, it would help with future compatibility with other mods/scripts- if I comprehend all this correctly.
It already does this. I don't see what articles would be any different to any other SMF action.
QuoteAnd did you ever get that working?
No. I didn't work on it any more. I was writing it for someone else and he just gave up.
$_REQUEST doesn't make any difference at all.
For referense, Bloc have plans to make some sort of SEO compatibe TP in a future release of TP.
Cant say when or in what version, but it is planed .
Quote from: JPDeni on August 13, 2008, 02:51:08 AM
No. I didn't work on it any more. I was writing it for someone else and he just gave up.
$_REQUEST doesn't make any difference at all.
So what's the exact code for the article you were using?
And did you happen to manually change the rewrite rules and remove the QSA?
QuoteSo what's the exact code for the article you were using?
Not a clue. This was months ago.
QuoteAnd did you happen to manually change the rewrite rules and remove the QSA?
No.
Okay, well as I haven't experienced any problems like that and you can't explain it in any detail, I'll assuming it's fixed and there aren't any compatibility issues now.
Has anyone gotten this to work with tp articles. i seem to have everything else working ok now in .98 except articles :(
As I said else where the extra package has a rule for it, though you'll need to upgrade to the 0.9 snapshot if you haven't already, and it really would be best to use TP 1.0.5.