TinyPortal

Development => Feedback => Bugs/Errors => Topic started by: Oldiesmann on January 16, 2006, 12:16:47 AM

Title: [Bug/Fix] Problems with new help system...
Post by: Oldiesmann on January 16, 2006, 12:16:47 AM
Found a minor bug with TP in regards to the new help system...

The new help system generates URLs like .../index.php?action=help;page=index

However, because TP just checks for a "page", you get errors:

QuoteYou have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'index AND off=0 AND approved=1 LIMIT 1' at line 1
File: /.../Sources/TPortal.php
Line: 313

It's an easy fix though...

Sources/TPortal.php

Find
// view single article?
$mypage='';
if(isset($_GET['page'])){


Replace
// view single article?
$mypage='';
if(isset($_GET['page']) && !isset($_REQUEST['action'])){
Title: Re: [Bug/Fix] Problems with new help system...
Post by: feline on January 16, 2006, 09:21:17 AM
that is only in TP 0.75 .. and that is not a bug of TP .. it's incompatibility to new RC2.

Fel
Title: Re: [Bug/Fix] Problems with new help system...
Post by: Oldiesmann on January 16, 2006, 02:35:34 PM
I'm running TP 0.8, so it's not just an issue with 0.75. I see it as a bug because SMF generally isn't coded to be completely compatible with existing mods...
Title: Re: [Bug/Fix] Problems with new help system...
Post by: IchBin on January 16, 2006, 02:37:46 PM
What are you doing over here Oldiesmann? Get back to work on SMF+G2!!! j/p :P
Title: Re: [Bug/Fix] Problems with new help system...
Post by: Oldiesmann on January 16, 2006, 02:39:09 PM
I will get back to work on that when I have more time to work on it... I've been extremely busy lately :)