TinyPortal

Development => Feedback => Bugs/Errors => Topic started by: Dragooon on November 08, 2007, 05:47:52 PM

Title: A very annoying error in TP DL Manager.
Post by: Dragooon on November 08, 2007, 05:47:52 PM
I don't know if it is posted before or not, But I found a Very annoying error.
Whenever a user submits a download and if it is not approved and you try to download it as a Admin, or someone who is allowed to manage Download Manager it just gives a error saying "You are Not allowed to access this section or something",
And Here is a solution I came up with
In /Sources/TPdlmanager.php
In TPdownload() function find,
// can we actually download?
if($show==1){
(Or Something similar as I am copying this from a modified TPdlmanager.php
And replace it with
// can we actually download?
if($show==1 || allowedTo('tp_dlmanager')){

It is obvious that if someone is allowed to manage Downloads he should be automatically able to download the files.
Make sure to clear your cache before trying to download this again.

Its not in my intension to act Rude or angry, if you might be thinking I am acting rude or angry you are wrong here :).
Title: Re: A very annoying error in TP DL Manager.
Post by: bloc on November 08, 2007, 09:32:48 PM
Actually a good suggestion :) , I will add this in.
Title: Re: A very annoying error in TP DL Manager.
Post by: Dragooon on November 09, 2007, 02:04:35 AM
Can you also do like, if someone is also allowed to manage downloads, he can automatically see every category and files or Am I missing something here?
Title: Re: A very annoying error in TP DL Manager.
Post by: bloc on November 09, 2007, 08:59:35 AM
He should do that already, if the permission is there.
Title: Re: A very annoying error in TP DL Manager.
Post by: Dragooon on November 09, 2007, 03:07:33 PM
Then I am missing something here :P
Title: Re: A very annoying error in TP DL Manager.
Post by: bloc on November 09, 2007, 08:56:37 PM
Hm you may be onto something...access to a Download folder is determined from membergroup. But if a member is in a membergroup that isn't listed within the folder access range, he won't see it. But he will eb able to see it in admin. This is def. a bug if works like that.
Title: Re: A very annoying error in TP DL Manager.
Post by: Dragooon on November 11, 2007, 03:45:56 AM
But when not approved, There is no folder there which anyway makes it not possible to download.
I believe it can be a good idea to make it stop its permission checks if the user is allowed to manage downloads. Saves many bugs.
Title: Re: A very annoying error in TP DL Manager.
Post by: bloc on November 11, 2007, 09:23:38 AM
I have fixed this in TP 1.0 at least.
Title: Re: A very annoying error in TP DL Manager.
Post by: Dragooon on November 11, 2007, 12:26:43 PM
Thats good :).