TinyPortal

Development => Support => Topic started by: eldacar on December 23, 2005, 01:32:48 PM

Title: A few comments
Post by: eldacar on December 23, 2005, 01:32:48 PM
Is there a reason why the menu uses a lot of &nbsp;'s rather than using a <ul>? using a list would seem more logical and also more.. is semantical the word?

Also, when editing a phpblock, &nbsp;'s are changes to normal spaces, which looses the formating when you save.

It would be nice to be able to select whether an article is a normal one or a php article. Also some display as to which it is. (I may have missed it if there is one)

Lastly, I just installed TP0.75 on my forum and it's going great! I don't want it visible in the normal theme (only in the default SMF theme) until I've finished, so I hacked it this way. If anyone is interested please use this code.
elseif (empty($_REQUEST['action']))
{
                // Action and board are both empty... BoardIndex!
                if (empty($board) && empty($topic))
                {
                        if ($settings['theme_id'] == 1) { require_once($sourcedir . '/TPortal.php');
                        return 'TPortal'; } else{
require_once($sourcedir . '/BoardIndex.php');
                        return 'BoardIndex'; }
                }
Title: Re: A few comments
Post by: IchBin on December 23, 2005, 03:31:53 PM
I'll let Bloc comment on why it's coded the way it is, but I think the word you're looking for is symetrical?
Title: Re: A few comments
Post by: bloc on December 23, 2005, 09:26:12 PM
I could use <ul> instead of &nbsp;...its just for demostration of the indenting system. You would need some css for the list though, as just adding nested ul's to follow the multiple indentation will push it it quite a bit to the right. So using spaces is just a quck way of showing a tree-structure. A theme can use the "positions" to show it any way it like really.

Semantical css-based theme is what i am working on now actually. If it will move over to TP is still unsure. The challenges of getting everything over to the stylesheet will keep me occupied for some time. ;)

Phpblock should always have &nbsp; inside a echo statement, not on its own..it should retain them then?

You can't convert a article from html to php..but you can start either one from scratch. Currently there isn't a indication of which is which..but the editor knows of course. I will add some markers for it in the overview of articles.

The code for checking the theme is neat. :) It will just like that(with a different setting of course) I will add the option of showing the portal as a separate call..and forum as "frontpage", or the normal TP "frontpage".
Title: Re: A few comments
Post by: eldacar on December 24, 2005, 05:45:45 AM
&nbsp;'s inside an echo statement are lost when you edit it again.

And I mean semantics, which is supposed to be the idea of xhtml - The visual formatting should be separate from the content. Lists are obviously a lot better for this than having extra spaces, but if that's actually controlled by the theme then the whole issue doesn't matter much. It wouldn't be hard to change the theme to using lists.