TinyPortal

Elkarte TinyPortal => Elk TinyPortal Issues => Topic started by: tino on January 05, 2021, 06:55:34 AM

Title: Elkarte TinyPortal Testing
Post by: tino on January 05, 2021, 06:55:34 AM
Hi All,

The latest copy of TinyPortal for Elkarte is available here;

https://tinoest.co.uk/forum/index.php?page=ElkTinyPortal

I would appreciate it if some of you can test it, obviously if you're using SMF and have no wish to change then it isn't for you.

Can you raise any issues you find in this topic, or on Github and I shall work through them all. 

tino
Title: Re: Elkarte TinyPortal Testing
Post by: Oldiesmann on January 24, 2021, 02:29:03 PM
I've still got an ElkArte test site... I'll put TP on it later and play with it some :)
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on January 24, 2021, 04:01:48 PM
Hi Oldies, not sure what versions of Elkarte it's compatible with, tino did say at some point. I'm sure he'll let us know if that's an issue.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 24, 2021, 05:15:24 PM
It’s compatible with Elkarte 1.1.x, I’m currently working on a new branch compatible with 2.0.x
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on January 30, 2021, 12:52:47 AM
Finally got around to installing TinyPortal for Elkarte.

- First thing I noticed are the text formatting issues in de admin area: setting captions are printed in Bold, due to the font-weight: 600; in the css for .settings label. I personally find that a bit invasive...

See that some entries are not in bold, because I did not 'label' all fields...
Hmm, might be something I will pick up in SMF to prevent similar issues with SMF themes. Not a big issues, just does not look good...

- Second thing I noticed is that the tooltips don't work...

- Block styles definately need cleaning up: the block styles that made some sort of sense in SMF now all look the same in the Elkarte theme

- Check the style in tp-style.css

dl.tptitle dt {
    float: left;
    width: 40%;

The 40% should be changed to 39%: the Elkarte theme does not like this. See the "Edit Article" Title and Short name section what I mean...

(I'll update this in SMF too, maybe some SMF themes will do the same...)

- I cannot create a new Article Category from the list page.

Results in error: "The database value you're trying to insert does not exist: item_type"

- Trying to upload an article icon results in error: Call to undefined function fatal_error()

In general I noticed that the Elkarte theme indicates some layout errors in the TinyPortal templates, that SMF 2.0 and 2.1 did not show.  :doh:
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 30, 2021, 03:16:10 AM
Thanks for testing, I’ll look at those errors.

The block templates is on my list of things to fix, I made a stab at in the development branch. I think also the category error is fixed in that one.

I don’t mind the bold on the labels, I was going to move them all across to that. I’ll add a subclass so they can be styled though.

Thanks again for testing.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on January 30, 2021, 04:05:09 AM
No problem, if you don't mind I can submits some of the layout stuff to your development branch...

It would be nice to keep SMF and Elk branch a little bit in sync, even though with all your changes to the Elk version there is not a lot of synergy left...

Mind you: if youhave fixes / improvements that we can leverage in the SMF version (like for example the block layouts) please let me know ...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 30, 2021, 05:38:35 AM
No problem, if you don't mind I can submits some of the layout stuff to your development branch...

It would be nice to keep SMF and Elk branch a little bit in sync, even though with all your changes to the Elk version there is not a lot of synergy left...

Mind you: if youhave fixes / improvements that we can leverage in the SMF version (like for example the block layouts) please let me know ...

You’re more than welcome to contribute against it. Styling isn’t my thing. I’ve only got the article logic to change then, I’ll be adding the downloads, menu and gallery sections.

It’s mostly the same, just moved around a fair bit. If I’m honest it’ll also work ok SMF with minor changes for the styles. It’s I feel cleaner on the ones I have moved across, but that might be as I know the code in more detail now.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on January 30, 2021, 05:40:36 AM
Gallery sections?
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 30, 2021, 06:05:21 AM
Gallery sections?

Yeh, I’ll merge what I did for YAPortal into TinyPortal and tidy up the display side. It’ll also take the download logic from there largely with the front section taking bits from TinyPortal.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 30, 2021, 01:54:42 PM

- I cannot create a new Article Category from the list page.

Results in error: "The database value you're trying to insert does not exist: item_type"


That was in a different place to I expected but is now fixed, along with the clone button.

I'll work on the other issues you raised later.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on January 31, 2021, 10:10:38 AM
Just testing the development branch again, not sure how stable that is supposed to be?
Hmmm: I uninstalled and removed all data then reinstalled, and now it is looking better ...

Couple of observations:

Main admin page for Tinyportal gone
Is that on purpose?

Submit a new article:
Article is saved, but returns with:

An Error Has Occurred
Unable to load the 'main' template.

Cannot create article in a block
Editing a block and press save then assign the article: the selected option is not saved..

Aftre that the blocks cannot be edited: An Error Has Occurred
Database error, given array of integer values is empty. (cat)

Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on January 31, 2021, 10:23:31 AM
Trying to change block sequence:
An Error Has Occurred
call_user_func() expects parameter 1 to be a valid callback, function 'template_tparticles' not found or invalid function name
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 31, 2021, 11:13:27 AM
Just testing the development branch again, not sure how stable that is supposed to be?
Hmmm: I uninstalled and removed all data then reinstalled, and now it is looking better ...

Couple of observations:

Main admin page for Tinyportal gone
Is that on purpose?


Do you mean the main page with the icons? I didn't see the need for it myself.

Submit a new article:
Article is saved, but returns with:

An Error Has Occurred
Unable to load the 'main' template.

Cannot create article in a block
Editing a block and press save then assign the article: the selected option is not saved..

Aftre that the blocks cannot be edited: An Error Has Occurred
Database error, given array of integer values is empty. (cat)

I'm working on the Article logic, it's not finished yet, it's in a half changed state.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on January 31, 2021, 11:15:27 AM
I figured that much. I’ll leave you to it then ... give me a shout when it’s testable...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 31, 2021, 11:20:05 AM
Trying to change block sequence:
An Error Has Occurred
call_user_func() expects parameter 1 to be a valid callback, function 'template_tparticles' not found or invalid function name

That's sorted, my template changes got lost somewhere for that one.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 04, 2021, 06:56:05 AM
The above should all be fixed now, although the template error's probably still remain. I need to look at the block banner styling but not sure where to start.

The latest is available here https://github.com/Tinyportal/ElkTP/archive/master.zip

I will be packaging up a zip for RC2 later this week.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 04, 2021, 01:16:05 PM
Just installed it and played around a bit: created a category, created an article, put it on the frontpage. All working OK.

Did you put the TinyPortal back in the original place? Now it is pretty much what I wanted for SMF: both options avialable...

I am already missing the menu manager: no option to put an article or category page in the menu  :(

I will spend some more time on it in the weekend and report back...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 04, 2021, 01:32:58 PM
Just installed it and played around a bit: created a category, created an article, put it on the frontpage. All working OK.

Did you put the TinyPortal back in the original place? Now it is pretty much what I wanted for SMF: both options avialable...

I am already missing the menu manager: no option to put an article or category page in the menu  :(

I will spend some more time on it in the weekend and report back...

I used the hide menu option so you can hide it if you wish, otherwise it’s in both places. Which I preferred.

I’ll no doubt add the menu back in, along with the other parts as I mentioned before.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 04, 2021, 01:47:36 PM
Would you be willing to make those changes on the SMF version too? ( move to admin section I mean?)

In exchange I’ll give the ELK version some good beta testing for you...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 04, 2021, 01:55:50 PM
Would you be willing to make those changes on the SMF version too? ( move to admin section I mean?)

In exchange I’ll give the ELK version some good beta testing for you...

Considering the amount of time I’ve spent on TinyPortal for SMF I find that offer quite offensive.

If I get the time I’ll look at it, it’s quite in depth though and requires a fair amount of changes, having the menu at the top point to the admin sections once changed is the easy part.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 04, 2021, 02:17:22 PM
No need to be offended, I know how much time you put in  (I put in quite a bit myself). No is also an acceptable answer.

I am going to support Elk beta testing regardless...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 04, 2021, 02:46:30 PM
If I do find the the time, I will port it back. The issue is the changes were made easier by everything else I’ve changed along the way, which is about 20 hours dev work to get it to where it is now.

There might be a short cut I can use, but I’m not sure.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 04, 2021, 02:49:10 PM
Yeah, I understand : the code base is already quite different.... never mind
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 04, 2021, 02:55:40 PM
Yeah, I understand : the code base is already quite different.... never mind

Interestingly porting what I have for Elkarte now back to SMF is not as difficult. It just lacks the menu, downloads and shoutbox  ::)
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 04, 2021, 03:07:25 PM

Adding this to Integrate.php might work...

Code: [Select]
    public static function hookAdminAreas(&$adminAreas) {{{
        global $txt;

        loadLanguage('TPortal');
        loadLanguage('TPortalAdmin');

        $adminAreas['tpadmin'] = array (
            'title' => $txt['tp-tphelp'],
            'permission' => array ('admin_forum', 'tp_articles', 'tp_blocks', 'tp_settings'),
            'areas' => array (
                'tpsettings' => array (
                    'label'       => $txt['tp-adminheader1'],
                    'function'    => 'TPortalAdmin',
                    'file'        => $sourcedir.'/TPortalAdmin.php',
                    'permission'  => array ( 'admin_forum', 'tp_settings' ),
                    'subsections' => array (
                        'settings'      => array ( $txt['tp-settings'] ),
                        'frontpage'     => array ( $txt['tp-frontpage'] ),
                    ), 
                ), 
                'tparticles' => array (
                    'label'       => $txt['tp-articles'],
                    'function'    => 'TPortalAdmin',
                    'file'        => $sourcedir.'/TPortalAdmin.php',
                    'permission'  => array ( 'admin_forum', 'tp_articles' ),
                    'subsections' => array (
                        'articles'      => array ( $txt['tp-articles'] ),
                        'categories'    => array ( $txt['tp-tabs5'] ),
                    ), 
                ), 
                'tpblocks' => array (
                    'label'       => $txt['tp-adminpanels'],
                    'function'    => 'TPortalAdmin',
                    'file'        => $sourcedir.'/TPortalAdmin.php',
                    'permission'  => array ( 'admin_forum', 'tp_blocks' ),
                    'subsections' => array (
                        'blocks'        => array ( $txt['tp-blocks'] ),
                        'panels'        => array ( $txt['tp-panels'] ),
                    ), 
                ), 
            ), 
        ); 
       
    }}}

And this to the hook's array at the top

Code: [Select]
'admin_areas'                       => 'TinyPortal\Integrate::hookAdminAreas',
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 05, 2021, 12:43:37 AM
Wow, that is surprisingly simple!

The basics work, just getting some errors that I need to look into, but I am sure I'll figure that out..

Type of error: Undefined
8: Undefined variable: sourcedir
https://test2.fjr-club.nl/index.php?action=admin;area=logs;sa=errorlog;desc
/home/deb77453/domains/fjr-club.nl/public_html/test2/TinyPortal/Integrate.php (Line 972)

Menu icons are not there yet and I may need to put the menu mamager, download an shoutbox links back...

that will be later, now I need to get to my paid work...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 05, 2021, 06:40:59 AM
Wow, that is surprisingly simple!

The basics work, just getting some errors that I need to look into, but I am sure I'll figure that out..

Type of error: Undefined
8: Undefined variable: sourcedir
https://test2.fjr-club.nl/index.php?action=admin;area=logs;sa=errorlog;desc
/home/deb77453/domains/fjr-club.nl/public_html/test2/TinyPortal/Integrate.php (Line 972)

Menu icons are not there yet and I may need to put the menu mamager, download an shoutbox links back...

that will be later, now I need to get to my paid work...

$sourcedir is as I forgot to declare it as a global.

I think the issues will be with the admin section disappearing when you click on another link. It might be as simple as replacing all the instances of action=tpadmin with action=admin;area=tpadmin;

I’ll have a look in to it later if I get the chance.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 06, 2021, 03:22:06 PM
Im just rewriting the final parts of the back end code and then should be finished with the first pass, although this last update is quite major and removes any kind of semblance with what was once TinyPortal as everything will be in its own namespace away from Elkarte, which means it will work with Elkarte 2.0 :)

Then it’s the templates and changing the code to use css grids and or flex.

Menu should be back in sometime next week, although it’s nothing like the TinyPortal one in its looks. Functionality is similar although it will be for any internal menu or a list with sub menu items.

Gallery is then on my list, as mentioned before and Downloads will follow soon after as the code will be pretty much the same.

Then I’ll look at the shoutbox, after all that I’ll be done and it should be stable and at a releasable state. ( not that it doesn’t work now )

Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 06, 2021, 06:04:46 PM
Im just rewriting the final parts of the back end code and then should be finished with the first pass, although this last update is quite major and removes any kind of semblance with what was once TinyPortal as everything will be in its own namespace away from Elkarte, which means it will work with Elkarte 2.0 :)

Then it’s the templates and changing the code to use css grids and or flex.

Menu should be back in sometime next week, although it’s nothing like the TinyPortal one in its looks. Functionality is similar although it will be for any internal menu or a list with sub menu items.

Gallery is then on my list, as mentioned before and Downloads will follow soon after as the code will be pretty much the same.

Then I’ll look at the shoutbox, after all that I’ll be done and it should be stable and at a releasable state. ( not that it doesn’t work now )

I'll be giving this a test when ready tino.  Shame the sub menu's didn't make it into TP for SMF, that was much needed imo.  But sounds like ElkTinyPortal is comming along nicely.  ;)
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 07:46:55 AM
Here is the latest RC release before I add the menu and other features back in. It should be stable but I expect that there will be some issues. Also I haven't provided an upgrade path from RC1 to RC2 so there might be some issues due to that mainly to do with the images and folder structure changing.

https://github.com/Tinyportal/ElkTP/releases/tag/V1.0.0-RC2
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 09:14:10 AM
Will need to check what I did, but at the moment it broke stuff.  I have this error in log,

Type of error: Undefined
Exception: Call to undefined function TinyPortal\Model\is_countable()
http://elkarte2.test/index.php?
File: C:/laragon/www/elkarte2/TinyPortal/Model/Subs.php
Line: 1617
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 09:35:21 AM
I had uninstalled RC1 (with the remove all data option) prior to trying RC2.

Also had to delete the RC1 package before it would let me upload RC2 because of this,

"The package you are trying to upload already exists on the server under file name: ElkTP-V1.0.0-RC1.zip"
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 09:36:13 AM
Will need to check what I did, but at the moment it broke stuff.  I have this error in log,

Type of error: Undefined
Exception: Call to undefined function TinyPortal\Model\is_countable()
http://elkarte2.test/index.php?
File: C:/laragon/www/elkarte2/TinyPortal/Model/Subs.php
Line: 1617

I need to up the minimal php version, that’s version 7.3 or greater as I removed the polyfill.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 09:38:07 AM
I had uninstalled RC1 (with the remove all data option) prior to trying RC2.

Also had to delete the RC1 package before it would let me upload RC2 because of this,

"The package you are trying to upload already exists on the server under file name: ElkTP-V1.0.0-RC1.zip"

I don’t know how you got that? As the latest link calls it RC2. The original in the first post  is still RC1 as I’ve not released RC2 formally yet.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 09:41:52 AM
It was actually running the very first version I was trying from a few weeks ago.  ???

My local is running PHP: 7.2.19
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 09:45:24 AM
It was actually running the very first version I was trying from a few weeks ago.  ???

My local is running PHP: 7.2.19

I don’t intend to support less than php 7.3 as all other php versions are EOL.

I can create a polyfill package for it ( I use one on my site ) but I don’t really want to have it as default as it just increases my testing time which is already limited.

Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 09:46:59 AM
Add this to the bottom of Load.php if you want it to work on PHP7.2

https://github.com/PHPWatch/is_countable-polyfill/blob/master/src/is_countable.php
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 09:53:42 AM
Add this to the bottom of Load.php if you want it to work on PHP7.2

https://github.com/PHPWatch/is_countable-polyfill/blob/master/src/is_countable.php

Thanks I will give that a try.  I'd rather not update my local atm, as I'm in the middles of something, and I just know I'd lose it.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 09:57:38 AM
You should really update it to the latest php 7.2 I think it’s php 7.2.34.

Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 10:03:40 AM
Add this to the bottom of Load.php if you want it to work on PHP7.2

https://github.com/PHPWatch/is_countable-polyfill/blob/master/src/is_countable.php

That worked. Thanks.  O0 Now time to play.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 10:12:14 AM
Ooh, what happened to the TP admin page with the icons, it was there last time I tried it?
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 07, 2021, 10:21:37 AM
It’s gone (I already asked)
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 10:31:36 AM
It’s gone (I already asked)

I haven't tested it since RC1 so until today wasn't aware it had gone. Obviously I knew the admin had moved into the ElkArte admin section because it was like this in the first I tried, but then you could get back to the original TP admin page from there. You can't now.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 10:31:49 AM
Ooh, what happened to the TP admin page with the icons, it was there last time I tried it?

I didn’t see what it added. It’s not completely removed (yet) but as you can access everything from the top menu or the side. Then I see no need for it.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 10:40:06 AM
I always found it quite a nice touch, it's been there in TP since birth, so got rather attached to it.  ;)
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 07, 2021, 01:37:41 PM
Just installed the latest version, but it does not seem to find any texts...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 02:07:47 PM
Just installed the latest version, but it does not seem to find any texts...

It 'should' do.

Or are you using non english ones? Although it should fall back to the old location.

If you go to TinyPortal\ModelSubs.php and change the loadLanguage function to this;

Code: [Select]
    public function loadLanguage($template_name, $lang = '', $fatal = true, $force_reload = false) {{{
        global $user_info, $language, $txt;
       
        if ($lang == '') {
            $lang = isset($user_info['language']) ? $user_info['language'] : $language;
        }
           
        foreach( array ( $lang, 'english' ) as $l) {
            $filePath = BOARDDIR . '/TinyPortal/Views/languages/'.$l.'/'.$template_name.'.'.$l.'.php';
            if(file_exists($filePath)) {
                require_once($filePath);
                return $lang;
            }
        }

        return \loadLanguage($template_name, $lang, $fatal, $force_reload);
       
    }}}

It might work correctly.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 07, 2021, 02:17:50 PM
Just removed the old install completely and installed the new package
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 03:02:35 PM
Methinks I'll start again with a fresh install of ElkArte before trying this again.   
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 03:35:00 PM
OK, clean install of ElkArte and ElkTinyPortal RC2

Straight out of the box and without changing anything, I'm getting a error on page when adding a html/javascript block,

"Call to undefined method TinyPortal\Model\Subs::get_boards()"
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 03:44:52 PM
OK, clean install of ElkArte and ElkTinyPortal RC2

Straight out of the box and without changing anything, I'm getting a error on page when adding a html/javascript block,

"Call to undefined method TinyPortal\Model\Subs::get_boards()"

Must of missed that one when converting them across. It should be TPSubs::getInstance()->boards()
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 04:09:13 PM
There will probably be a few of those around, I tried to change most but I’m sure I’ve missed more than a few.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 07, 2021, 04:12:57 PM

Must of missed that one when converting them across. It should be TPSubs::getInstance()->boards()


Thanks.

Just about to clean install ElkArte again, my last install (ElkArte, not TP) did something strange.  Or should I say I did.  :-[ Seems if it takes a while to install and you happen to click the continue button while you're waiting it adds duplicate membergroups. Think this is a bug in ElkArte.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 05:43:34 PM
Just rebuilt the tag with the bug fixes in for what you raised.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 07, 2021, 05:44:03 PM
Just removed the old install completely and installed the new package

Did that resolve the language file issue?
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 08, 2021, 01:35:50 AM
Just removed the old install completely and installed the new package

Did that resolve the language file issue?

Installed the updated package and the language issue is now solved.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 08, 2021, 12:53:58 PM
Another one for you tino.

Clicking the View Article link gives error on page, only if the article is not Approved, or Not Active. It has to have both set to Approved and Active before you can view the article.

Call to undefined function TinyPortal\Controller\TP_error()

And these in log,

ype of error: General
Unknown Error: Non-static method TinyPortal\Model\Subs::chain() should not be called statically
http://elkarte4.test/index.php?action=admin;area=tparticles;sa=editarticle;article=1
File: C:/laragon/www/elkarte4/TinyPortal/Model/Article.php
Line: 597

   Type of error: General
Unknown Error: Non-static method TinyPortal\Model\Subs::chain() should not be called statically
http://elkarte4.test/index.php?action=admin;area=tparticles;sa=articles;cu=3
File: C:/laragon/www/elkarte4/TinyPortal/Model/Article.php
Line: 597

Type of error: General
Unknown Error: Non-static method TinyPortal\Model\Subs::chain() should not be called statically
http://elkarte4.test/index.php?action=admin;area=tparticles;sa=articles
File: C:/laragon/www/elkarte4/TinyPortal/Model/Article.php
Line: 597
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 08, 2021, 02:04:02 PM
Thanks, I’ll sort those later tonight.

Same issue as last time. I haven’t moved it all across it seems.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 08, 2021, 03:21:14 PM
Thanks, I’ll sort those later tonight.

Same issue as last time. I haven’t moved it all across it seems.

tino, I'm guessing this error is also stopping the articles displaying on the front page, and the reason the "Toggle show on front page" button wont stay selected? If not there's another issue.

 
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 08, 2021, 03:44:34 PM
Thanks, I’ll sort those later tonight.

Same issue as last time. I haven’t moved it all across it seems.

tino, I'm guessing this error is also stopping the articles displaying on the front page, and the reason the "Toggle show on front page" button wont stay selected? If not there's another issue.

If it’s showing an error in the log when you press them then yes that’s it.

I’ll check them both out later, I thought there would be loads of issues after my last change as it was the biggest one.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 08, 2021, 05:57:49 PM
Thanks, I’ll sort those later tonight.

Same issue as last time. I haven’t moved it all across it seems.

tino, I'm guessing this error is also stopping the articles displaying on the front page, and the reason the "Toggle show on front page" button wont stay selected? If not there's another issue.

Those are all fixed.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 09, 2021, 12:58:58 AM
Thanks, I’ll sort those later tonight.

Same issue as last time. I haven’t moved it all across it seems.

tino, I'm guessing this error is also stopping the articles displaying on the front page, and the reason the "Toggle show on front page" button wont stay selected? If not there's another issue.

Those are all fixed.


Ok, seems to work, and articles now show on front page, and the "Toggle show on front page" button button sticks as it should, but it's still putting a error in the log when you toggle it,

Type of error: Template
Unable to load the 'main' template.
http://elkarte4.test/index.php?action=admin;area=tparticles;sa=ajax;artfront=1;ai9o9N4=ok704c6q80iab6lwIostvdYvfNXb91Tr
File: C:/laragon/www/elkarte4/sources/Templates.class.php
Line: 510
[/quote]
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 09:21:21 AM
Thanks, I’ll sort those later tonight.

Same issue as last time. I haven’t moved it all across it seems.

tino, I'm guessing this error is also stopping the articles displaying on the front page, and the reason the "Toggle show on front page" button wont stay selected? If not there's another issue.

Those are all fixed.


Ok, seems to work, and articles now show on front page, and the "Toggle show on front page" button button sticks as it should, but it's still putting a error in the log when you toggle it,

Type of error: Template
Unable to load the 'main' template.
http://elkarte4.test/index.php?action=admin;area=tparticles;sa=ajax;artfront=1;ai9o9N4=ok704c6q80iab6lwIostvdYvfNXb91Tr
File: C:/laragon/www/elkarte4/sources/Templates.class.php
Line: 510
Thanks, that's now fixed. Are there any other errors?
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 09, 2021, 10:38:17 AM
Well, just found another one,

How to redirect after login > Redirect to frontpage gives a error when you logout.

This one on page,

Database Error
Please try again. If you come back to this error screen, report the error to an administrator.

And this one in log.

Type of error: Database
Database Error: Unknown column 'var.access' in 'where clause'
http://elkarte4.test/index.php?
File: C:/laragon/www/elkarte4/TinyPortal/Model/Database.php
Line: 43
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 10:42:29 AM
Well, just found another one,

How to redirect after login > Redirect to frontpage gives a error when you logout.

This one on page,

Database Error
Please try again. If you come back to this error screen, report the error to an administrator.

And this one in log.

Type of error: Database
Database Error: Unknown column 'var.access' in 'where clause'
http://elkarte4.test/index.php?
File: C:/laragon/www/elkarte4/TinyPortal/Model/Database.php
Line: 43

I wonder if that's also a bug in TinyPortal for SMF, as I don't recall changing that.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 10:45:25 AM
Well, just found another one,

How to redirect after login > Redirect to frontpage gives a error when you logout.

This one on page,

Database Error
Please try again. If you come back to this error screen, report the error to an administrator.

And this one in log.

Type of error: Database
Database Error: Unknown column 'var.access' in 'where clause'
http://elkarte4.test/index.php?
File: C:/laragon/www/elkarte4/TinyPortal/Model/Database.php
Line: 43

I wonder if that's also a bug in TinyPortal for SMF, as I don't recall changing that.

I also can't replicate it. What is set to display on your frontpage?
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 09, 2021, 10:55:18 AM

I also can't replicate it. What is set to display on your frontpage?

Just one html article, and also one html block which reside in the left panel.  These are in addition to the stock blocks.

And in front page settings I have, What to display on frontpage set to "Only articles"
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 11:17:14 AM

I also can't replicate it. What is set to display on your frontpage?

Just one html article, and also one html block which reside in the left panel.  These are in addition to the stock blocks.

And in front page settings I have, What to display on frontpage set to "Only articles"

Does that give the error as a guest user? I don’t think it’s related to that setting.

Also what is the structure of your tp_categories table?
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 09, 2021, 01:14:12 PM

Does that give the error as a guest user? I don’t think it’s related to that setting.


Well you say that but it doesn't give the error if you select "Only forum-topics" etc, so that's what made me think it's something to do with that setting.  It gives me the error on page as soon as I click logout when that setting is set.

Table structure, in screenshot below.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 09, 2021, 01:24:07 PM
Installed latest version and again all the language strings are missing
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 09, 2021, 01:48:04 PM
Another.

Front page setting "Go directly to forum index" doesn't seem to show the forum index, just the blocks and panels showing,
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 01:50:02 PM
Another.

Front page setting "Go directly to forum index" doesn't seem to show the forum index, just the blocks and panels showing,

I don’t know what’s going on. That and the other issue are fine for me.

Your db has the right values in it. So it’s not that.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 01:51:16 PM
Installed latest version and again all the language strings are missing

What changed? Is this development or the RC2?

I’ve not made any changes since you raised it last time, then it seemed to work again.

What language is you user / forum currently set to?
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 01:53:10 PM

Does that give the error as a guest user? I don’t think it’s related to that setting.


Well you say that but it doesn't give the error if you select "Only forum-topics" etc, so that's what made me think it's something to do with that setting.  It gives me the error on page as soon as I click logout when that setting is set.

Table structure, in screenshot below.

I meant the redirect setting not the front page one. I can see why the article_only would if you didn’t have the table correct, but you do...
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 09, 2021, 01:56:49 PM
Installed latest version and again all the language strings are missing

What changed? Is this development or the RC2?

I’ve not made any changes since you raised it last time, then it seemed to work again.

What language is you user / forum currently set to?

That’s the development branche... should I use another one? I am not sure which branch to use...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 02:33:47 PM
Installed latest version and again all the language strings are missing

What changed? Is this development or the RC2?

I’ve not made any changes since you raised it last time, then it seemed to work again.

What language is you user / forum currently set to?

That’s the development branche... should I use another one? I am not sure which branch to use...

Tbh atm doesn’t really matter, development has the start of the menu, gallery and downloads in it. That’s about the only change.

The RC2 was just going to be stable, although lurkalot is getting errors I can’t replicate as are you.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 09, 2021, 04:49:22 PM
Another.

Front page setting "Go directly to forum index" doesn't seem to show the forum index, just the blocks and panels showing,

I don’t know what’s going on. That and the other issue are fine for me.

Your db has the right values in it. So it’s not that.

Yes very strange.  Setting it to "Go directly to forum index" doesn't cause any errors, but also both the Home, and Community tabs are showing where it should just show the Community tab.

Would be interesting to see if @rjen is having the same issues. This was a fresh install of ElkArte 1.1.6 with ElkTP RC2 from your rebuilt tag https://github.com/Tinyportal/ElkTP/releases/tag/V1.0.0-RC2
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 04:55:39 PM
Another.

Front page setting "Go directly to forum index" doesn't seem to show the forum index, just the blocks and panels showing,

I don’t know what’s going on. That and the other issue are fine for me.

Your db has the right values in it. So it’s not that.

Yes very strange.  Setting it to "Go directly to forum index" doesn't cause any errors, but also both the Home, and Community tabs are showing where it should just show the Community tab.

That’s not happening for me either...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 06:00:40 PM
Another.

Front page setting "Go directly to forum index" doesn't seem to show the forum index, just the blocks and panels showing,

I don’t know what’s going on. That and the other issue are fine for me.

Your db has the right values in it. So it’s not that.

Yes very strange.  Setting it to "Go directly to forum index" doesn't cause any errors, but also both the Home, and Community tabs are showing where it should just show the Community tab.

Would be interesting to see if @rjen is having the same issues. This was a fresh install of ElkArte 1.1.6 with ElkTP RC2 from your rebuilt tag https://github.com/Tinyportal/ElkTP/releases/tag/V1.0.0-RC2

I have managed to replicate the go directly to board index one, that was an issue with my install and it not setting correctly. That's now sorted.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 06:07:09 PM
Well, just found another one,

How to redirect after login > Redirect to frontpage gives a error when you logout.

This one on page,

Database Error
Please try again. If you come back to this error screen, report the error to an administrator.

And this one in log.

Type of error: Database
Database Error: Unknown column 'var.access' in 'where clause'
http://elkarte4.test/index.php?
File: C:/laragon/www/elkarte4/TinyPortal/Model/Database.php
Line: 43

Ok managed to replicate this one also, it seems I needed an non admin account when you logged out which causes the error. Guests are ok it seems weirdly.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 09, 2021, 06:16:54 PM
Glad you managed to replicate those issues tino. O0 I'll test again when fixed and see if I can find anything else.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 09, 2021, 06:26:50 PM
Glad you managed to replicate those issues tino. O0 I'll test again when fixed and see if I can find anything else.

They are now fixed, just rebuilt the tag.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 10, 2021, 12:40:31 AM

They are now fixed, just rebuilt the tag.


- Yep, all those errors appear to have gone. :tick:

- setting "Go directly to forum index" also working properly. :tick: 

- How to redirect after login:  Redirect to forum / Redirect to frontpage. Also working properly. :tick:

So far so good tino.  O0
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 10, 2021, 12:54:11 AM
Installed latest version and again all the language strings are missing

What changed? Is this development or the RC2?

I’ve not made any changes since you raised it last time, then it seemed to work again.

What language is you user / forum currently set to?

Just downloaded the tagged version and that is fine... there is something funny going on with those languages. FYI: in the test install I have no other languages than English (default)
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 10, 2021, 12:59:57 AM
I am seeing these errors in Elkarte ... they start popping up after TinyPortal is installed...

Type of error: General
Notice: Trying to access array offset on value of type null
http://localhost/elkarte/index.php?page=Welkom
File: C:/xampp/htdocs/elkarte/sources/subs/BBC/BBCParser.php
Line: 285
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on February 10, 2021, 01:15:23 AM
I am seeing these errors in Elkarte ... they start popping up after TinyPortal is installed...

Type of error: General
Notice: Trying to access array offset on value of type null
http://localhost/elkarte/index.php?page=Welkom
File: C:/xampp/htdocs/elkarte/sources/subs/BBC/BBCParser.php
Line: 285

Strange. I'm not getting any errors with this latest tag build.  Wonder if it's somehow related to this, https://www.elkarte.net/community/index.php?topic=5822.msg41921#msg41921  Though not sure why it would only start occurring after installing ElkTP. I'm testing on PHP: 7.2.19
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 10, 2021, 02:58:15 AM
I am seeing these errors in Elkarte ... they start popping up after TinyPortal is installed...

Type of error: General
Notice: Trying to access array offset on value of type null
http://localhost/elkarte/index.php?page=Welkom
File: C:/xampp/htdocs/elkarte/sources/subs/BBC/BBCParser.php
Line: 285

I'm using Elkarte 1.1.7, can you post what is in your BBC article?
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 10, 2021, 03:24:17 AM
Installed latest version and again all the language strings are missing

What changed? Is this development or the RC2?

I’ve not made any changes since you raised it last time, then it seemed to work again.

What language is you user / forum currently set to?

Just downloaded the tagged version and that is fine... there is something funny going on with those languages. FYI: in the test install I have no other languages than English (default)

Do you maybe have some old files laying around in the old directories? As I removed them from the uninstaller when I moved things around and I noticed due to how I installed packages I had some left in the wrong place which were being picked up. That's about all I can think of currently.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 13, 2021, 11:19:06 AM
Are you both happy enough for me to release this as the next RC release? I haven't found any major issues with it. Although I have only really used the bits I am interested in/use.
Title: Re: Elkarte TinyPortal Testing
Post by: @rjen on February 13, 2021, 11:31:14 AM
Tbh I did not do much of testing yet, mostly because I was under the impression that you are still making changes...
Title: Re: Elkarte TinyPortal Testing
Post by: tino on February 13, 2021, 12:59:24 PM
Tbh I did not do much of testing yet, mostly because I was under the impression that you are still making changes...

I will be on the development release, this was just an intermediate RC. Much like SMF are doing with 2.1 tbf. I just wanted to make sure it all worked as expected before I add the other things in from the development release and break things even more than I already have!

Hopefully, the majority works and I can get on with development knowing what I have released is ok.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on March 06, 2021, 06:02:33 AM
I pushed RC2 as the 'stable' release a few weeks ago. Now working on the RC3 which has the blocks backend reworked and makes it easier to add new block types, and currently has templates for the menu, gallery and download sections which basically do nothing atm.

Regarding the gallery and downloads what do you like in terms of styling? I'm not overly keen on the existing TinyPortal layout (for downloads) but it's not dreadful.

It seems I have made over 100,000 lines of code edits to this from the SMF version so I think they are on different paths now..
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on March 06, 2021, 06:45:26 AM
I pushed RC2 as the 'stable' release a few weeks ago. Now working on the RC3 which has the blocks backend reworked and makes it easier to add new block types, and currently has templates for the menu, gallery and download sections which basically do nothing atm.

Regarding the gallery and downloads what do you like in terms of styling? I'm not overly keen on the existing TinyPortal layout (for downloads) but it's not dreadful.

It seems I have made over 100,000 lines of code edits to this from the SMF version so I think they are on different paths now..

That's a lot of edits tino.  :o  I'll have to try it again, and see what you've done with it.  ;)

I quite like the layout for the TP downloads, I guess again it's because I'm used to it.  But gallery layouts seem to be very similar throughout and seem to follow follow a set layout, only so much you can do with it I suppose.

Are you providing the option to choose either GD or ImageMagick to process the images? Or just sticking to GD?

I've used Coppermine for many years, but although it's extremely powerful it's styling is to be desired and can be quite frustrating at times.   
Title: Re: Elkarte TinyPortal Testing
Post by: tino on March 06, 2021, 07:41:32 AM
It will support all the image library formats that PHP support. As I have a class for that already which I will just copy over, well it will try all of them anyway and fallback to which ever one works.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on March 06, 2021, 07:55:14 AM
It will support all the image library formats that PHP support. As I have a class for that already which I will just copy over, well it will try all of them anyway and fallback to which ever one works.

Thanks, not selectable in config then.  I must admit I always had a preference for ImageMagick always processed sharper images and handles more file types, but when I moved server I had to switch to GD because ImageMagick wasn't available, seems it isn't on many hosts nowadays, unless it's making a comeback.  My old host had both library's installed, so what would happen in this case, which one would it choose?
Title: Re: Elkarte TinyPortal Testing
Post by: tino on March 06, 2021, 08:45:59 AM
It’s imagik then gd for manipulation, although it’s exif to get the actual data. It’s not configurable to choose mind, other than not installing the php package.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on March 14, 2021, 11:15:08 AM
Finally managed to get my FTP client to connect to my free, for how long I don't know.  It's a really pain in the arse.  Anyway,, while I have access I quickly uploaded a copy of ElkArte 1.1.6 and Elk-TinyPortal 1.0.0 RC2  http://lts4.byethost7.com/testsite9/

Looking good so far tino.  How's RC3 coming along?
Title: Re: Elkarte TinyPortal Testing
Post by: tino on March 14, 2021, 11:28:39 AM
It’s kind of hit a standstill, I’m half way through the block rewrite and have template functions for shouts, downloads, menu and gallery sections.

So it’s progressing just slowly.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on March 14, 2021, 12:44:09 PM
Thanks, let me know if you need it testing, I'll bung it up on there.

I Was going to add some sample blocks, but hit my first issue when adding a Top BBC block.. Block gets added but can't add any content to it, Got this error on page,

"An Error Has Occurred
Call to undefined function TinyPortal\Controller\TP_prebbcbox()"

And in error log,

Type of error: Undefined
Exception: Call to undefined function TinyPortal\Controller\TP_prebbcbox()
http://lts4.byethost7.com/testsite9/index.php?action=admin;area=tpblocks;sa=editblock&id=6;sesc
File: /home/vol11_7/byethost7.com/b7_24299229/htdocs/testsite9/TinyPortal/Controller/BlockAdmin.php
Line: 270

Title: Re: Elkarte TinyPortal Testing
Post by: tino on March 14, 2021, 12:56:35 PM
RC2 or RC3?

It’s TPSubs::getInstance()->preBBCBox or something like that now.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on March 14, 2021, 12:56:55 PM
Also noticed it defaults to "Use frame style, but not title style" when you create a new block, is this by design?
Title: Re: Elkarte TinyPortal Testing
Post by: tino on March 14, 2021, 12:58:02 PM
Also noticed it defaults to "Use frame style, but not title style" when you create a new block, is this by design?

No that’s a change I’ve not looked in to.
Title: Re: Elkarte TinyPortal Testing
Post by: lurkalot on March 14, 2021, 12:59:00 PM
RC2 or RC3?

It’s TPSubs::getInstance()->preBBCBox or something like that now.

Says it's RC2 from the download link on ElkArte website.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on March 14, 2021, 01:30:29 PM
Thanks, it’s an issue in both, although I’ll add it to the fix list for RC3
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on November 20, 2021, 04:50:15 PM
A nice piece of work.  O0

I have made a little bit of an actual translation into German (formal). I found quite a few reduntante entries. Is this art or can it be removed?  ;)

What about further development? RC3?
Title: Re: Elkarte TinyPortal Testing
Post by: tino on November 21, 2021, 02:29:31 AM
Thanks for that.

My life got very hectic and I’ve not had a chance to really extend it much. There is a version on GitHub which is very much in testing (and has bugs, and unfinished code) which will become RC3. Most bugs from RC2 that I know of were rectified.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on November 21, 2021, 07:01:52 AM
Thank you for the prompt reply. Have the translation gladly made as a small contribution by me. Would like to deliver the package installable via the package manager. Question about this: Do the files have to be written in "/TinyPortal/Views/languages/german-formal"? Or is the default path of ElkArte fine, too?

I also noticed two errors already. However, with one of them I don't know if it is possibly due to the server. Link to the test installation in the signature.

First (TP credit link):
Quote
Exception: Call to undefined function TinyPortal\Controller\tp_hidebars()

... /index.php?action=tportal;sa=credits
... /TinyPortal/Controller/Portal.php
line=1365

Second (link to the list of "articles in category" below an article):
Quote
Warning: Undefined array key "email_address"

... /index.php?cat=2
... /sources/Load.php
line=2717

Life usually gets hectic when you have plans. Unfortunately, mostly also in the opposite direction.  ;)
Title: Re: Elkarte TinyPortal Testing
Post by: tino on November 21, 2021, 07:26:02 AM
Thanks for those, do you mind trying the development version on GitHub? https://github.com/tinoest/ElkTinyPortal/tree/development

I recall fixing the tp_hidebars in there. Not sure on the other one. I’ve not made a commit since May, I have a few to push I think. I’ll try and look at those tomorrow, usual warnings apply in that it’s testing and buggy.

The language pack, I would like inside TinyPortal namespace but I might need to make changes to get that to work. It should in theory work in either. If it doesn’t let me know and I’ll correct the broken code. In essence put it where you feel it’s most appropriate and I’ll fix it to work if it’s broken.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on November 21, 2021, 10:14:10 AM
I just pushed some fixes for the issue you raised for categories, also the language loading so it can be in either place.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on November 21, 2021, 02:49:58 PM
Just updated my test installation from RC2 to RC3. And made some work for the translation, by the way ... utf8. Now installable via the package manager in the right TP path.  :)

The first error still appears, the second is fixed.


edit: I hope I found and translated all the new lines of text.  ::)
Title: Re: Elkarte TinyPortal Testing
Post by: tino on November 22, 2021, 06:38:34 AM

The first error still appears, the second is fixed.


The first error is also now fixed, I have credits disabled on my test install.  :doh:

Also downloaded and installed your language file and it seems to work well. Thanks for that  O0
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on November 24, 2021, 07:48:39 AM
...

The first error is also now fixed, I have credits disabled on my test install.  :doh:

...

Also a way to solve things.  ;D

I stumbled over an error while creating a PHP block: The code entry field is not displayed!  :o

When viewing the HTML source, two subsequent empty DIVs are noticeable in the associated DIV.

EDIT:

Fun fact: I can enter the PHP code if I switch to HTML/Javascript and switch back to PHP code before saving. :2funny:
Title: Re: Elkarte TinyPortal Testing
Post by: tino on November 24, 2021, 03:21:53 PM
Guess there were no errors in the logs?

I’ll have a variable missing or set incorrectly somewhere which is causing that one… the blocks logic from SMF TinyPortal was pretty much ripped up and started again for Elkarte so it’s probably buggy as anything.

I think other than myself, lurkalot and @rjen (who kindly tested it initially for me) you’re the first person to use it in anger. So any feedback is very much appreciated.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on November 25, 2021, 10:01:06 AM
I like to test out one or the other, I enjoy it. Especially when you see that things are moving forward with ElkArte and TinyPortal. Just because TP does not change the files and "ftp" access is reduced exclusively to ssh.  O0

I have already found plenty of missing variables and other adversities. I think I should write them down ...  :hmm:  ... and as mentioned before, I'm currently testing with Apache 2.4.48, PHP 8.0.8 and MariaDB 10.5.12.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on November 25, 2021, 10:33:59 AM
Warning: Undefined array key "memID"
index.php?action=profile;area=tparticles;sa=articles;u=1
TinyPortal/Views/TPprofile.template.php
line: 72


Warning: Undefined array key "selected_member"
index.php?action=profile;area=tparticles;sa=settings;u=1
TinyPortal/Views/TPprofile.template.php
line: 167


Warning: Undefined array key "uploads"
index.php?action=profile;area=tpsummary;u=1
TinyPortal/Views/TPprofile.template.php
line: 33


Warning: Undefined array key "portal_type"
index.php?action=admin;area=tpsettings;sa=settings
TinyPortal/Views/TPortalAdmin.template.php
line: 112


Subaction not defined
index.php?action=admin;area=tpgallery;sa=add;
sources/subs/Action.class.php
line: 129


Subaction not defined
index.php?action=admin;area=tpdownload;sa=add;
sources/subs/Action.class.php
line: 129
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on November 25, 2021, 11:34:28 AM
Just looked in maintenance, integration hooks. The existing and active hooks:

integrate_delete_members
integrate_load_illegal_guest_permissions
integrate_load_permissions
integrate_modify_attachment_settings
integrate_modify_mention_settings
integrate_sa_manage_maintenance
integrate_save_modify_mention_settings
integrate_topics_maintenance

All others have not been found.  :-\
Title: Re: Elkarte TinyPortal Testing
Post by: tino on November 25, 2021, 11:57:23 AM
Just looked in maintenance, integration hooks. The existing and active hooks:

integrate_delete_members
integrate_load_illegal_guest_permissions
integrate_load_permissions
integrate_modify_attachment_settings
integrate_modify_mention_settings
integrate_sa_manage_maintenance
integrate_save_modify_mention_settings
integrate_topics_maintenance

All others has not been found.  :-\

That one is due to how TinyPortal loads them and Elkarte detects them, they are there mind!

I’ll work through the errors you raised tomorrow. Should have a few hours free!
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on January 20, 2022, 06:52:21 AM
I have encountered a strange problem. In the installation (see signature) I left the guests out on a trial basis. So far, so good. "Home" shows the front page and "Forum" changes to the forum. In another test installation, however, a login is requested once more and after that again I end up ... on the front page. However, this behavior persists when guest access is allowed again.  ??? :-\
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 20, 2022, 07:37:24 AM
Which version are you running? I had an issue with the guest access functionality, which I think I fixed this last weekend. But it’s related to the new feature I were you can allow guests access to the portal and not the forum.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on January 20, 2022, 09:22:46 AM
It would be much easier if the version numbers were continuous ...  ;)

I have just replaced the correctly working installation (RC3 from 21 Nov 21) with the latest version (RC3 from 8 Jan 22) and it still works correctly.

The not correctly working installation is the latest one with data transfer from SMF 2.0.19 to Elkarte, which I did now on Tuesday.
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 20, 2022, 09:29:18 AM
It would be much easier if the version numbers were continuous ...  ;)

I have just replaced the correctly working installation (RC3 from 21 Nov 21) with the latest version (RC3 from 8 Jan 22) and it still works correctly.

The not correctly working installation is the latest one with data transfer from SMF 2.0.19 to Elkarte, which I did now on Tuesday.

It would be but RC3 isn’t released, so it’s technically the git commit. If I released every time I fixed something we’d be at RC99103 by now. As I like to break things!

If you know how to pull the git commit into the code after the commit has been done then I’d happily use that as the version.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on January 20, 2022, 09:48:39 AM
I'm going slightly mad!  :idiot2:

Just switched the non working installation from PHP 7.4 to PHP 8.0.14 as a test. Result was an error:

Error: undefined
Warning: Undefined array key "icon_max_size"

After switching back to PHP 7.4, I was able to log in again. And ... TADAAAAA ... now it runs correctly.  8)

EDIT:

Ah ... ok ... I think it's the "Forward after login" setting. The portal type must be set to "Standalone" if the redirection after login to the front page should work correctly. Or respectively, with the setting, calling the forum works again.

But still got undefined-sub-action-errors on adding downloads or galleries.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on January 20, 2022, 10:20:47 AM
The icon-max-size / icon-width warning under PHP8 becomes a notice under PHP7:

TPortalAdmin.english.php, line 248
Code: [Select]
$txt['tp-adminiconsinfo'] = 'PNG, JPG or GIF, Max-size: ' .$context['TPortal']['icon_max_size']. ' KB. Images will be resized so the shortest side is ' .$context['TPortal']['icon_width']. ' px, while retaining aspect ratio. Note that the top area of the image will be used as article icon.';
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 20, 2022, 10:55:29 AM
Downloads, Gallaries and Menu I will probably disable as options soon. As I want to try and package a release with minimal issues.

I'll look at the icon warning. It will be a setting somewhere which isn't being set.
Title: Re: Elkarte TinyPortal Testing
Post by: Mc Fly on January 21, 2022, 04:44:04 AM
Updated version of german formal translation.  :)
Title: Re: Elkarte TinyPortal Testing
Post by: tino on January 21, 2022, 01:24:48 PM
It's about time I drafted the next RC release so providing no bugs are reported against this pre-release then I'll get it released early February.

https://github.com/Tinyportal/ElkTP/releases/tag/V1.0.0-RC3