Hyperlinks not working on Front Page

[tino]

What am I doing wrong? As I can't recreate it atm

See the images for what I have done..

[@rjen]

Create a bbc article with a hyperlink enclosed in quotes. Save it and view. Try the link. If it works, edit the article and save it again. Try the link again.

[tino]

Create a bbc article with a hyperlink enclosed in quotes. Save it and view. Try the link. If it works, edit the article and save it again. Try the link again.

Done that, it links through ok.

I'll add what I think is the fix. But I can't verify it.

[@rjen]

I can reproduce it, so I can verify the fix

[tino]

Try adding this the line above here:

https://github.com/Tinyportal/TinyPortal/blob/7652754b0ad9a81e3d96a73d3b1a2df6409a1cdc/Sources/TPArticle.php#L431

Code: [Select]

            // BBC we need to encode quotes
            if( ($_REQUEST['tp_article_type'] == 'bbc') && ($setting == 'body') ) {
              $value = $smcFunc['htmlspecialchars']($value, ENT_QUOTES);
            }

That breaks things for me and add's localhost on the second save, but I'm not sure if that's my environment.

[tino]

https://github.com/Tinyportal/TinyPortal/blob/7652754b0ad9a81e3d96a73d3b1a2df6409a1cdc/Sources/TPortalAdmin.php#L1010

This line also needs to be changed to

Code: [Select]

      if($context['TPortal']['editarticle']['type'] != 'bbc') {
        $context['TPortal']['editarticle']['body'] = $smcFunc['htmlspecialchars']($context['TPortal']['editarticle']['body'], ENT_QUOTES);
      }


[@rjen]

Just tested the fixes on two test sites and as far as I can see they fix the problem with the links in bbc articles.

[Kokoro]

Thank you!  That fixed it great!