TinyPortal

Development => Support => Topic started by: Skb on January 10, 2019, 07:18:52 AM

Title: Articles problem
Post by: Skb on January 10, 2019, 07:18:52 AM
I'm using TP 1.5.0
I've been using the Front Panel / Front Page on the Forum. Initially, the Front Panel content had links to our Articles which were placed on our website (not forum).

Now, I've used the TP Articles feature and moved them to the forum. My Category is known as General Articles. I want only 1 Article to display at a time. If I use the display LinkTree option, the Category link is displayed there and when clicked it will show all the Articles together. If I disable the LinkTree option, only the Home page button shows in the LinkTree (which is fine) but it links to the displayed Article and not the Home page.

Am I missing some option ?   
Title: Re: Articles problem
Post by: @rjen on January 10, 2019, 07:58:33 AM
I cannot understand what situation you are having. Can we see it on your forum?
Title: Re: Articles problem
Post by: Skb on January 10, 2019, 08:50:20 AM
I hope the screen shot can explain better.
Title: Re: Articles problem
Post by: @rjen on January 10, 2019, 09:17:45 AM
As far as I can see you are not on the Home page, but on an articles pages...

The link is supposed to direct to the current page (which it does), disabling the setting to show the linktree on the article seems to just remove the 'path to the article', but does not change the destination of the remaining link.

I can see that this is confusing, but I am not sure if this is intended or not...
Title: Re: Articles problem
Post by: @rjen on January 10, 2019, 09:25:12 AM
Funny thing: just checked the code:

in 2.0 the remaining link still points to the article, in 2.1 (due to different approach using hooks) the remaining link points to /forum... (which may be not what you want, but that is the default link SMF creates)

So it is definitely something that is worth looking into, since it is not consistent...
Title: Re: Articles problem
Post by: Skb on January 10, 2019, 11:40:25 AM
Quote from: @rjen on January 10, 2019, 09:25:12 AM
Funny thing: just checked the code:

in 2.0 the remaining link still points to the article, in 2.1 (due to different approach using hooks) the remaining link points to /forum...

Yes, that is what I want (as in 2.1). That the link to home (Diabetic Pub in our case) should go back to Home and not remain on the article page.

If you could suggest the code changes, I could look into that. 
Title: Re: Articles problem
Post by: @rjen on January 10, 2019, 05:05:10 PM
These code changes are a bit too complex for me atm. Maybe Tino can offer something...

Logged in GH: https://github.com/Tinyportal/TinyPortal/issues/282
Title: Re: Articles problem
Post by: tino on January 10, 2019, 09:18:59 PM
If I disable the linktree I get no linktree? Which is what I would expect.

That's no link to the home page or anything. I have fixed the bug with SMF2.1 where it was adding the forum to the link tree unnecessarily.
Title: Re: Articles problem
Post by: @rjen on January 10, 2019, 09:28:00 PM
What Exactly do you mean by that? The linktree itself is active but you set the linktree to not show for this specific article: when viewing the article the category and page info is removed from the linktree, but the forum name remains ... see the screenshot...
Title: Re: Articles problem
Post by: tino on January 10, 2019, 09:30:36 PM
See the attachments. With the linktree setting enabled and then cleared, for SMF2.0
Title: Re: Articles problem
Post by: @rjen on January 10, 2019, 09:34:03 PM
Not on my 162 text forum.... see: https://test.fjr-club.nl/index.php?page=Welkom
Title: Re: Articles problem
Post by: tino on January 10, 2019, 09:48:28 PM
Quote from: @rjen on January 10, 2019, 09:34:03 PM
Not on my 162 text forum.... see: https://test.fjr-club.nl/index.php?page=Welkom

What other mods do you have installed? That was a clean forum with no other mods enabled.
Title: Re: Articles problem
Post by: lurkalot on January 10, 2019, 11:24:59 PM
Turning linktree off in SMF 2.0.15 TP1.6.2 the linktree disappears completely.

Turning linktree off in SMF 2.1 TP1.6.2 the linktree is there but just says >Forum

What I have noticed also in 2.1 is the lower blocks still show below a article, even though they are told not to show on that article. All other blocks respect the given settings. Confirmation required on this one please. It might be me.

Title: Re: Articles problem
Post by: @rjen on January 11, 2019, 08:38:29 AM
Quote from: tino on January 10, 2019, 09:48:28 PM
Quote from: @rjen on January 10, 2019, 09:34:03 PM
Not on my 162 text forum.... see: https://test.fjr-club.nl/index.php?page=Welkom

What other mods do you have installed? That was a clean forum with no other mods enabled.

Quite a list tbh, since it is a complete copy of my 'production' forum...
I pasted the list below, but if you say it works fine on a vanilla install then I believe you...


1.   TinyPortal   1.6.2 
2.   Simple .htaccess Cache Mod   2.7 
3.   Optimus   1.9.9 
4.   Responsive Curve   1.0.1 
5.   Default_Membergroup   2.0 
6.   GDPR Helper   1.0.4 
7.   Automatic Attachment Rotation (and Resize)   5.3 
8.   Post and PM Inline Attachments   6.12 
9.   Simple Audio Video Embedder   4.5 
10.   Google Analytics Code   1.5.1 
11.   YandexGarland   1.3.3 
12.   Tidy Child Boards   2.0 
13.   Sortable Packages (and Installed Time)   1.3.5 
14.   Image Processing Memory Limit   0.1.2 
15.   Search Focus Dropdown   1.6.1 
16.   Voter Visibility   2.1 FJR 
17.   Downloads System   3.0.1 
18.   Spiders Don't Increase Topic Views   1.1.1 
19.   Recount Member Posts   1.1 FJR 
20.   Generic Avatars   1.11 
21.   Board Index Unread Icon Fix   1.0 
22.   Users Online Today   2.1 
23.   Float BBCODE   1.0.2 
24.   Remove "Last edit" mod   0.2.5 
25.   Add Social Media Icons To Profiles FJR   1.2.0 
26.   EU Cookie FJR   1.3fjr 
27.   Group Attachment Limits   1.1.0 
28.   Order Custom Profile Fields   1.1.1 
29.   Alternate User Posting   1.0.1 
30.   Custom Board Sort   1.0.2 
31.   Auto Lock Old Topics   2.0 
32.   AJAX Recent Topics   1.1 
33.   Ignore Topics   2.3 
34.   View Only Boards   1.2c 
35.   Previous and Next Links for Page Index   2.1.204 
Title: Re: Articles problem
Post by: tino on January 11, 2019, 10:53:16 AM
Quote from: lurkalot on January 10, 2019, 11:24:59 PM
Turning linktree off in SMF 2.0.15 TP1.6.2 the linktree disappears completely.

Turning linktree off in SMF 2.1 TP1.6.2 the linktree is there but just says >Forum


That was the behaviour I had, the latest PR fixes the Forum issue in SMF 2.1
Title: Re: Articles problem
Post by: tino on January 11, 2019, 10:55:20 AM
Quote from: @rjen on January 11, 2019, 08:38:29 AM
Quote from: tino on January 10, 2019, 09:48:28 PM
Quote from: @rjen on January 10, 2019, 09:34:03 PM
Not on my 162 text forum.... see: https://test.fjr-club.nl/index.php?page=Welkom

What other mods do you have installed? That was a clean forum with no other mods enabled.

Quite a list tbh, since it is a complete copy of my 'production' forum...
I pasted the list below, but if you say it works fine on a vanilla install then I believe you...


Thank's I don't see anything obvious in that list. I'm curious as to why your's and skb's is different what me and lurkalot get though.
Title: Re: Articles problem
Post by: @rjen on January 11, 2019, 11:15:15 AM
Quote from: tino on January 11, 2019, 10:55:20 AM
Thank's I don't see anything obvious in that list. I'm curious as to why your's and skb's is different what me and lurkalot get though.

so am I, but I do not know where to start looking for the problem...
Title: Re: Articles problem
Post by: tino on January 11, 2019, 12:02:44 PM
Quote from: @rjen on January 11, 2019, 11:15:15 AM
Quote from: tino on January 11, 2019, 10:55:20 AM
Thank's I don't see anything obvious in that list. I'm curious as to why your's and skb's is different what me and lurkalot get though.

so am I, but I do not know where to start looking for the problem...

I have no idea either. If it's TinyPortal it would be one of the TPstrip_linktree or TPadd_linktree calls.
Title: Re: Articles problem
Post by: Skb on January 11, 2019, 01:14:19 PM
Well, I would have no issues if the Linktree disappears completely as in the case of 2.1 (as you say).

My problem is if I choose display the linktree, it gives the whole tree, with a link to the Category of Articles, and if that is clicked, all of the Articles are displayed all at once one on top of the other, which I don't want.

And If I choose to not display the Linktree, the linktree still displays with the link to the Forum Home Page / front page, but it links to that open article and not the Forum.

I think you are seized of the problem and will get to the bottom of the anomaly.

Thanks.   
Title: Re: Articles problem
Post by: @rjen on January 11, 2019, 01:31:37 PM
QuoteI think you are seized of the problem and will get to the bottom of the anomaly.

Not sure what you mean by that, but it seems that what you have (and I have in a forum) does not happen in a vanilla install, hence it may not be solvable...
Title: Re: Articles problem
Post by: tino on January 11, 2019, 02:33:34 PM
Quote from: Skb on January 11, 2019, 01:14:19 PM

I think you are seized of the problem and will get to the bottom of the anomaly.


Yes it is a issue which doesnt occur on a default install. So I would look at your other mods and see if any match what @rjen has.
Title: Re: Articles problem
Post by: lurkalot on January 11, 2019, 06:45:45 PM
Quote from: lurkalot on January 10, 2019, 11:24:59 PM

What I have noticed also in 2.1 is the lower blocks still show below a article, even though they are told not to show on that article. All other blocks respect the given settings. Confirmation required on this one please. It might be me.

Ok, raised issue on GH for this one, as it not related to this particular issue.
Title: Re: Articles problem
Post by: tino on January 11, 2019, 08:17:38 PM
Quote from: lurkalot on January 11, 2019, 06:45:45 PM
Quote from: lurkalot on January 10, 2019, 11:24:59 PM

What I have noticed also in 2.1 is the lower blocks still show below a article, even though they are told not to show on that article. All other blocks respect the given settings. Confirmation required on this one please. It might be me.

Ok, raised issue on GH for this one, as it not related to this particular issue.

Confirmed, I think that has been there a while. Was a subtle bug and took me a while to find!
Title: Re: Articles problem
Post by: @rjen on January 11, 2019, 09:51:10 PM
Ok, I found the cause for the linktree issue in 2.0. The cause in my forum is Optimus. After uninstalling that the linktree is actually not showing anymore, as it is supposed to be.

Further testing reveals that is is caused by the 'Portal Integration' setting.

As soon as I set this to 'TinyPortal' the linktree does not disappear anymore...

So it is indeed not a TP issue, but caused by the MOD. Are you using the same MOD SKB? If so, try switching off the 'Portal Integration' in the Homepage settings for Optimus...
Title: Re: Articles problem
Post by: lurkalot on January 11, 2019, 11:41:00 PM
Quote from: tino on January 11, 2019, 08:17:38 PM
Quote from: lurkalot on January 11, 2019, 06:45:45 PM
Quote from: lurkalot on January 10, 2019, 11:24:59 PM

What I have noticed also in 2.1 is the lower blocks still show below a article, even though they are told not to show on that article. All other blocks respect the given settings. Confirmation required on this one please. It might be me.

Ok, raised issue on GH for this one, as it not related to this particular issue.

Confirmed, I think that has been there a while. Was a subtle bug and took me a while to find!

Thank you tino, seems fine now, just tested on 2.1 and 2.0.15

Lower blocks now don't show when told not to.  And Linktree disappears when turned off in both 2.1 and 2.0.15

Nice job.  O0
Title: Re: Articles problem
Post by: Skb on January 12, 2019, 03:10:43 AM
Quote from: @rjen on January 11, 2019, 09:51:10 PM
Ok, I found the cause for the linktree issue in 2.0. The cause in my forum is Optimus. After uninstalling that the linktree is actually not showing anymore, as it is supposed to be.

Further testing reveals that is is caused by the 'Portal Integration' setting.

As soon as I set this to 'TinyPortal' the linktree does not disappear anymore...

So it is indeed not a TP issue, but caused by the MOD. Are you using the same MOD SKB? If so, try switching off the 'Portal Integration' in the Homepage settings for Optimus...

Yes I do have Optimus Brave installed. But the Portal Integration is already set to Tinyportal. I will play around with the settings some more and revert. Should I post this issue in the mod's thread over at SMF?
Title: Re: Articles problem
Post by: Skb on January 12, 2019, 05:09:41 AM
Quote from: Skb on January 11, 2019, 01:14:19 PM
My problem is if I choose display the linktree, it gives the whole tree, with a link to the Category of Articles, and if that is clicked, all of the Articles are displayed all at once one on top of the other, which I don't want.

I found a workaround / solution for this. In the Category Settings there is a setting to Display No. of Articles on a Page which I now set to 1. At least, now if Category is clicked it displays only 1 Article. Always the first article, but I can live with that, since at the bottom of each Article I've inserted a link to the Home Page.
Title: Re: Articles problem
Post by: @rjen on January 12, 2019, 07:56:18 AM
Quote from: Skb on January 12, 2019, 03:10:43 AM
Yes I do have Optimus Brave installed. But the Portal Integration is already set to Tinyportal. I will play around with the settings some more and revert. Should I post this issue in the mod's thread over at SMF?

If you want if fixed in OPtimus, that's the only way. I noticed that the problem goes away if I ' deactivate'  the Portal Integration setting in Optimus: you could do that:

I am not 100% sure what this ' Portal Integration' setting in Optimus is actually doing for the forum: it seems the only function is to override the Page Title of the Home page to make it different from the Index page. But actually that function is already available in TinyPortal settings: if you set the page title under General settings in Tinyportal: " Use a custom browser tab title for your Frontpage:" (not sure if that setting was already available in TP1.5.0, but is is in 1.6.1)...

So deactivate forum integration in Optimus and set the desired home page title in TP and you have the same result...
Title: Re: Articles problem
Post by: @rjen on January 12, 2019, 08:07:48 AM
Just found this note in the Optimus support thread at SMF: it confirms my understanding of the function...

Quote from: Bugo on May 13, 2018, 08:23:23 PM
"Portal support" just means that Optimus can change page titles and/or $context['canonical_url'] on portal frontpages.
I didn't use the last versions of EZ Portal, so I don't know how it works, what is changed, etc.
Title: Re: Articles problem
Post by: Skb on January 12, 2019, 01:25:12 PM
Quote from: @rjen on January 12, 2019, 07:56:18 AM
If you want if fixed in OPtimus, that's the only way. I noticed that the problem goes away if I ' deactivate'  the Portal Integration setting in Optimus: you could do that:

I did that and it made no difference. I'm sticking with displaying only 1 Article under the Category link. At the bottom of the Article are the Page numbers so other articles can be accessed from there. Till a solution comes up I'll stick to this arrangement. Thanks all, for everything.
Title: Re: Articles problem
Post by: @rjen on January 12, 2019, 01:29:58 PM
Strange, it works for me.

Glad you found a working setup for your requirements.
Marking this solved...