Login  |  Register
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

Welcome, Guest. Please login or register.
Did you miss your activation email?

February 09, 2023, 02:25:37 AM

Login with username, password and session length
Members
Stats
  • Total Posts: 194010
  • Total Topics: 21135
  • Online today: 42
  • Online ever: 3540
  • (September 02, 2022, 06:38:54 PM)
Users Online
Users: 0
Guests: 44
Total: 44

Author Topic: [Bug/Fix] Problems with new help system...  (Read 7763 times)

0 Members and 1 Guest are viewing this topic.

Oldiesmann

  • Guest
[Bug/Fix] Problems with new help system...
« on: January 15, 2006, 05:16:47 PM »
Found a minor bug with TP in regards to the new help system...

The new help system generates URLs like .../index.php?action=help;page=index

However, because TP just checks for a "page", you get errors:

Quote
You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'index AND off=0 AND approved=1 LIMIT 1' at line 1
File: /.../Sources/TPortal.php
Line: 313

It's an easy fix though...

Sources/TPortal.php

Find
Code: [Select]
// view single article?
$mypage='';
if(isset($_GET['page'])){

Replace
Code: [Select]
// view single article?
$mypage='';
if(isset($_GET['page']) && !isset($_REQUEST['action'])){

feline

  • Guest
Re: [Bug/Fix] Problems with new help system...
« Reply #1 on: January 16, 2006, 02:21:17 AM »
that is only in TP 0.75 .. and that is not a bug of TP .. it's incompatibility to new RC2.

Fel

Oldiesmann

  • Guest
Re: [Bug/Fix] Problems with new help system...
« Reply #2 on: January 16, 2006, 07:35:34 AM »
I'm running TP 0.8, so it's not just an issue with 0.75. I see it as a bug because SMF generally isn't coded to be completely compatible with existing mods...

Offline IchBin

  • Friends
  • *
  • Posts: 16231
Re: [Bug/Fix] Problems with new help system...
« Reply #3 on: January 16, 2006, 07:37:46 AM »
What are you doing over here Oldiesmann? Get back to work on SMF+G2!!! j/p :P

Oldiesmann

  • Guest
Re: [Bug/Fix] Problems with new help system...
« Reply #4 on: January 16, 2006, 07:39:09 AM »
I will get back to work on that when I have more time to work on it... I've been extremely busy lately :)