TinyPortal

Development => Support => Topic started by: sremick on February 24, 2019, 05:59:46 AM

Title: Bulleted lists in articles?
Post by: sremick on February 24, 2019, 05:59:46 AM
Do articles not support bulleted lists?

When I try to make a bulleted list in an article, the displayed version lacks the bullet dots. Bulleted lists work fine in regular posts on my forum.

SMF 2.1 RC1, TP 1.6.2
Title: Re: Bulleted lists in articles?
Post by: tino on February 24, 2019, 07:15:40 AM
BBC or HTML articles?
Title: Re: Bulleted lists in articles?
Post by: tino on February 24, 2019, 08:15:39 AM
The SMF css removes the bullet points from UL and LI lists, we need to enable it again on article_inner ul, li lists.


.article_inner ul
{
    list-style: unset !important;
}
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 24, 2019, 08:26:03 AM
Seems to be happening on HTML articles only...

I think I remember having some issues with the 2.1 css behaving differently from 2.0 before. Can't recall if I saw this one before...
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 24, 2019, 08:40:57 AM
Quote from: @rjen on February 24, 2019, 08:26:03 AM

Seems to be happening on HTML articles only...


The BBC article seem to just output the BBCode when I view the article. Looks fine while typing.

The HTML one looks fine while typing but loses the bullets when viewing the article.

We seem to have plagued with the bullets issue ever since we first went responsive. lol.. There's various posts on here about that.
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 24, 2019, 09:06:57 AM
I know now :  even before going responsive, when I first installed Illori's TP version for 2.0 this popped up: I applied a css class to my <ul>  elements then to prepare for 2.1 migration...

Mind you: that was years ago now...
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 24, 2019, 10:28:13 AM
Quote from: tino on February 24, 2019, 08:15:39 AM
The SMF css removes the bullet points from UL and LI lists, we need to enable it again on article_inner ul, li lists.


.article_inner ul
{
    list-style: unset !important;
}


testing that, but now I have the problem with <ol>

unsetting the list-style is also unsetting the list-style-type from decimal...
Title: Re: Bulleted lists in articles?
Post by: tino on February 24, 2019, 10:32:30 AM
SMF should really only target the element they want rather than the blanket one... we are limited in what we can do.
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 24, 2019, 10:50:31 AM
Well this seems to fix most of it...

.article_inner ul
{
    list-style: unset !important;
}
.article_inner ol
{
    list-style-type: decimal;
}
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 24, 2019, 10:57:28 AM
Quote from: tino on February 24, 2019, 10:32:30 AM
SMF should really only target the element they want rather than the blanket one... we are limited in what we can do.

Illori raised this issue 3 years ago and it was shot down...

https://github.com/SimpleMachines/SMF2.1/issues/3255
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 24, 2019, 11:52:37 AM
Quote from: @rjen on February 24, 2019, 10:57:28 AM
Quote from: tino on February 24, 2019, 10:32:30 AM
SMF should really only target the element they want rather than the blanket one... we are limited in what we can do.

Illori raised this issue 3 years ago and it was shot down...

https://github.com/SimpleMachines/SMF2.1/issues/3255

I'm afraid , once a certain person digs their heels in you've got very little chance of changing something.

Does seem a bit bad that it's such a global element. There's a few in there which I found while playing with themes. like,

.hidden {
display: none;
}


Which completely upsets the board stats and throws them out of line when you have no posts in those boards, or a redirect board.
Title: Re: Bulleted lists in articles?
Post by: tino on February 24, 2019, 12:11:59 PM
Quote from: lurkalot on February 24, 2019, 11:52:37 AM

I'm afraid , once a certain person digs their heels in you've got very little chance of changing something.


That applies to pretty much every contributer on the SMF team  ::)

Not that I can be any better when I want to develop something, I tend to do it my way... its a inherent character flaw in most developers.
Title: Re: Bulleted lists in articles?
Post by: illori on February 24, 2019, 06:49:44 PM
Quote from: @rjen on February 24, 2019, 10:57:28 AM
Quote from: tino on February 24, 2019, 10:32:30 AM
SMF should really only target the element they want rather than the blanket one... we are limited in what we can do.

Illori raised this issue 3 years ago and it was shot down...

https://github.com/SimpleMachines/SMF2.1/issues/3255


has been reopened for further discussion.
please add your thoughts.
Title: Re: Bulleted lists in articles?
Post by: sremick on February 25, 2019, 04:33:41 AM
FYI... changing the article type to BBC (from HTML) provided some whitespace spacing between the list items, but the bullet circles are still missing.
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 25, 2019, 07:55:42 PM
Quote from: illori on February 24, 2019, 06:49:44 PM
Quote from: @rjen on February 24, 2019, 10:57:28 AM
Quote from: tino on February 24, 2019, 10:32:30 AM
SMF should really only target the element they want rather than the blanket one... we are limited in what we can do.

Illori raised this issue 3 years ago and it was shot down...

https://github.com/SimpleMachines/SMF2.1/issues/3255


has been reopened for further discussion.
please add your thoughts.

I have a feeling this isn't going to go our way.  Looks like it's down to the mod authors to work around it.  :(
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 25, 2019, 10:12:25 PM
I do not expect a correction from TP: I just committed a css fix for Tinyportal...

QuoteFYI... changing the article type to BBC (from HTML) provided some whitespace spacing between the list items, but the bullet circles are still missing.

If you just change the article type the html codes will remain in the article, and the problem persists: you will als have to update the html tags to bbc tags manually for them to take effect...
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 25, 2019, 10:40:33 PM
Quote from: @rjen on February 25, 2019, 10:12:25 PM
I do not expect a correction from TP: I just committed a css fix for Tinyportal...

QuoteFYI... changing the article type to BBC (from HTML) provided some whitespace spacing between the list items, but the bullet circles are still missing.

If you just change the article type the html codes will remain in the article, and the problem persists: you will als have to update the html tags to bbc tags manually for them to take effect...

Thanks @rjen

Just tested that code on my local. Seems to fix the bullets on my html articles.

The bbc articles I'm still having a problem with, It's fine when you're editing, but it just shows the bbcode code when viewing the article.  They were messing about with bbcode in 2.1 I'm wondering if this is the result of that.

[ul]
[li]one[/li]
[li]two[/li]
[li]three[/li]
[/ul]



[ol]
[li]one[/li]
[li]two[/li]
[li]three


[/li]
[/ol]
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 26, 2019, 05:44:47 AM
BBC still works fine for me. Did you update SMF from github recently?
Title: Re: Bulleted lists in articles?
Post by: sremick on February 26, 2019, 05:46:17 AM
Cleaning out the HTML and adding in the BBC equivalents from scratched resolved this for me.
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 26, 2019, 06:25:20 AM
Quote from: @rjen on February 26, 2019, 05:44:47 AM
BBC still works fine for me. Did you update SMF from github recently?

Nope, just running RC1 Release atm, haven't done any updating since, and was just awaiting RC2.
Title: Re: Bulleted lists in articles?
Post by: @rjen on February 26, 2019, 06:41:20 AM
I see what you mean, but tbf: is that proper bbc code?

When I paste your code in bbc article and view I get what you get, then I open the article again and it is automatically changed to what I was expecting...


[list]
[li]one[/li]
[li]two[/li]
[li]three[/li]
[/list]

[list type=decimal]
[li]one[/li]
[li]two[/li]
[li]three[/li]
[/list]


Then it shows..
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 26, 2019, 06:47:48 AM
Quote from: @rjen on February 26, 2019, 06:41:20 AM
I see what you mean, but tbf: is that proper bbc code?

When I paste your code in bbc article and view I get what you get, then I open the article again and it is automatically changed to what I was expecting...


[list]
[li]one[/li]
[li]two[/li]
[li]three[/li]
[/list]

[list type=decimal]
[li]one[/li]
[li]two[/li]
[li]three[/li]
[/list]


Then it shows..

That was the code my bbc editor put in, I grabbed it from the view article page.

Does the same on my live test site, as you can see here, https://cctestsite.info/testsite3/index.php?page=3
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 26, 2019, 07:26:05 AM
I'll update my TP install tonight and see what happens.
Title: Re: Bulleted lists in articles?
Post by: lurkalot on February 26, 2019, 05:51:33 PM
Quote from: lurkalot on February 26, 2019, 07:26:05 AM
I'll update my TP install tonight and see what happens.

Still the same problem with lists in bbc blocks..

What version of 2.1 are you guys running, I mean is it the release version of 2.1 RC1 or are you running slightly later one from GitHub?


Edit:  I take that back, it seems to be working now. I'll update my live TS and see if that works as well.