TinyPortal

Development => Bugs/Errors => Feedback => Fixed Bugs => Topic started by: thedukeisnotdead on November 28, 2020, 06:36:20 AM

Title: 8: Undefined index: QUERY_STRING File: Integrate.php Line: 38
Post by: thedukeisnotdead on November 28, 2020, 06:36:20 AM
Link to my forum: http://www.the-new-lair.com/forum/
SMF version: 2.0.17
TP version: 2.0.0
Default Forum Language: english
Theme name and version: BR Finale 2011 by, Crip
Browser Name and Version: Safari
Mods installed:
TinyPortal   2.0.0,
Simple Audio Video Embedder   5.1.5,
SMF Arcade   2.6.3,
SMF Gallery Pro   9.0beta2a     
Related Error messages:    
Guest
Today at 01:22:32 AM
Type of error: Undefined
http://the-new-lair.com/index.php?
8: Undefined index: QUERY_STRING
File: /hermes/bosnaweb23a/b64/apo.ladyd/forum/TinyPortal/Integrate.php
Line: 38
Title: Re: 8: Undefined index: QUERY_STRING File: Integrate.php Line: 38
Post by: @rjen on November 28, 2020, 07:39:58 AM
Hi,

thanks for the report. I changed your report a little to make the error log section readable.

I have not seen that error before anywhere, but when I visited the link you posted (http://www.the-new-lair.com/forum/) I am not finding any forum. The forum seems to run fine at http://www.the-new-lair.com.

Did you move the forum from subdomain forum to the root recently? If so was that before or after you got this error?
Title: Re: 8: Undefined index: QUERY_STRING File: Integrate.php Line: 38
Post by: tino on November 28, 2020, 11:37:19 AM
I think they have QUERY_STRING disabled in their security settings for Apache/nginx.

I'll add a check to make sure it's set.
Title: Re: 8: Undefined index: QUERY_STRING File: Integrate.php Line: 38
Post by: @rjen on November 28, 2020, 11:55:17 AM
Quote from: tino on November 28, 2020, 11:37:19 AM
I think they have QUERY_STRING disabled in their security settings for Apache/nginx.

I'll add a check to make sure it's set.

I would expect that to give more issues then just in TP?
Title: Re: 8: Undefined index: QUERY_STRING File: Integrate.php Line: 38
Post by: tino on November 28, 2020, 12:33:50 PM
Quote from: @rjen on November 28, 2020, 11:55:17 AM
Quote from: tino on November 28, 2020, 11:37:19 AM
I think they have QUERY_STRING disabled in their security settings for Apache/nginx.

I'll add a check to make sure it's set.

I would expect that to give more issues then just in TP?

This is in QueryString.php

<?php
    
// Get the correct query string.  It may be in an environment variable...
    
if (!isset($_SERVER['QUERY_STRING']))
        
$_SERVER['QUERY_STRING'] = getenv('QUERY_STRING')


This is after we do our checks as we want to rewrite things before cleanRequest is called. So it's filled in that way.
Title: Re: 8: Undefined index: QUERY_STRING File: Integrate.php Line: 38
Post by: @rjen on November 28, 2020, 05:39:07 PM
So it is fixed for 2.0.1, but it would be nice to get a confirmation from the OP... I cannot reproduce the issue