Login  |  Register
* *
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

User

Welcome, Guest. Please login or register.
Did you miss your activation email?

August 12, 2022, 09:43:21 AM

Login with username, password and session length

Stats

Members
  • Total Members: 3842
  • Latest: Kokoro
Stats
  • Total Posts: 193479
  • Total Topics: 21088
  • Online today: 50
  • Online ever: 1035
  • (November 26, 2020, 04:45:12 AM)
Users Online
Users: 0
Guests: 48
Total: 48

« previous next »
Pages: 1 [2] 3  All   Go Down

Author Topic: ElkArte TinyPortal Layout & Design  (Read 1220 times)

0 Members and 1 Guest are viewing this topic.

Offline McFly

  • Jr. Member
  • **
  • Posts: 71
    • Die Annoholiker
Re: ElkArte TinyPortal Layout & Design
« Reply #10 on: March 30, 2022, 09:58:49 AM »
It's really not good when I have too much spare time ...  :2funny:

I have revised the category list again and also adapted the article list in the same way. No more tables, no inline styles and similar to ELK.
Logged
"I'm not going to censor myself to comfort your ignorance."

Testsites (may be online or not ;-) )
ElkArte 1.1.x & TP on Apache2.4.48, PHP 8.1.2 FPM/FastCGI, MariaDB 10.5.12

Offline tino

  • Developer
  • *
  • Posts: 2613
Re: ElkArte TinyPortal Layout & Design
« Reply #11 on: March 30, 2022, 11:01:14 AM »
Thanks! I'll push these to github later this week.

Are all the changes included in the latest zip file? Or do I need to apply them in order.
Logged

Offline McFly

  • Jr. Member
  • **
  • Posts: 71
    • Die Annoholiker
Re: ElkArte TinyPortal Layout & Design
« Reply #12 on: March 30, 2022, 11:31:50 AM »
Quote from: tino on March 30, 2022, 11:01:14 AM
...

Are all the changes included in the latest zip file? Or do I need to apply them in order.
The latest zip file always contains the previous changes.
Logged
"I'm not going to censor myself to comfort your ignorance."

Testsites (may be online or not ;-) )
ElkArte 1.1.x & TP on Apache2.4.48, PHP 8.1.2 FPM/FastCGI, MariaDB 10.5.12

Offline McFly

  • Jr. Member
  • **
  • Posts: 71
    • Die Annoholiker
Re: ElkArte TinyPortal Layout & Design
« Reply #13 on: March 31, 2022, 04:24:36 AM »
There is more to come! Have now finished work ...

Again a few typos. For this I have - with one exception - all <strong></strong> replaced by the class strong. But for this to work, a bug in ELK's index.css has to be fixed first. Around the line 750 a dot has been forgotten there before the class.
Logged
"I'm not going to censor myself to comfort your ignorance."

Testsites (may be online or not ;-) )
ElkArte 1.1.x & TP on Apache2.4.48, PHP 8.1.2 FPM/FastCGI, MariaDB 10.5.12

Offline tino

  • Developer
  • *
  • Posts: 2613
Re: ElkArte TinyPortal Layout & Design
« Reply #14 on: March 31, 2022, 05:13:45 AM »
Quote from: McFly on March 31, 2022, 04:24:36 AM
But for this to work, a bug in ELK's index.css has to be fixed first. Around the line 750 a dot has been forgotten there before the class.

We can't rely on that being fixed, so will have to have our own tp override. Or similar.
Logged

Offline McFly

  • Jr. Member
  • **
  • Posts: 71
    • Die Annoholiker
Re: ElkArte TinyPortal Layout & Design
« Reply #15 on: March 31, 2022, 05:58:32 AM »
Quote from: tino on March 31, 2022, 05:13:45 AM
...

We can't rely on that being fixed, so will have to have our own tp override. Or similar.
For this I have just added a class in the tp-styles. The file will be available later.

By the way, I also just found the thing with the inline styles of "tp-left/rightbarheader"! They are hidden in the HTML header as scripts. Are defined in "Subs.php" from line 75.

EDIT:

Cleaned out the CSS itself a bit and added the "strong" class.
« Last Edit: April 01, 2022, 02:51:53 AM by McFly »
Logged
"I'm not going to censor myself to comfort your ignorance."

Testsites (may be online or not ;-) )
ElkArte 1.1.x & TP on Apache2.4.48, PHP 8.1.2 FPM/FastCGI, MariaDB 10.5.12

Offline @rjen

  • Support Team
  • *
  • Posts: 3285
    • FJR-club Nederland
Re: ElkArte TinyPortal Layout & Design
« Reply #16 on: March 31, 2022, 10:44:39 AM »
Just a warning (have not checked the css yet) but if you are using very common class names (such as strong or float left) it is advisable to create distinct class names , such as tp_strong or tp_floatleft to prevent issues with conflicting class names in themes or other mods …
« Last Edit: March 31, 2022, 11:13:17 AM by @rjen »
Logged
Running Latest TP on SMF2.1 at: www.fjr-club.nl

Testing TP on SMF2.0
Testing TP on SMF2.1 (latest Github)
Want to check what php version I am testing on? See: PHP Info

Offline McFly

  • Jr. Member
  • **
  • Posts: 71
    • Die Annoholiker
Re: ElkArte TinyPortal Layout & Design
« Reply #17 on: April 01, 2022, 01:53:54 AM »
Quote from: @rjen on March 31, 2022, 10:44:39 AM
Just a warning (have not checked the css yet) but if you are using very common class names (such as strong or float left) …
I definitely spent too much time in front of the monitor yesterday! Or: when you can't see the forest for the trees.  :doh:

Good that I have again slept a night over it. It is of course NOT an error in the CSS of ELK. I will revise the files again.

EDIT: Attached zip file replaced.
Logged
"I'm not going to censor myself to comfort your ignorance."

Testsites (may be online or not ;-) )
ElkArte 1.1.x & TP on Apache2.4.48, PHP 8.1.2 FPM/FastCGI, MariaDB 10.5.12

Offline McFly

  • Jr. Member
  • **
  • Posts: 71
    • Die Annoholiker
Re: ElkArte TinyPortal Layout & Design
« Reply #18 on: April 05, 2022, 02:11:39 AM »
Just a small revision of the category and article list, CSS adjustment.
Logged
"I'm not going to censor myself to comfort your ignorance."

Testsites (may be online or not ;-) )
ElkArte 1.1.x & TP on Apache2.4.48, PHP 8.1.2 FPM/FastCGI, MariaDB 10.5.12

Offline tino

  • Developer
  • *
  • Posts: 2613
Re: ElkArte TinyPortal Layout & Design
« Reply #19 on: April 05, 2022, 02:34:01 AM »
Thanks, I'll get this checked in to git today hopefully!
Logged
Pages: 1 [2] 3  All   Go Up
« previous next »