Avatar by URL not working in Article Comments

[tino]

Works via the proxy for me, can you see if the fix I posted fixes your issue also?

[@rjen]

As you both seem to have reported different errors.

The uploaded ones work, the stock smf ones work, but if you add one via url it doesn't show in comments, but shows everywhere else in the portal.

Just tried that. URL avatar IS showing on my test site...

[lurkalot]

I'm not using proxy, it's just a local http test site.

[tino]

I'm not using proxy, it's just a local http test site.

Can you try the fix a few posts back. It should sort it as both issues are linked

[lurkalot]

Sort it, as in remove them? I don't seem to have any avatars in comments now. Also the new post image has popped up. should I be seeing this as I was the one who posted?

[tino]

Sort it, as in remove them? I don't seem to have any avatars in comments now. Also the new post image has popped up. should I be seeing this as I was the one who posted?

It didn't remove them for me. I guess you either didn't edit it correctly or I posted the wrong thing.

It's adding the $avatar == after the first = and before the ''

[lurkalot]

As far as I can see I've edited it correctly. Attached below.

[@rjen]

I'm not using proxy, it's just a local http test site.

Can you try the fix a few posts back. It should sort it as both issues are linked

I tried your fix too, and the result is that in the first comment the Avatar shows, but in the second comment (same user) it does NOT...

[tino]

Try this code

Code Select Expand


if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false)
      $avatar = '<img src="'. $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret) .'" alt="&nbsp;" />';
else
      $avatar = $row['avatar'] == '' ? ($row['ID_ATTACH'] > 0 ? '<img src="' . (empty($row['attachmentType']) ? $scripturl . '?action=dlattach;attach=' . $row['ID_ATTACH'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $row['filename']) . '" alt="&nbsp;"  />' : '') : (stristr($row['avatar'], 'https://') ? '<img src="' . $row['avatar'] . '" alt="&nbsp;" />' : stristr($row['avatar'], 'http://') ? '<img src="' . $row['avatar'] . '" alt="&nbsp;" />' : '<img src="' . $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($row['avatar'], ENT_QUOTES) . '" alt="&nbsp;" />');


[@rjen]

Try this code

Code Select Expand


if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false)
      $avatar = '<img src="'. $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret) .'" alt="&nbsp;" />';
else
      $avatar = $row['avatar'] == '' ? ($row['ID_ATTACH'] > 0 ? '<img src="' . (empty($row['attachmentType']) ? $scripturl . '?action=dlattach;attach=' . $row['ID_ATTACH'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $row['filename']) . '" alt="&nbsp;"  />' : '') : (stristr($row['avatar'], 'https://') ? '<img src="' . $row['avatar'] . '" alt="&nbsp;" />' : stristr($row['avatar'], 'http://') ? '<img src="' . $row['avatar'] . '" alt="&nbsp;" />' : '<img src="' . $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($row['avatar'], ENT_QUOTES) . '" alt="&nbsp;" />');


That fixes the problem for me.