We noticed that insering images in a TP article from the quicklist does not work anymore in the new editor?
Using "My Images Quicklist"...
It used to be possible to upload an image into the quicklist, and insert it in the article by double-clicking the image. This is no longer working...
I believe a saw a comment before about a diffent approach to adding images in articles with the enw editor?
Using Chrome by the way...
Quote from: @rjen on February 17, 2018, 10:09:40 AM
We noticed that insering images in a TP article from the quicklist does not work anymore in the new editor?
Using "My Images Quicklist"...
It used to be possible to upload an image into the quicklist, and insert it in the article by double-clicking the image. This is no longer working...
I believe a saw a comment before about a diffent approach to adding images in articles with the enw editor?
Using Chrome by the way...
You can drag the image up, but that still doesn't quite work correctly.
There is a new drag and drop option for the SCEditor in the next release.
When I drag and drop it drops the thumbnail, not the large image. Is that what You mean?
Quote from: tino on February 17, 2018, 10:35:08 AM
Quote from: @rjen on February 17, 2018, 10:09:40 AM
We noticed that insering images in a TP article from the quicklist does not work anymore in the new editor?
Using "My Images Quicklist"...
It used to be possible to upload an image into the quicklist, and insert it in the article by double-clicking the image. This is no longer working...
I believe a saw a comment before about a diffent approach to adding images in articles with the enw editor?
Using Chrome by the way...
You can drag the image up, but that still doesn't quite work correctly.
There is a new drag and drop option for the SCEditor in the next release.
Yes, you can drag and drop them from the quicklist into the editor. Or drag them directly from a images folder on your pc, to the editor. Applies to 1.4R.
I believe in TP 1.5.0 we will be able to drag images directly from a folder on pc, and the images will also be added to the quicklist, so you add them from there as well.
Quote from: @rjen on February 17, 2018, 10:44:27 AM
When I drag and drop it drops the thumbnail, not the large image. Is that what You mean?
Yes, it doesn't quite work as I would expect.
Works as intended regarding that part, the description clearly says,
"My Images Quicklist
The images below are small thumbnails of the original pictures. "
Anything uploaded to the quicklist via the browse button will ad a thumbnail image to the quick list. The clicking to add to the editor doesn't work, drag and drop does.
True, but it doesn't expand when you click on it like it used to ( I assume it did, I never tried it).
Although that's not part of the description, it is a change in behaviour.
Quote( I assume it did, I never tried it).
It did, I just tested it in 1.3 to be sure.
With this change in behaviour the explanation text in the edit article page is a bit confusing (The images below are small thumbnails of the original pictures. By clicking them the picture is inserted into the editor. Be sure to click in the editor to make it active before selecting any of the images.)
With the new behaviour the 'My Images Quicklist' in this setup is not usable, since it displays thumbnails and not the full image. Perhaps an idea to change this Quicklist to no longer display the thumbnail but the actual image (resized by css?). With this the explanation text would need to be updated to explain the drag-and-drop behavior...
Quote from: @rjen on February 17, 2018, 11:19:42 AM
Quote( I assume it did, I never tried it).
It did, I just tested it in 1.3 to be sure.
With this change in behaviour the explanation text in the edit article page is a bit confusing (The images below are small thumbnails of the original pictures. By clicking them the picture is inserted into the editor. Be sure to click in the editor to make it active before selecting any of the images.)
With the new behaviour the 'My Images Quicklist' in this setup is not usable, since it displays thumbnails and not the full image. Perhaps an idea to change this Quicklist to no longer display the thumbnail but the actual image (resized by css?). With this the explanation text would need to be updated to explain the drag-and-drop behavior...
Agreed, we need to change the description, but first we need to get a system that works easily. This quicklist idea has always been a bit hit and miss since day one. It's been something on my wish list for ages. A image manager = Some way to upload and find images to use in articles and blocks, or even forum posts, come to think of it.
Try the attached file with fixes to the various issues raised today.
Rename the .zip to .tar.gz as I can't upload it as a .tar.gz
Quote from: tino on February 17, 2018, 11:43:59 AM
Try the attached file with fixes to the various issues raised today.
Rename the .zip to .tar.gz as I can't upload it as a .tar.gz
Is this 1.4 or 1.5?
Quote from: @rjen on February 17, 2018, 11:44:43 AM
Quote from: tino on February 17, 2018, 11:43:59 AM
Try the attached file with fixes to the various issues raised today.
Rename the .zip to .tar.gz as I can't upload it as a .tar.gz
Is this 1.4 or 1.5?
It's labelled as 1.4.1, so 1.4 with just the fixes for the avatar, article comments and drag and drop.
You want me to upload it here in this thread? I'll call it 1.4Rev1 for now, yes? Until all the versions changes are done at least.
I see you missed the fix of TPsub.template.php for PHP 7.1
File: /home/deb77453/domains/fjr-club.nl/public_html/test/Themes/default/TPsubs.template.php
Line: 1799
Apart from that nice fix!
Quote from: @rjen on February 17, 2018, 12:08:10 PM
Apart from that nice fix!
@rjen What fix are you referring to?
Got a bit of aa shock when I first uploaded a pic to the quicklist in this version, it was massive. Ctrl + F5 sorted it, although the thumbs are all different sizes.
Also dragging a image directly into the edit window now seem to open a the image in a browser window instead of adding it to the article.
No image quicklist, or upload facility for bbc articles using this system.
Quote from: @rjen on February 17, 2018, 12:08:10 PM
I see you missed the fix of TPsub.template.php for PHP 7.1
File: /home/deb77453/domains/fjr-club.nl/public_html/test/Themes/default/TPsubs.template.php
Line: 1799
Apart from that nice fix!
Yup, forgot that one! I'll sort that now. Probably as it wasn't in this bug forum list. :-[
PHP 7 issue fixed and also force reload of css now. O0
Same as before rename the .zip to .tar.gz, would be nice if SMF could recognise mac .zip files mind.
Quote from: lurkalot on February 17, 2018, 12:20:24 PM
No image quicklist, or upload facility for bbc articles using this system.
It didn't have one before I thought?
Quote from: tino on February 17, 2018, 12:31:49 PM
Quote from: lurkalot on February 17, 2018, 12:20:24 PM
No image quicklist, or upload facility for bbc articles using this system.
It didn't have one before I thought?
Correct, it didn't. I was thinking aloud again. ;) Now where me scratches chin smiley. :hmm:
Quote from: lurkalot on February 17, 2018, 12:20:24 PM
Also dragging a image directly into the edit window now seem to open a the image in a browser window instead of adding it to the article.
I don't get this, it base64 encodes the image for me. If you did it on your old test site where 1.5.0 was installed it might be due to the javascript being cached.
Quote from: tino on February 17, 2018, 12:34:58 PM
Quote from: lurkalot on February 17, 2018, 12:20:24 PM
Also dragging a image directly into the edit window now seem to open a the image in a browser window instead of adding it to the article.
I don't get this, it base64 encodes the image for me. If you did it on your old test site where 1.5.0 was installed it might be due to the javascript being cached.
This might be a IE11 thing actually, doesn't do it in Edge, in edge I just get a warning icon, like a no entry sign when I try to drag one from PC folder to editor.
Technically drag and drop isn't supported in this version. The fact it base64 encodes the image when I do it suggests it's not the best way to do it anyway.
Drag & drop works nicely now. I just noticed something funny:
Drag & drop from quicklist = OK
Drag & drop from https location = OK
Drag & drop from http location = image NOT shwoing in the editor, but it IS showing in the article...
See images below.
That will be due to when its in the article it goes via the proxy.
If you edit it after saving does it show the image ok? I can't really change that as I think you will see a error in the browser console if you have that open.
Yes, it does, edit the article code afterwards and it still shows in the site.
If this cannot be solved I assume it is not a big issue (at least not for me): http sites will become extinct in the near future anyway...
[EDIT] Just relalized why this happens: Chrome is not showing the mixed content again (like before), when I 'trust' my test site the images show up in the editor too...
Nothing for you to fix here...
I'll breach this one again, because I can't remember if you mentioned a solution for this. How are we going to delete pics from the quicklist? If you just delete them via ftp (which to me is less than ideal), will this have any affect on the system.
I guess this will be 1.5 territory?
What would be Nice is a delete option (x) on each image in the quick list ...
Quote from: @rjen on February 17, 2018, 01:15:21 PM
I guess this will be 1.5 territory?
What would be Nice is a delete option (x) on each image in the quick list ...
Absolutely. The only thing is where the same image is used in more than one article, you might delete the image from that article without realising. Then again you can't cater for everything. I'm a firm believer, that if a system makes it easy for you to upload stuff it should also be able to clean up after itself.
My findings using various browsers.
Drag and drop from PC images folder to the editor works for me in Firefox, and Chrome, but not for IE11 or Edge.
Drag and drop from quicklist to editor, seems to work in all those browsers.
Quote from: @rjen on February 17, 2018, 01:15:21 PM
I guess this will be 1.5 territory?
Correct this is 1.5 with the new drag and drop functionality.
Quote from: lurkalot on February 17, 2018, 01:28:14 PM
Drag and drop from quicklist to editor, seems to work in all those browsers.
As this is all we officially support in 1.4.x then I'll leave it.
Split the topic to https://www.tinyportal.net/index.php?topic=35992
Before I zip 141 up, just wondering, was there anything done to avatar width / height in 141 ? They all appear square everywhere except the user block, where it's stretched out of proportion. You can see on the left hand side of this screenshot.
Quote from: lurkalot on February 17, 2018, 10:21:24 PM
Before I zip 141 up, just wondering, was there anything done to avatar width / height in 141 ? They all appear square everywhere except the user block, where it's stretched out of proportion. You can see on the left hand side of this screenshot.
Yeh it was changed to fix @rjen's issue. Seems it's introduced the old issue. I'll have a think about it.
I'll create a pull request against the main repo tomorrow and we'll use that as a zip.
Quote from: tino on February 17, 2018, 10:24:40 PM
Quote from: lurkalot on February 17, 2018, 10:21:24 PM
Before I zip 141 up, just wondering, was there anything done to avatar width / height in 141 ? They all appear square everywhere except the user block, where it's stretched out of proportion. You can see on the left hand side of this screenshot.
Yeh it was changed to fix @rjen's issue. Seems it's introduced the old issue. I'll have a think about it.
I'll create a pull request against the main repo tomorrow and we'll use that as a zip.
Thanks, yep that'll be fine I can zip it up from there no problem. Just give me a nod. ;)