TP-Docs
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

Welcome to TinyPortal. Please login or sign up.

March 28, 2024, 08:36:29 AM

Login with username, password and session length
Members
Stats
  • Total Posts: 195,104
  • Total Topics: 21,212
  • Online today: 174
  • Online ever: 3,540 (September 03, 2022, 01:38:54 AM)
Users Online
  • Users: 0
  • Guests: 176
  • Total: 176

Link goes no where

Started by bigguy, December 03, 2018, 03:04:29 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

@rjen

It's definitely an improvement...

see here: https://test2.fjr-club.nl/index.php

Now the other links in the postings are clickable again..

Before you submit the change, would you mind to include class="tp_readmore" ? I added that to the css to force enough margin for the Read More links...


$row['body'] .= '... <p class="tp_readmore"><strong>'.$smcFunc['htmlspecialchars']('<a href="'. $scripturl. '?topic='. $row['id']. '">'. $txt['tp-readmore']. '</a>').'</strong></p>';
Running Latest TP on SMF2.1 at: www.fjr-club.nl

lurkalot

Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

@rjen

Quote from: lurkalot on December 03, 2018, 07:40:19 PM
Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

The css for that is still waiting to be merged...
Running Latest TP on SMF2.1 at: www.fjr-club.nl

lurkalot

Quote from: @rjen on December 03, 2018, 07:43:33 PM
Quote from: lurkalot on December 03, 2018, 07:40:19 PM
Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

The css for that is still waiting to be merged...

Wasn't sure if anything else was going in, so held off.  I edited the file on my site manually.

I can merge now if you wish.  ;)

@tino. Was wondering if there's anything here that shines some light on the 2.1 bbc problems, https://github.com/SimpleMachines/SMF2.1/search?q=bbc&type=Issues

lurkalot

Quote from: @rjen on December 03, 2018, 07:43:33 PM
Quote from: lurkalot on December 03, 2018, 07:40:19 PM
Added it here, this is with the include class="tp_readmore" added. http://cctestsite.info/testsite3/index.php

The css for that is still waiting to be merged...

Those last pull requests, do they contain the fix for the read more links that tino posted, plus some more from yourself?

Just I tried it and they are broken again.

tino

Just pushed a commit which should sort it for SMF 2.0 and SMF 2.1 it's the more elegant way to do the fix anyway. Shouldn't break anything backwards compatible mind. Also incremented all the version numbers to 1.6.2

@rjen

The two PR together should make the fix, but I think the ... should have remained in the body text....

Running Latest TP on SMF2.1 at: www.fjr-club.nl

lurkalot

Thanks guys. Installed on my live 2.1 test site now, seems good atm. http://cctestsite.info/testsite3/index.php

Also added a beta topic for 1.6.2 and included the zip.  ;)

@rjen

Missing the spacing between the body and read more text though...
Running Latest TP on SMF2.1 at: www.fjr-club.nl

lurkalot

Quote from: @rjen on December 04, 2018, 06:54:35 AM
Missing the spacing between the body and read more text though...

Looks ok to me.  ??? Got a screenshot of what it looks like, and what it should look like for comparison?