TinyPortal

Development => Bugs/Errors => Feedback => Fixed Bugs => Topic started by: @rjen on August 02, 2018, 10:18:58 PM

Title: Intro text bbc articles getting line feeds
Post by: @rjen on August 02, 2018, 10:18:58 PM
Noticed something funny with the short text for bbc articles. It seems to be setting line feeds based on the size of the entry screen...

Example: https://test.fjr-club.nl/index.php?cat=Nieuws

I created the article on my iPhone : the short text is line feeded by the screen size : this is not intentional!
When I create the text in landscape format it does the same but with longer lines...

This does not seem to occur with html articles..,
Title: Re: Intro text bbc articles getting line feeds
Post by: tino on August 02, 2018, 11:01:19 PM
The bbc editor is the one from SMF? Does the standard forum post exhibit the same issue?
Title: Re: Intro text bbc articles getting line feeds
Post by: @rjen on August 02, 2018, 11:08:27 PM
Quote from: tino on August 02, 2018, 11:01:19 PM
The bbc editor is the one from SMF? Does the standard forum post exhibit the same issue?

No it does not. Btw the ' intro text field'. Does not really have a editor I believe...
It's the one in attached screenshot...

Title: Re: Intro text bbc articles getting line feeds
Post by: lurkalot on August 03, 2018, 08:13:56 AM
Quote from: @rjen on August 02, 2018, 11:08:27 PM
Quote from: tino on August 02, 2018, 11:01:19 PM
The bbc editor is the one from SMF? Does the standard forum post exhibit the same issue?

No it does not. Btw the ' intro text field'. Does not really have a editor I believe...
It's the one in attached screenshot...

Ooh, nasty.  @rjen, was the text in the intro copied and pasted from the text in the bbc editor above? or was it typed?  What happens if you save the article, preview it, and then grab that text from the main article and paste it into the intro?

EDIT: Ignore that last question, I can see it doesn't make a difference.  I can replicate the problem on my Laptop using Chrome Window Resizer. Here's a screenshot  of an older intro done on my laptop at full screen, and a new one using he window resizer.

And another screenshot, when I go back and visit the edit page via my laptop at normal rez.
Title: Re: Intro text bbc articles getting line feeds
Post by: tino on August 03, 2018, 02:17:41 PM
Ok only occurs in Chrome it seems.

https://github.com/tinoest/TinyPortal/commit/bad785e5e1566be72b30a4c8c75e77f8734c8235

Fixes the issue.
Title: Re: Intro text bbc articles getting line feeds
Post by: @rjen on August 03, 2018, 02:21:10 PM
Quote from: tino on August 03, 2018, 02:17:41 PM
Ok only occurs in Chrome it seems.

https://github.com/tinoest/TinyPortal/commit/bad785e5e1566be72b30a4c8c75e77f8734c8235

Fixes the issue.

In my case it happened in Safari as well.
Mick, I found it in working on the docs site. Any chance to put the fix there ?
Title: Re: Intro text bbc articles getting line feeds
Post by: lurkalot on August 03, 2018, 05:57:02 PM
Quote from: @rjen on August 03, 2018, 02:21:10 PM
Quote from: tino on August 03, 2018, 02:17:41 PM
Ok only occurs in Chrome it seems.

https://github.com/tinoest/TinyPortal/commit/bad785e5e1566be72b30a4c8c75e77f8734c8235

Fixes the issue.

In my case it happened in Safari as well.
Mick, I found it in working on the docs site. Any chance to put the fix there ?

Added the fix over there now.  Though it was different line numbers from the ones shown in the repo.

It was on lines,

2253 and 2265
Title: Re: Intro text bbc articles getting line feeds
Post by: tino on August 03, 2018, 06:01:21 PM
Probably would be as that repo includes the other changes I made to the menu manager.
Title: Re: Intro text bbc articles getting line feeds
Post by: @rjen on August 03, 2018, 06:05:31 PM
Just checked it on the shoutbox document and the problem is solved!
Title: Re: Intro text bbc articles getting line feeds
Post by: lurkalot on August 03, 2018, 06:16:54 PM
Quote from: tino on August 03, 2018, 06:01:21 PM
Probably would be as that repo includes the other changes I made to the menu manager.

Thanks, I thought that might be the case.  ;)

Quote from: @rjen on August 03, 2018, 06:05:31 PM
Just checked it on the shoutbox document and the problem is solved!

Cool.  Thanks for letting us know.  :tick:
Title: Re: Intro text bbc articles getting line feeds
Post by: @rjen on September 19, 2018, 09:43:01 PM
Fixed in the newest version of TP