TinyPortal

Development => Feedback => Bugs/Errors => Topic started by: Akyhne on March 29, 2009, 03:23:11 PM

Title: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 03:23:11 PM
TP 1.0 beta 3 (and also this forum running 1.0 beta 4)

Whenever a user is watching the forums frontpage, like:
http://www.tinyportal.net/index.php?action=forum

... the status of the person is 'unknown action'.

This has been bothering me for some time, so if you have a quick fix, I would be glad to receive the fix.
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 29, 2009, 04:21:15 PM
The status of the user is a SMF function and not a TP unique function. Have you asked this question at SMF?
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 04:27:41 PM
I only have the issue with TP installed, and as mentioned the error is also here in this forum.
And is action='forum' part of the standalone SMF? I don't think so, but could be wrong.
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 04:47:46 PM
Everything that is related to action='forum' is TP related. There's just no relation to it in the who file.
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 29, 2009, 04:49:11 PM
Well when i go to your profile and look at the status is has online, not unknown.... is that what you are referring to?
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 04:51:42 PM
No, I will go to "http://www.tinyportal.net/index.php?action=forum" after posting this, and you will see my status as 'unknown action'.
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 29, 2009, 04:56:56 PM
I just looked at your status and it has online.

Where are you referring to seeing "uknown action"?
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 05:01:38 PM
In the 'Users Online'.

You can test it this way: Go to "http://www.tinyportal.net/index.php?action=forum" in your fav. browser, then open another browser where you are not logged in. Go to http://www.tinyportal.net/index.php?action=who and you will see your profile as "unknown action".
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 29, 2009, 05:07:49 PM
Hmmm, rather strange,

Mine said:  Renegd98      11:06     Viewing Who's Online.

But I did see alot of Unknown actions.
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 29, 2009, 05:09:21 PM
You can file it as a bug. Please provide the steps required to reproduce the error, like you did above so Bloc has all the info to look at this, and also refer to this post.
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 05:42:46 PM
Quote from: Renegd98 on March 29, 2009, 05:07:49 PM
Hmmm, rather strange,

Mine said:  Renegd98      11:06     Viewing Who's Online.

But I did see alot of Unknown actions.

You have to use a browser (e.g IE7) to go to http://www.tinyportal.net/index.php?action=forum, then go to http://www.tinyportal.net/index.php?action=who in another browser (e.g FF) where you are not logged in, to see the status of your real profiles status.

I thought I was reporting in the bugs section.
Title: Re: action=forum == 'Unknown action'
Post by: IchBin on March 29, 2009, 05:44:42 PM
You are, but if you do it the proper way by going to the bugtracker a topic in the bugtracker will automatically generate the post in this board. This way, when Bloc looks at the bugtracker, he sees which bugs are open and closed. Right now, you have only made a topic, not a bug report.
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 05:46:39 PM
Just found it.
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 29, 2009, 06:31:19 PM
Bu if you are not logged in then you shouldn't be able to see the status of logged in users...
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 06:35:36 PM
I can
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 29, 2009, 06:37:16 PM
...
Title: Re: action=forum == 'Unknown action'
Post by: Skhilled on March 29, 2009, 07:37:45 PM
Me too.
Title: Re: action=forum == 'Unknown action'
Post by: Lesmond on March 29, 2009, 07:46:45 PM
Quote from: Renegd98 on March 29, 2009, 06:31:19 PM
Bu if you are not logged in then you shouldn't be able to see the status of logged in users...

You don't have to be logged in on tp to see the users or profiles, something I think should be changed IMHO 
Title: Re: action=forum == 'Unknown action'
Post by: Skhilled on March 29, 2009, 07:50:46 PM
I thought so. Can't see them on my site.
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 30, 2009, 01:37:22 AM
This setting may have something to do with it. i tis from SMF basic Settings...

Allow non-administrators to hide their online status?
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 30, 2009, 01:42:14 AM
Can't be. It's an option I always disable, and half of my users are often in "Unknown Action".
I tested with a few members today, and found it was only when they were on the board index we had the issue.
The same seems to apply here in this forum.
Title: Re: action=forum == 'Unknown action'
Post by: Renegd98 on March 30, 2009, 02:27:33 AM
Ok, lets see what Bloc comes up with. Thanks for posting the bug.
Title: Re: action=forum == 'Unknown action'
Post by: IchBin on March 30, 2009, 02:45:50 AM
For a quick fix, open Who.php in Sources folder and find this code about line 268:
// Viewing/editing a profile.
if ($actions['action'] == 'profile' || $actions['action'] == 'profile2')
{
// Whose?  Their own?
if (empty($actions['u']))
$actions['u'] = $url[1];

$data[$k] = $txt['who_hidden'];
$profile_ids[(int) $actions['u']][$k] = $actions['action'] == 'profile' ? $txt['who_viewprofile'] : $txt['who_profile'];
}


Add after that code this:

elseif ($actions['action'] == 'forum')
{
$data[$k] = 'Viewing the Forum Index';
}


You can change the text to say what ever you'd like.
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on March 30, 2009, 02:56:18 AM
IchBinâ„¢: Did the job, thx.
Title: Re: action=forum == 'Unknown action'
Post by: Akyhne on August 24, 2010, 12:06:05 PM
This is still an issue in TinyPortal 1.0 beta 5.2
Title: Re: action=forum == 'Unknown action'
Post by: ZarPrime on August 24, 2010, 04:42:08 PM
Akyhne,

Thanks for posting the reminder.  I'll make sure that this issue is in our new bugtracker and perhaps we can get Bloc to fix this for his next update. ;)

ZarPrime