Hi, I'm a recent adopter of TP, and I love it- it's got plenty of features but it's not bloated, plus it's easy to use. 10/10 :)
I migrated from an e107 CMS to Tinyportal, importing ~800 pages after all was said and done. I was able to map the categories and other fields so all the articles ended up where there were supposed to. Everything came across nicely, and after adding a few bits of the original site's CSS to Tinyportal's CSS, everything is looking good.
I'd like to donate $20 for copyright removal, but I don't plan to use the unlock code, I'd like to leave the copyright visible. I just want to show some appreciation for all the work that went into building TinyPortal.
Having TP available to move to saved me from a serious tech debt issue- one that forced the original site to either move or die, and I moved it to TP.
Thanks again for such a slick CMS add-on! Please tell me where to send a donation!
Thanks for the kind words.
@lurkalot handles the donations, although personally we could do with some more testers to check new features and or find/fix bugs.
MrMike glad you're liking TinyPortal, it sounds like youve been busy migrating all those articles etc. Nice job.
I'm betting you are using the latest version of TinyPortal and SMF 2.1.4 so the TP copyright doesn't show anyway and has been moved to the SMF credits page, just the TP help link will show bottom right of page.
As for donations, that's very kind and it will go towards hosting this support site. You can find a donation button at bottom of page.
As tino mentioned we really need testers to help out finding and fixing bugs etc, so let us know if interested please. ;)
Donation sent. :)
As for testing, I have found a few bugs (I think) and I'll try and list/detail them later.
Okay, here are a couple of things I've found during use...I'm not sure if they're bugs, it may just be me not understanding the system well enough.
1) Editing a download item- I can't seem to add a new icon to a download item- I go through the steps to upload the icon, the page refreshes, but it doesn't appear in the icon list. I can manually put a new icon in the directory and it appears in the list, but not when I upload it. I'm wondering if this might be a directory permission issue on my end perhaps (??)
2) I think there's an issue with using double-quotes in the title field in a couple of screens, like in the administrating a category screen and when creating or editing an article, etc. If you use a title like this:
Experts Say "Millennials" Are Killing The Pickle Industry
...what you'll end up with in the title field after saving it is:
Experts Say
Everything after the first quote is clipped off (including the first quote). I think this may also happen with single quotes in some places as well but I'm not 100% certain about that.
3) Also, one feature suggestion, if you feel it has merit. I'd love a Delete button (just for admins) on the edit screen for article pages so the page could be killed off on the spot. Hunting down a rogue article and paging to it can take a while.
4) Finally, could you please tell me where the CSS is for the pagination at the bottom of the Category pages is? I'd like to make the page buttons a little bigger. I've looked for it but I'm still unsure which bit it is.
Thank you!
Quote from: MrMike on September 11, 2023, 11:32:14 PMOkay, here are a couple of things I've found during use...I'm not sure if they're bugs, it may just be me not understanding the system well enough.
1) Editing a download item- I can't seem to add a new icon to a download item- I go through the steps to upload the icon, the page refreshes, but it doesn't appear in the icon list. I can manually put a new icon in the directory and it appears in the list, but not when I upload it. I'm wondering if this might be a directory permission issue on my end perhaps (??)
2) I think there's an issue with using double-quotes in the title field in a couple of screens, like in the administrating a category screen and when creating or editing an article, etc. If you use a title like this:
Experts Say "Millennials" Are Killing The Pickle Industry
...what you'll end up with in the title field after saving it is:
Experts Say
Everything after the first quote is clipped off (including the first quote). I think this may also happen with single quotes in some places as well but I'm not 100% certain about that.
3) Also, one feature suggestion, if you feel it has merit. I'd love a Delete button (just for admins) on the edit screen for article pages so the page could be killed off on the spot. Hunting down a rogue article and paging to it can take a while.
4) Finally, could you please tell me where the CSS is for the pagination at the bottom of the Category pages is? I'd like to make the page buttons a little bigger. I've looked for it but I'm still unsure which bit it is.
Thank you!
I'll look at these over the weekend if I get the chance.
If you know what css element it is you need to replace/change you can use tp-custom.css and put your own custom css in there which will overwrite what we have and also in theory not be changed when you do an upgrade.
Quote from: MrMike on September 11, 2023, 11:32:14 PMFinally, could you please tell me where the CSS is for the pagination at the bottom of the Category pages is? I'd like to make the page buttons a little bigger. I've looked for it but I'm still unsure which bit it is
It is in tp-style.css
Quote from: tino on September 14, 2023, 10:45:02 AM3) Also, one feature suggestion, if you feel it has merit. I'd love a Delete button (just for admins) on the edit screen for article pages so the page could be killed off on the spot. Hunting down a rogue article and paging to it can take a while.
Just looking into this: it seems a usefull feature, but I am puzzled what page you would expect to return to after deleting an article in edit mode: you cannot return to the article page, since it is not there anymore.
Obvious solution would be to return to the "Articles in category" admin page, but that will be pretty confusing if the user is just accessing the article direct form the viewing page and deletes the article: you dont wat to dump them in an admin page.
The alternative would be to return to the category page for the category the article was in, but that has a similar downside for a user that comes from the admin page... seems like a catch 22.
I do not see a way to 'know' where a user came from before they edited the article...
Quote from: tino on September 14, 2023, 10:45:02 AM1) Editing a download item- I can't seem to add a new icon to a download item- I go through the steps to upload the icon, the page refreshes, but it doesn't appear in the icon list. I can manually put a new icon in the directory and it appears in the list, but not when I upload it. I'm wondering if this might be a directory permission issue on my end perhaps (??)
There is no function to upload icons from the user interface: you can upload an image (screenshot) that will show as illustration for the one upload, but not as a re-usable icon.
If you want extra icons you will need to load them via ftp (as you did)
2023-09-23_201809.jpg
Quote from: MrMike on September 11, 2023, 11:32:14 PMI think there's an issue with using double-quotes in the title field in a couple of screens, like in the administrating a category screen and when creating or editing an article, etc. If you use a title like this:
Experts Say "Millennials" Are Killing The Pickle Industry
...what you'll end up with in the title field after saving it is:
Experts Say
Everything after the first quote is clipped off (including the first quote). I think this may also happen with single quotes in some places as well but I'm not 100% certain about that.
Confirmed: titles of Categories, Articles and Downloads are being truncated when using double quotes.
Singe quotes work fine by the way...
Interestingly the Download categories DO accept the double quotes without issue
There's also an issue with using quotes as part of a search term. I made a post on that here: https://www.tinyportal.net/index.php?topic=36891.msg303684
Quote from: MrMike on September 11, 2023, 11:32:14 PM3) Also, one feature suggestion, if you feel it has merit. I'd love a Delete button (just for admins) on the edit screen for article pages so the page could be killed off on the spot. Hunting down a rogue article and paging to it can take a while.
I have been playing around with this, and it is not that obvious where to put the delete button and what to do as the redirect when deleting the article.
What about this?
2023-11-07_193043.jpg
Since is is net clear where a user is coming from when deleting the article I think is is best to redirect back to the TinyPortal/Articles page: /index.php?action=tpadmin;sa=articles
Quote from: @rjen on November 07, 2023, 06:32:47 PMQuote from: MrMike on September 11, 2023, 11:32:14 PM3) Also, one feature suggestion, if you feel it has merit. I'd love a Delete button (just for admins) on the edit screen for article pages so the page could be killed off on the spot. Hunting down a rogue article and paging to it can take a while.
I have been playing around with this, and it is not that obvious where to put the delete button and what to do as the redirect when deleting the article.
What about this?
2023-11-07_193043.jpg
Since is is net clear where a user is coming from when deleting the article I think is is best to redirect back to the TinyPortal/Articles page: /index.php?action=tpadmin;sa=articles
@lurkalot @tino do you feel this change is worthwhile to add to the next version?
The original requester does not seem to need it that much, since he has not replied even though he has been online after I posted...
I'm not sure to be honest. It looks a little risky to me being able to just delete it from there. Does it give a confirmation message after clicking the delete button, or does it just rely on the advanced warning message next to the button? I mean if you accidently click it, it's gone.
Personally I'd prefer a one click Deactivate button, so at least you would see the none active article in the article manager which can then be deleted or recycled into a new article if desired.
It will still ask confirmation. No more risk then deleting from the list view
Thanks, wasn't sure hence the question. ;)
In that case I don't mind either way, it's up to you guys if you think it's worth adding, I will probably stick with the old method because I'm so used to doing it that way.
If there is confirmation then happy with adding the button.
What you redirect back to makes sense.
Quote from: @rjen on November 15, 2023, 02:07:22 PMThe original requester does not seem to need it that much, since he has not replied even though he has been online after I posted...
Sorry, I've been in and out, some minor medical issues and stuff like that. I thought it would be a handy addition, but in retrospect, probably not worth a lot of coding or work.
I was more concerned about the title truncating issue; will there be a fix or update for that at some point?
Quote from: MrMike on November 22, 2023, 05:39:36 PMQuote from: @rjen on November 15, 2023, 02:07:22 PMThe original requester does not seem to need it that much, since he has not replied even though he has been online after I posted...
Sorry, I've been in and out, some minor medical issues and stuff like that. I thought it would be a handy addition, but in retrospect, probably not worth a lot of coding or work.
I was more concerned about the title truncating issue; will there be a fix or update for that at some point?
I'll try and look at the truncating issue, is there an error in the log? It's not properly escaping the string somewhere...
I reproduced the issue on my forum: there are no errors, not in the SMF log, nor in the server log...
Just noticed that when quotes are included in the 'short description' the display of the Category is completely broken...
I assume the URL becomes invalid...
So it seems that name as well as short name needs to be sanitized...
2023-12-12_095618.jpg
2023-12-12_100053.jpg
%27 is ' I think.
Quote from: tino on December 12, 2023, 01:47:29 PM%27 is ' I think.
I think so too, but as a result the URL does not bring me to the correct downloads category page...
Just tested and found that the same happens with articles: using quotes in the short name also breaks the links to the page...
2023-12-12_151622.jpg
Ok... what have I done wrong?
Don't know: can it be SQL or php related?
I am on php 8.0.13
Quote from: @rjen on December 12, 2023, 08:51:13 PMDon't know: can it be SQL or php related?
I am on php 8.0.13
Should'nt be, there is a issue with the title edit section shortening it.
I can also recreate the shortname issue, so working those through.
Yep. I saw we have a rudimentary function stripping spaces from the article short name, but nothin on categories and downloads.
I think the shortname should never allow for special characters
Quote from: @rjen on December 12, 2023, 09:11:51 PMI think the shortname should never allow for special characters
That's the easier solution, so you want them stripped?
The current function replaces spaces with dashes: for backward compatibility it would be nice to keep that
Ok, I've added a pattern on the input field and correctly decoded the entity on display.
https://github.com/Tinyportal/TinyPortal/pull/979/files
We can repeat the pattern on any other instance we want to limit.
Yep that will do it. Thanks
Now we still have the issue with the nam field
Quote from: @rjen on December 13, 2023, 01:05:28 PMNow we still have the issue with the nam field
What issue? That should be fixed if you mean the displaying with quotes.
When was that fixed?
Quote from: @rjen on December 13, 2023, 01:13:11 PMWhen was that fixed?
In my commit just now, with the input fix.
okay, let me check... I only saw the code on my phone...
NO quite...
when I create an articel with this a title and short name
Experts Say 'Millennials' Are Killing The Pickle Industry
It still breaks..
I cannot access the article, because this URL is generated...
https://test.fjr-club.nl/index.php?page=Experts-Say-%27Millennials%27-Are-Killing-The-Pickle-Industry
its the space you included that does not work... let's see if I can fix it...
this work...
pattern="[A-Za-z0-9 ]+"
had some issues with allowing spaces and - characters. It seems the following is better: just excluding the use of quotes...
<input type="text" id="tp_article_shortname" name="tp_article_shortname" value="'.$mg['shortname'].'" size=20 pattern="[^\'\x22]+" >
I don't get the link issues you're experiencing so can't help much on that front.
Happy to go with whatever works mind!
Just tested with all changes...
I applied the pattern to all short names: articles, categories and downloads, and is is no longer possible to use single or double quotes in the short names > GOOD
I tried the article name articlecategory name and download category name with both single or double quotes and they now work in all cases. > GOOD
Then I tried adding a download with double quotes in the name: that still gets truncated...
See the screenshots
It'll be display again. Missed your post where you said it was downloads also so only tested articles and categories.