To install this version, you'll need to uninstall the previous version first. There is a couple of database changes necessary for the new features I've added.
PLEASE MAKE A BACKUP OF BOTH FILES AND DATABASE BEFORE ATTEMPTING THIS UPDATE
This has a couple more options in it.
- User Avatar shown when viewing the list of reviews in a category
- Option to show 10 recent items on frontpage.
Been a while since I've looked hard at the code. Let me know if there are any errors. I don't think guest access or user rating is working 100% yet. Please post any problems or suggestions in this topic for this version.
I've had problems with zipping this on my mac and the install not working because of the way Mac handles zipping. So if there are any problems, you may want to try unzipping it and then rezipping. If you do have this problem, please report it. :)
Team Edit: TPReviews_1.0.zip has been attached; it has been re-zipped and a version number has been added to the name.
Thanks IchBinâ„¢! :up:
The package manager didn't like the file so I unzipped and edited the package-info.XML and added '1.1.10' to the install routine.
<install for="1.1.1 - 1.1.10 - 1.1.99"> After that the upload/install went off an expected.
Just starting to check some of the functions; got this when accessing the Reviews page:
Quotehttp://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=viewcat;id=2
2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tptest2/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 219
/tptest2/index.php?action=tpmod;rvws;sa=viewcat;id=2
Apply Filter: Only show the errors with the same message
8: Undefined index: sub_cats
File: /home/kenkayjm/public_html/tptest2/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 219
/tptest2/index.php?action=tpmod;rvws
Apply Filter: Only show the errors with the same message
8: Undefined index: rvws
File: /home/kenkayjm/public_html/tptest2/Themes/default/languages/TPReviews.english.php (tpr_home sub template - eval?)
Line: 45
One full page of errors when making and then rating a Review:
http://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=viewitem;id=3
Here's a sample of the errors:
Quotehttp://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=viewitem;id=3
2: Division by zero
File: /home/kenkayjm/public_html/tptest2/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 348
http://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=rate;id=3
2: Division by zero
File: /home/kenkayjm/public_html/tptest2/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 735
http://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=rate;id=3
2: Division by zero
File: /home/kenkayjm/public_html/tptest2/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 735
http://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=viewitem;id=3
2: Division by zero
File: /home/kenkayjm/public_html/tptest2/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 348
http://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=additem
8: Use of undefined constant __FILE_ - assumed '__FILE_'
File: /home/kenkayjm/public_html/tptest2/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 532
Ken, I don't know how but it looks like that zip I posted was an OLD one. Most of those errors that you are posting are errors that I fixed quite some time ago. Hold off on this and I'll try to post the right zip when I can get access to my files.
OK, sounds good.
Crip waits .......
Attached a new file in the first post. Give that one a whirl. I zipped it on my windows machine, so let me know if you still have problems unzipping. :)
OK... gonna try it now.
Got this on upload:
"An Error Has Occurred!
The package you tried to upload either is not a valid package or has become corrupted. "
Did the version number edit and it installed as expected, after a quick look it seems to be working fine with no errors. Will take a closer look later on.
Quote from: Ken on November 20, 2009, 03:23:44 PM
Did the version number edit and it installed as expected, after a quick look it seems to be working fine with no errors. Will take a closer look later on.
Ken.,
how do you EDIT "version number"....?
There's no need to edit the version number. Unzip it, and then rezip and see if it works. If Ken did this, I think he'd find that it would work regardless of the version change.
I need to figure out this stupid zip problem....
Ok B0ss will do.
I'll try it again without changing the numbers to see what happens.
Uninstalled the existing package, deleted it, downloaded a fresh copy of the zip and tried to upload... got the error again. :)
Quote
An Error Has Occurred!
The package you tried to upload either is not a valid package or has become corrupted.
EDIT: Dang it! Forgot to unzip-rezip!
Is this a TP install ?
Quote from: Crip on November 20, 2009, 05:07:10 PM
Is this a TP install ?
Jeff, you install it like a regular SMF Package, but then your controls are in your TP cp.
@Brad... once I did the upzip/rezip it installed with no problems and after a cursory look it's not throwing any errors.
EDIT: Brad, do you want to to attach the re-zipped package?
I no how to install it Ken. Lol ..
But is it a Full install of TP?
ETA . Ok i think this is only a Module Review and not a Full TP install yes?
Quote from: Crip on November 20, 2009, 05:15:49 PM
I no how to install it Ken. Lol ..
But is it a Full install of TP?
You lost me Jeff, what are you talking about? ...maybe me is having an old-fart attack or something. :o
Is this zip a Full Tinyportal Install ?
Quote from: Crip on November 20, 2009, 05:15:49 PM
I no how to install it Ken. Lol ..
But is it a Full install of TP?
ETA . Ok i think this is only a Module Review and not a Full TP install yes?
Yepp... it's only the Reviews and not TP.
ok .... my bad..
Not to worry Jeff... I was too slow. :)
Yes, feel free to drop my zip on the first post and add yours ken. Until I can figure out what the crud is wrong with my zipping that'll do.
Okay did an uninstall of the old TPReviews successfully and then did a delete successfully. Downloaded the update zip from Ken in the OP of this thread and installed it successfully. Below is a screen shot of the install status:
(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fwww.motleypixel.com%2Fpublic%2Fposts%2Ftp_reviews_v1.jpg&hash=d90bd05825d8584f0a0e43f87cb44a2e660c66b8)
Also, what are the two radio buttons (top one currently selected) for under the Notifications Type as show below:
(https://www.tinyportal.net/proxy.php?request=http%3A%2F%2Fwww.motleypixel.com%2Fpublic%2Fposts%2Ftp_reviews_v1_1.jpg&hash=70d8fcd7d3be096309f2f6f015be3309079e09c1)
Just doing the initial tests, but wanted to post this now.
Couple of quick thoughts:
1. previous reveiw data in the DB was preserved after the uninstall and delete.
2. I see my avatar only on the individual item index page only: http://www.motleypixel.com/forum/index.php?action=tpmod;rvws;sa=viewcat;id=1
3. Posted a "Test" comment which works fine but no avatar on the comments page: http://www.motleypixel.com/forum/index.php?action=tpmod;rvws;sa=viewitem;id=3
4. Trying to find the setting for the "Show Recent 10 on Front Page" but haven't yet. I do have the TPReviews Bloc custom code given by Dragooon on the first page of the original post, which is still working here: http://www.motleypixel.com/forum/index.php
5. Under TinyPortal Admin, Modules and Tags it still shows Dragooon as the Author, which I presume is correct, just stating for post uninstall/install records.
Thanks,
Roy
1. Good, that's the way it should be.
2. Yes, I've only added avatar to show you posted the items.
3. I don't recall anyone requesting avatars for comments, so I'll see about adding that in.
4. That is where the show recent review setting is. It would seem that something has happened with the language strings. Can you copy the TPReviews.english.php file from tp-files/tp-modules/TPReviews/language to Themes/default/languages/ folder? Let me know if you see text on next to those radio buttons.
5. That is fine for now, I've slowly started putting TP team in the credits and stuff. I'm not sure what kind of credit Dragoon wants for now, so I'll ask him before I finish changing all those things.
@IchBinâ„¢... I didn't add 'rev.7' to the name of the current attachment, if you need me to do a re-zip on the next one I'll try to remember to do that.
"4. That is where the show recent review setting is. It would seem that something has happened with the language strings. Can you copy the TPReviews.english.php file from tp-files/tp-modules/TPReviews/language to Themes/default/languages/ folder? Let me know if you see text on next to those radio buttons." This is done.
Okay, still no text and that's after a cache delete and hard refresh. I also tried changing the radio button from the top to the bottom and selecting bottom and saving resulted in a slight shift in the admin panels and the addition of the search bloc in the top right...weird...shown below. Also attached is the language file.
http://www.motleypixel.com/public/posts/tp_reviews_v1_2.jpg
-Roy
---------
Edit ))
This image was wayyyyyyy to big .......
I left the link .. please do not post huge images ......
.....a link will work thank you Roy... Ok :)
Crip~
language file looks fine. Where is this file from? Can you look at the file in both locations and see if the last several lines are the same?
@Ken
No worries. I have the version number in a text file inside the zip so I'm not too worried at the moment.
Okay, in the screen shot below...the left is the file I copied from the new tp modules/tpreviews dir to the themes\default\languages folder and the right is the current one in the new tp modules/tpreviews dir.
http://www.motleypixel.com/public/posts/tp_english.jpg
Other than your editor or something has added some extra lines to the one file, I don't see anything that should cause the missing text. Are you getting any errors in your SMF log about Undefined index when you access the settings page for Reviews?
Yea the extra lines seem weird, all I did was ftp down and then up to the default theme location...hummm.
I haven't tried any smf log trouble shooting before, so I'll have to look up where to look for those.
Thanks,
Roy
In your admin panel under the maintenance section there is a link that says error log. When you get in there, the best thing to do is to clear it. Then access the settings page in TPreviews. Look and see if any new errors have appeared in your error log after that.
Okay,
Finally got around to testing this out. Here are the errors the pretty much spam my error log. I cleared the entire log and then went to tpreviews admin and settings and checked each of the radio buttons that don't have any text to the left of them and here are the repeat logs (each one is a bit different but they do repeat often):
motleypixel Today at 08:38:39 AM
66.179.173.187 c48c59e03f574c86c31281a4c919509b
http://www.motleypixel.com/forum/index.php?action=tpmod;rvws;sa=adminsettings
8: Undefined index: rv_recent_item
File: /home/lexurld/public_html/motleypixel.com/forum/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 1349
motleypixel Today at 08:38:39 AM
66.179.173.187 c48c59e03f574c86c31281a4c919509b
http://www.motleypixel.com/forum/index.php?action=tpmod;rvws;sa=adminsettings
8: Undefined index: rv_front_none
File: /home/lexurld/public_html/motleypixel.com/forum/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 1348
motleypixel Today at 08:38:39 AM
66.179.173.187 c48c59e03f574c86c31281a4c919509b
http://www.motleypixel.com/forum/index.php?action=tpmod;rvws;sa=adminsettings
8: Undefined index: rv_front_display
File: /home/lexurld/public_html/motleypixel.com/forum/tp-files/tp-modules/TPReviews/Sources/TPReviews.php
Line: 1345
motleypixel Today at 08:38:19 AM
66.179.173.187 c48c59e03f574c86c31281a4c919509b
http://www.motleypixel.com/forum/index.php?action=tpmod;rvws
8: Undefined index: recent_date
File: /home/lexurld/public_html/motleypixel.com/forum/Themes/BlackRain1/languages/TPReviews.english.php (tpr_home sub template - eval?)
Line: 47
I can't replicate your issue on my site. If you wouldn't mind, I'll take a look at yours if you want. Don't know why you're install isnt' picking up the changes. PM me the login info for a temp admin account and FTP if you want.
Hello, all. :)
Is it working for 0. 9. 8?
dimdom, it's not designed to install directly into TinyPortal, instead it installs into SMF Package system and it is then accessed by the TP Module system.
So, because TP 0.9.8 doesn't have the Module system then the answer is no, it won't work with TP 0.9.8
Ok Lex, it was because you have copied the TPReviews.english.php file to your blackrain theme previously. It still had the old one which didn't have the changes I made. There's no need to have any of the TPReviews files in a custom theme, so I've just renamed it so that it will just use the default themes files. There shouldn't be any problems now. Let me know if there's anything else.
This topic seems to be locked, any special reason it's set as locked cause i cant see any ???
Quote from: G6 on December 05, 2009, 11:22:01 AM
This topic seems to be locked, any special reason it's set as locked cause i cant see any ???
Don't know it was locked, maybe someone clicked that button by mistake?
It's unlocked now.
Hmm... it would appear that I locked it. lol Don't know how, but thanks for unlocking! :)
Okay, I installed this and have access to the admin site of things....but there is nothing showing on my frontpage or forum index.
Was this supposed to add something to the horizontal menu at the top of site, or do I need to add my own link to the reviews section?
I'm approaching this from a total "user" point of view so I've got kind of "no knowledge" perspective....
Linky: http://leafboxtea.com
You'll need to add your own link to: http://leafboxtea.com/index.php?action=tpmod;rvws
The latest rev allows you to enable recent reviews or just cats to the index page of the reviews. Using TP block you can also add recent reviews uisng the below php code which still seems to work for me:
global $context, $db_prefix, $scripturl;
$tp_prefix = $context['tp_prefix'];
$cat = array();
$request = db_query("
SELECT r.title, mem.realName, r.id, mem.ID_MEMBER, r.posted_on
FROM {$tp_prefix}reviews AS r
INNER JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER = r.posted_by)
WHERE r.approved = 1
".(!empty($cat) && is_array($cat) ? 'AND r.category IN ('.implode(',',$cat).')' : (!empty($cat) && is_numeric($cat) ? 'AND r.category = '.$cat : ''))."
AND r.type = 'item'
ORDER BY r.id DESC
LIMIT 10",__FILE__,__LINE__);
$reviews = array();
while($row = mysql_fetch_assoc($request)) {
$reviews[] = array(
'id' => $row['id'],
'title' => $row['title'],
'mem_link' => '<a href="'.$scripturl.'?action=profile;u='.$row['ID_MEMBER'].'">'.$row['realName'].'</a>',
'posted_on' => timeformat($row['posted_on']),
);
}
mysql_free_result($request);
$total = count($reviews);
$i = 0;
foreach($reviews AS $review) {
$i++;
echo '<div class="smalltext"><a href="',$scripturl,'?action=tpmod;rvws;sa=viewitem;id='.$review['id'].'">'.$review['title'].'</a><br />['.$review['posted_on'].']<br /> by ',$review['mem_link'],'</div>';
if($i < $total)
echo '<hr />';
}
Glad to see a new user using this mod. I'm gearing up to start publishing many more review cats soon.
-Roy
great -thanks for that. So far, so good.
Something else has come up - all the rating options. I don't need user's and critic's reviews. Where do I go to remove "critic's reviews". on the review page it just clutters things up and causes confusion
I'll have to take a look. I'm not so sure those options can be taken out so easily. Will have to get back to you on that.
Just added a new review item and plan to start adding a lot more. Found something odd and have a few thoughts as well:
1. I commented on my new review item (lens) and adding a 1024X682 img it makes the image float out of the bounds of the comment section. So it doesn't constrain and add a horizontal scroll bar like in the forum. Here's the link to the new review item: http://www.motleypixel.com/forum/index.php?action=tpmod;rvws;sa=viewitem;id=15 hereââ,¬â,,¢s a link to a similar-sized image (exact same size) in the forum where it doesn't do this: http://www.motleypixel.com/forum/index.php/topic,379.0.html
2. When I create a new review item it doesn't carry over the "rating fields" so I have to manually enter them all over again. This probably isn't that noticeable now for early adopters or for developers that don't actually used it to post many reviews, but it's something to consider if you can store the fields in the db to recall them.
3. I'm beginning to think the 5 star system isn't granular enough once more and more reviews are posted for a review item. Not sure of the averaging logic but the difference between 4 and 5 stars should at least show 4.5 stars (like Amazon) but I don't think it does this. Is there a way we can also use plain integer ratings i.e. 1-5 with the averaging carrying to the tenths place? i.e. rating 4.6 is more meaningful than 5 stars.
Just chiming in...had some time this afternoon to play with this some more. Hope everyone has a great holiday and happy new year!
-Roy
1. Looks like the table that is sitting in could use some overflow. If the overflow is set to auto it will automatically create the scrollbars for the overlap on the image.
2. I do not like the current rating system. It is very cumbersome IMO. I'd like to change it, but that will take some time before I get to that.
3. See #2. :)
I actually just started last night updating the database routines for getting it SMF2+TP ready. It'll take some time though, as I'm just learning the new functions for SMF2 and TP1beta5.
Thanks for the update Brad...I understand priorities. Looking forward to all the work the smf and tp team has put towards the new releases.
-Roy
Lack of screenshots or demo is annoying :(
Interesting..... i could use this.
Quote from: Silver Knight on December 21, 2009, 03:09:51 AM
Lack of screenshots or demo is annoying :(
My live site has just made the transition to SMF2 RC2 & TinyPortal v1.0 beta5, so my Reviews are not available there currently, but you can see an example on my test forum here:
http://www.ourfamilyforum.org/tptest2/index.php?action=tpmod;rvws;sa=viewcat;id=2
Of course the inventory of reviews is much larger and the content is much more detailed on the live site... hopefully it will be available again soon, however no time table or 'due' date will be set for an RC2 release.
Is it possible to modify this package so it will work WITHOUT TP being installed?
Regards
Eddy
Nope. It is completely embedded with TP. It would take a rewrite to make it run stand alone.
What do you guys think about having the option for rating type? I really hate the way ratings are done currently. I'd much rather see ratings either available or not available. What I'd like to do is make it so that rating is more like TP's article rating. With the option to rate while currently on the reviews page. And if I'm cool enough, maybe make it ajax based so there's no page refresh in order to rate it. Thougts? Suggestions?
Having the ability to turn off the ratings would be nice, not having a choice as in the current configuration can sometimes get in the way.
Being more like the TP Articles system would be nice, but it's also nice to be able to apply more that one rating 'question' to the mix as it's set for now.
It would be great if the Ajax feature can be easily included. :up:
I still plan to keep critic and user ratings. I just want to simplify how it's displayed, as well as how to rate it. If I can do what is in my mind, it would be easier to create a couple of block codes for this to grab most rated, or highest rated etc.
Hope that all makes sense. :)
Calling attention to the reviews would be a good thing and a block code would be a great way to do that.
Ajax would be nice ;)
Any thoughts using Tags also?
hmmm.... thats a good point. I love tagging. Could be a good thing for this module. I'll put it on my todo list. :)
Quote from: IchBinâ„¢ on February 03, 2010, 12:14:43 AM
hmmm.... thats a good point. I love tagging. Could be a good thing for this module. I'll put it on my todo list. :)
That would be sweet.
Just discovered that 'guests' are not able to see the reviews on my site, am I missing the setting or do we need to add that option?
... yes I've looked and looked and looked ;)
It's not a permission in the reviews module, it should be an option in the permissions for SMF to allow guests to see reviews though. Let me know if you don't see that.
Had looked there already, but looked again just in case... no permissions for the module are in the SMF permissions screen.
meh, I'll have to look when I can figure out how to get access to my SVN from work. I don't have it on any live SMF2 sites so I can't look at it right now. I'll keep you posted. Feel free to remind me if you don't hear anything fairly soon.
Quote from: IchBinâ„¢ on February 26, 2010, 03:20:45 PM
meh, I'll have to look when I can figure out how to get access to my SVN from work. I don't have it on any live SMF2 sites so I can't look at it right now. I'll keep you posted. Feel free to remind me if you don't hear anything fairly soon.
OK... Thanks Brad.
Just installed it to my test site and checked, looks the same there.
If it helps I can set an account there for you. (or on my live site if you like... it has file manager installed)
Go ahead and send me a login for your test site. I don't want to touch your live site. lol
Done. :)
http://www.ourfamilyforum.org/SMF2.0/index.php
Howdy!
Newcomer to TP, but longtime user of SMF.
I'd like to have a go with this mod, but when I try to upload, it says it's not compatible with SMF2RC3. Is this correct? If so, any chance of an upgrade? :)
I don't think this mod is supported anymore, but we can wait and see if IchBin can indeed update it!
I thought Ken had this installed on his RC3/TP 1.0 beta 5.2 test site, and even his live site, but I could be wrong. Ken has worked a lot with Ichbin on this Mod. Chinaren, even though it is installed with the SMF Package Manager, it does require TinyPortal to be installed first.
Maybe when Ken or Ichbin logs in here, one or both will comment on this.
ZarPrime
Quote from: ZarPrime on July 04, 2010, 03:08:53 PM
Chinaren, even though it is installed with the SMF Package Manager, it does require TinyPortal to be installed first.
Yah, I have TinyPortal 1.0 beta 5.2 installed, though I'm just getting to grips with it really. Perhaps I didn't download the correct version or something.
Anyway, shall await more detail (hopefully) from the mod author.
The attached is the current version that I'm using on my live site (http://www.ourfamilyforum.org/FamilyForum/index.php?action=tpmod;rvws):
SMF 2.0 RC3
TinyPortal 1.0 beta 5.2
It may work OK on your version, but if not then you may need to upgrade to the same versions as those on my site.
If you have problems with it then we may have to wait for Ichbin to return.
Thanks for the download Ken!
However, it still comes up with:
QuoteThe package you are trying to download or install is either corrupt or not compatible with this version of SMF.
...when I try to install it, which is weird, 'cos my version is RC3 and TP1 b5.2 too. ???
I'm doing it right yes? Uploading with the SMF package manager?
Sorry that it did not work for you.
Yes you are doing it right, it installs through the package manager. I tried to edit the install routine to include SMF RC3 but it threw the same error on my test site that you saw on your site.
It is likely that it works OK on my live site because it was already installed before the site was upgraded.
We'll need to wait until Ichbin returns and has time to take a look at the code.
create a folder in the SMF packages folder and name it tpreviews. Upload the contents of the zip that Ken posted for you to that folder. You should then see the option to install in your package manager page in SMF. If that doesn't work, try unzipping and then rezipping the package making sure to maintain the same folder structure. Then try the install with your new zip. If none of these work, report back with the errors you get. I haven't had the time to look at this package for quite some time.
I changed it from rc2 to rc3 in the package-info.xml, rezipped and it installed fine. But how do you add a category?
It may not be working. It's been a long time since I have looked at this. I just don't have the time to figure out how to make it work completely in SMF2... With all the changes that Bloc has made to TP lately, it would be pretty much a rewrite to get it to work I think. TBH, I can't even remember how this module works. Ken may have a working version, though I'm not sure.
My install is still in place, but has been inactive for some time now, so I've kind of lost track.
http://www.ourfamilyforum.org/FamilyForum/index.php?action=tpmod;rvws
In looking through the admin cp for the reviews module I'm not seeing an option for adding a new category, so at some point during our update process that option seems to have been left out.
I'll try loading it to my testsite to see what that looks like and post back later today, or tomorrow.
Finding the same issue with the testsite, no option for adding a new category.
http://www.ourfamilyforum.org/SMF2.0/index.php?action=tpmod;rvws
There are also three buttons with no image or text. They go to the admin area, which you are already in. :idiot2:
What would be really neat is to have this tied into the download section. So, for every download item, there would be a button "Review (download title)" instead of the rate it button. Then the category and subcategory would be set from the download item. And a further subcategory from the title of the download, since there could be more than one review of each item. Then there would be a list of reviews below the item. And maybe an averaged rating, for each item, from the overall rating of each item.
I've got the version 2 installed with no problems, but i can't seem to find what selection to put in a block? i dont see anything with tpreviews named in the block selection but i can activate it in the admin, seems really weird
I also got the version 2 installed without problem on 2.0 RC4 . I can t see where i can use review in the blocs . I create a new "module" bloc , the only choice i get after in the bloc editing page is TPShout ,but no TPReview.
I 'd really like to add some review for my site, it's really missing atm and will be a great addition.